Message ID | 20221018083820.25297-1-jiapeng.chong@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4ac7:0:0:0:0:0 with SMTP id y7csp1850853wrs; Tue, 18 Oct 2022 02:06:41 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4XSdklSJSg7wEy2K9AXK2hqIBo/6KDWlkW73peixr70FBSsRvJ47nQcvBF84TmRl7/3Pap X-Received: by 2002:a17:907:701:b0:780:2c44:e4dd with SMTP id xb1-20020a170907070100b007802c44e4ddmr1582850ejb.589.1666084001496; Tue, 18 Oct 2022 02:06:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666084001; cv=none; d=google.com; s=arc-20160816; b=FwlZwT9BGFEhvyzSqCnD2S5V8ECjVr73ka31vlRRWVccFCwLLzR8WW+jDHRJdnZ9pY q5e3JcqpKkFPcQTMombzzWUNpPIIEK4zi1p71Uy3jdjnyJgPfS1pPN6h23TgjyJbNrOg SoeDBUO+XjYExGHW+YiUHYpI22qvI4AXIYyKXKTsnVFwYdKw1ERQGrmJSkGSNN6a/9bN kvE4smrUHIM4fP3AA3tRuOGuVpUAPk9DnTjmObC/xI7dQCaC9IuE7U+Lu0IOlzl6TF+e 8CAdutsoKTUI+7iuWOHHYWxETrowqOZh8zDIE8B/OZjux645nsKg+avXESKjTT9XofmY F22g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=66Xxbw9uM+Wk8xgQLftS/IeT9PSaPd0Ez6HrKL9aimE=; b=kuf8VXkJr9BBylMMkZllBJilSBUBXCPTCrU2paiu7ouT11lqXIoCTEbkqHPmI5kSJW Tfxc3yWWev0SjieMabmIP8knsZPB6Qs95G+JoCXIctZLg6v6U+SuegSSdbXb7Ptp+bJo Eifac5Wosi4DcyevL2r6Wsh+hCvhkcfFUlkM441Xixi6qDIVRBverm7xGRwVXBWc6/TU ux3jqtg1hUPBLxdoKPJURSC1UhSyT6XeZ6ugfF/R9MrSNZ4DO1LM83sinXnMYB9TVrC4 tdfOyz1Quql5qqXZlQnSLF+7gJoaamzjOq6Xk/oAODuijHBjKNfTOxWIrS5dwoonAlTs vBaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y2-20020a056402440200b00459f2befc4esi13578488eda.354.2022.10.18.02.06.16; Tue, 18 Oct 2022 02:06:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbiJRIjg (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Tue, 18 Oct 2022 04:39:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbiJRIjc (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 18 Oct 2022 04:39:32 -0400 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69E866574; Tue, 18 Oct 2022 01:39:29 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R991e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VSTn1kW_1666082351; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VSTn1kW_1666082351) by smtp.aliyun-inc.com; Tue, 18 Oct 2022 16:39:26 +0800 From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> To: peter.ujfalusi@gmail.com Cc: vkoul@kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, Abaci Robot <abaci@linux.alibaba.com> Subject: [PATCH] dmaengine: ti: edma: Remove the unused function edma_and() Date: Tue, 18 Oct 2022 16:38:20 +0800 Message-Id: <20221018083820.25297-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747015697940547172?= X-GMAIL-MSGID: =?utf-8?q?1747015697940547172?= |
Series |
dmaengine: ti: edma: Remove the unused function edma_and()
|
|
Commit Message
Jiapeng Chong
Oct. 18, 2022, 8:38 a.m. UTC
The function edma_and() is defined in the edma.c file, but not called
elsewhere, so remove this unused function.
drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/dma/ti/edma.c | 8 --------
1 file changed, 8 deletions(-)
Comments
On 18-10-22, 16:38, Jiapeng Chong wrote: > The function edma_and() is defined in the edma.c file, but not called > elsewhere, so remove this unused function. > > drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'. > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> Where is this report? > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/dma/ti/edma.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c > index fa06d7e6d8e3..9ea91c640c32 100644 > --- a/drivers/dma/ti/edma.c > +++ b/drivers/dma/ti/edma.c > @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and, > edma_write(ecc, offset, val); > } > > -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and) > -{ > - unsigned val = edma_read(ecc, offset); > - > - val &= and; > - edma_write(ecc, offset, val); > -} > - > static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or) > { > unsigned val = edma_read(ecc, offset); > -- > 2.20.1.7.g153144c
On 18/10/2022 11:38, Jiapeng Chong wrote: > The function edma_and() is defined in the edma.c file, but not called > elsewhere, so remove this unused function. > > drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'. 0f4c5b29e333 dmaengine: ti: edma: Remove some unused functions dropped edma_param_and() but left the edma_and() behind... Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com> > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > drivers/dma/ti/edma.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c > index fa06d7e6d8e3..9ea91c640c32 100644 > --- a/drivers/dma/ti/edma.c > +++ b/drivers/dma/ti/edma.c > @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and, > edma_write(ecc, offset, val); > } > > -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and) > -{ > - unsigned val = edma_read(ecc, offset); > - > - val &= and; > - edma_write(ecc, offset, val); > -} > - > static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or) > { > unsigned val = edma_read(ecc, offset);
On 20-10-22, 10:10, Jiapeng.Chong wrote: > The report is the link, which can be seen in the submitted patch description. Thank you. Pls dont top post! > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430 This bug says: "ABACI reported the following bug by code static scanning" Where is the ABACI report? > ------------------------------------------------------------------ > 发件人:Vinod Koul <vkoul@kernel.org> > 发送时间:2022年10月19日(星期三) 21:46 > 收件人:Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > 抄 送:peter.ujfalusi <peter.ujfalusi@gmail.com>; dmaengine <dmaengine@vger.kernel.org>; linux-kernel <linux-kernel@vger.kernel.org>; Abaci Robot <abaci@linux.alibaba.com> > 主 题:Re: [PATCH] dmaengine: ti: edma: Remove the unused function edma_and() > On 18-10-22, 16:38, Jiapeng Chong wrote: > > The function edma_and() is defined in the edma.c file, but not called > > elsewhere, so remove this unused function. > > > > drivers/dma/ti/edma.c:321:20: warning: unused function 'edma_and'. > > > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2430 > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Where is this report? > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > --- > > drivers/dma/ti/edma.c | 8 -------- > > 1 file changed, 8 deletions(-) > > > > diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c > > index fa06d7e6d8e3..9ea91c640c32 100644 > > --- a/drivers/dma/ti/edma.c > > +++ b/drivers/dma/ti/edma.c > > @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and, > > edma_write(ecc, offset, val); > > } > > > > -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and) > > -{ > > - unsigned val = edma_read(ecc, offset); > > - > > - val &= and; > > - edma_write(ecc, offset, val); > > -} > > - > > static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or) > > { > > unsigned val = edma_read(ecc, offset); > > -- > > 2.20.1.7.g153144c > -- > ~Vinod
diff --git a/drivers/dma/ti/edma.c b/drivers/dma/ti/edma.c index fa06d7e6d8e3..9ea91c640c32 100644 --- a/drivers/dma/ti/edma.c +++ b/drivers/dma/ti/edma.c @@ -318,14 +318,6 @@ static inline void edma_modify(struct edma_cc *ecc, int offset, unsigned and, edma_write(ecc, offset, val); } -static inline void edma_and(struct edma_cc *ecc, int offset, unsigned and) -{ - unsigned val = edma_read(ecc, offset); - - val &= and; - edma_write(ecc, offset, val); -} - static inline void edma_or(struct edma_cc *ecc, int offset, unsigned or) { unsigned val = edma_read(ecc, offset);