diff mbox series

[v4,1/4] extcon: Removed redundant null checking for class

Message ID 20230302090143.46678-2-bw365.lee@samsung.com
State New
Headers
Series Simplify extcon_dev_register function. |

Commit Message

Bumwoo Lee March 2, 2023, 9:01 a.m. UTC 
  create_extcon_class() is already Null checking.

Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
---
 drivers/extcon/extcon.c | 21 ++++++++++-----------
 1 file changed, 10 insertions(+), 11 deletions(-)

Comments

MyungJoo Ham March 8, 2023, 6:55 a.m. UTC | #1 
> create_extcon_class() is already Null checking.
> 
> Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
> ---
>  drivers/extcon/extcon.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index e1c71359b605..adcf01132f70 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon);
>  

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Chanwoo, please take a look at this series.
Chanwoo Choi March 13, 2023, 11:03 a.m. UTC | #2 
On 23. 3. 2. 18:01, Bumwoo Lee wrote:
> create_extcon_class() is already Null checking.
> 
> Signed-off-by: Bumwoo Lee <bw365.lee@samsung.com>
> ---
>  drivers/extcon/extcon.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index e1c71359b605..adcf01132f70 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1012,12 +1012,13 @@ ATTRIBUTE_GROUPS(extcon);
>  
>  static int create_extcon_class(void)
>  {
> -	if (!extcon_class) {
> -		extcon_class = class_create(THIS_MODULE, "extcon");
> -		if (IS_ERR(extcon_class))
> -			return PTR_ERR(extcon_class);
> -		extcon_class->dev_groups = extcon_groups;
> -	}
> +	if (extcon_class)
> +		return 0;
> +
> +	extcon_class = class_create(THIS_MODULE, "extcon");
> +	if (IS_ERR(extcon_class))
> +		return PTR_ERR(extcon_class);
> +	extcon_class->dev_groups = extcon_groups;
>  
>  	return 0;
>  }
> @@ -1088,11 +1089,9 @@ int extcon_dev_register(struct extcon_dev *edev)
>  	int ret, index = 0;
>  	static atomic_t edev_no = ATOMIC_INIT(-1);
>  
> -	if (!extcon_class) {
> -		ret = create_extcon_class();
> -		if (ret < 0)
> -			return ret;
> -	}
> +	ret = create_extcon_class();
> +	if (ret < 0)
> +		return ret;
>  
>  	if (!edev || !edev->supported_cable)
>  		return -EINVAL;


Applied it with following edited title:
On later, please write the patch title in command form.

extcon: Remove redundant null checking for class
diff mbox series

Patch

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index e1c71359b605..adcf01132f70 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1012,12 +1012,13 @@  ATTRIBUTE_GROUPS(extcon);
 
 static int create_extcon_class(void)
 {
-	if (!extcon_class) {
-		extcon_class = class_create(THIS_MODULE, "extcon");
-		if (IS_ERR(extcon_class))
-			return PTR_ERR(extcon_class);
-		extcon_class->dev_groups = extcon_groups;
-	}
+	if (extcon_class)
+		return 0;
+
+	extcon_class = class_create(THIS_MODULE, "extcon");
+	if (IS_ERR(extcon_class))
+		return PTR_ERR(extcon_class);
+	extcon_class->dev_groups = extcon_groups;
 
 	return 0;
 }
@@ -1088,11 +1089,9 @@  int extcon_dev_register(struct extcon_dev *edev)
 	int ret, index = 0;
 	static atomic_t edev_no = ATOMIC_INIT(-1);
 
-	if (!extcon_class) {
-		ret = create_extcon_class();
-		if (ret < 0)
-			return ret;
-	}
+	ret = create_extcon_class();
+	if (ret < 0)
+		return ret;
 
 	if (!edev || !edev->supported_cable)
 		return -EINVAL;