[1/8] arm64: dts: qcom: sda660-inforce: correct key node name

Message ID 20230312183622.460488-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series [1/8] arm64: dts: qcom: sda660-inforce: correct key node name |

Commit Message

Krzysztof Kozlowski March 12, 2023, 6:36 p.m. UTC
  gpio-key bindings expect children to be named with generic prefix:

  sda660-inforce-ifc6560.dtb: gpio-keys: 'volup' does not match any of the regexes: ...

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Krzysztof Kozlowski March 12, 2023, 6:38 p.m. UTC | #1
On 12/03/2023 19:36, Krzysztof Kozlowski wrote:
> gpio-key bindings expect children to be named with generic prefix:
> 
>   sda660-inforce-ifc6560.dtb: gpio-keys: 'volup' does not match any of the regexes: ...
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Apologies, this one patch was sent second time, without a need. Previous
submission few minutes ago:

https://lore.kernel.org/linux-arm-msm/20230312173458.411231-1-krzysztof.kozlowski@linaro.org/T/#u

Best regards,
Krzysztof
  
Konrad Dybcio March 13, 2023, 8:47 a.m. UTC | #2
On 12.03.2023 19:36, Krzysztof Kozlowski wrote:
> gpio-key bindings expect children to be named with generic prefix:
> 
>   sda660-inforce-ifc6560.dtb: gpio-keys: 'volup' does not match any of the regexes: ...
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> index 7c81918eee66..7459525d9982 100644
> --- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> +++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
> @@ -29,7 +29,7 @@ chosen {
>  	gpio-keys {
>  		compatible = "gpio-keys";
>  
> -		volup {
> +		key-volup {
>  			label = "Volume Up";
>  			gpios = <&pm660l_gpios 7 GPIO_ACTIVE_LOW>;
>  			linux,code = <KEY_VOLUMEUP>;
  
Bjorn Andersson April 5, 2023, 4:09 a.m. UTC | #3
On Sun, 12 Mar 2023 19:36:15 +0100, Krzysztof Kozlowski wrote:
> gpio-key bindings expect children to be named with generic prefix:
> 
>   sda660-inforce-ifc6560.dtb: gpio-keys: 'volup' does not match any of the regexes: ...
> 
> 

Applied, thanks!

[1/8] arm64: dts: qcom: sda660-inforce: correct key node name
      commit: 0d8d77228aa1efec69f92ef92e1cd9270c1151c4
[2/8] arm64: dts: qcom: sc7280-herobrine-villager: correct trackpad supply
      commit: de88b1759b35086d5e63736fb604ea2d06486b1a
[3/8] arm64: dts: qcom: sc7180-trogdor-lazor: correct trackpad supply
      commit: 52e2996f253d82520011340d40dbc1c76ea79208
[4/8] arm64: dts: qcom: sc7180-trogdor-pazquel: correct trackpad supply
      commit: 24f39eec6a70768e7c2eb2f3d8158f45050ff75a
[5/8] arm64: dts: qcom: msm8998-oneplus-cheeseburger: revert "fix backlight pin function"
      commit: 97b4fdc6b82d6d5cfb92a9b164540278720fb700
[6/8] arm64: dts: qcom: msm8994-kitakami: drop unit address from PMI8994 regulator
      commit: 3555dd528ba9c08d6ccd56239c695dbeac3b63e3
[7/8] arm64: dts: qcom: msm8994-msft-lumia-octagon: drop unit address from PMI8994 regulator
      commit: 7a202df0f3eed006e4a9e7c06d62cf67be56c14c
[8/8] arm64: dts: qcom: apq8096-db820c: drop unit address from PMI8994 regulator
      commit: ec57cbce1a6d9384f8ac1ff966b204dc262f4927

Best regards,
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
index 7c81918eee66..7459525d9982 100644
--- a/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
+++ b/arch/arm64/boot/dts/qcom/sda660-inforce-ifc6560.dts
@@ -29,7 +29,7 @@  chosen {
 	gpio-keys {
 		compatible = "gpio-keys";
 
-		volup {
+		key-volup {
 			label = "Volume Up";
 			gpios = <&pm660l_gpios 7 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_VOLUMEUP>;