Message ID | 20230310222857.315629-7-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp4142wrd; Fri, 10 Mar 2023 14:38:54 -0800 (PST) X-Google-Smtp-Source: AK7set+wV5leexgg32f7YefdEbBB00sNrhNgNFObW9DJyUYH/ReX9CK+9LNWIq9L76Hk0IdxSSUK X-Received: by 2002:a62:3101:0:b0:5a9:d247:bc76 with SMTP id x1-20020a623101000000b005a9d247bc76mr21455257pfx.20.1678487933897; Fri, 10 Mar 2023 14:38:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678487933; cv=none; d=google.com; s=arc-20160816; b=nSSQxP5BhuZ/dyHGykwlVEsiwFESXlqjOhoiYvkB++SiE65SYLPMESFXuiWIfel4zC HFq9LplIq13ATi6r+v95HTqCC4U9oE9MycyRlbhyij4B5h14RQuuOFjYKpGkyxYiApPd h1VK6IoMAPR7EP0CycMRmTwdW8L7df2Q/4G0hOvpviwPESN/XdHlN+a/DnRw9IPt03Ht Mbqz+1QaKabg4DMkOn9K3iukCMOdiAeKC1WU1dDw2l8+/CXZChDdhIv72cKYTPPNqWiG u6NBsmsz8KcD6kywZ3Nd6LDE1lzXwfRWMT0jVXvzCHwELGwoBE0c4RYSL9gEzK5RFB4Q BSPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=BSow9olcoHPDQWGX+9sZKUw+pImGguqL+rxp9AEhbQU=; b=o2iVdI221hc1BTRtE5iPApbs+7nkjCZvQ8v9B9Svs9vU9IlUdwJcD+stIkyciue3sR c4qh8nc1orI5tQKhpJbGqoPG0Q54ZLJ2Z/rDDQNtAi1ya+OpEV8Q39F7dzkB8npj2jGU 5L+55WutUfLOGUHT0EekStnG0RYH3SYqcv8meem/5p5O97z0xx1vmzeXnQxy4tfFSKZJ QAOSQOFsgb1gDzCYe0wCJfuOcpW8ZOzWybgh70fvHFMiDp9X4eiGr+iShknEluUhkpNR 0/zQ4i0SETOEUXoPjFvu09YciMuYMKcljtnyyJIGJkumOFmUYBuvEicpPscrRYtK7UXM TS2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WMD94TId; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a7-20020a63d207000000b00502effd3bb9si792101pgg.521.2023.03.10.14.38.37; Fri, 10 Mar 2023 14:38:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=WMD94TId; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231996AbjCJW3g (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Fri, 10 Mar 2023 17:29:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43448 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231877AbjCJW3P (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 10 Mar 2023 17:29:15 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B0C2122CD2 for <linux-kernel@vger.kernel.org>; Fri, 10 Mar 2023 14:29:09 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id a25so26663643edb.0 for <linux-kernel@vger.kernel.org>; Fri, 10 Mar 2023 14:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678487349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=BSow9olcoHPDQWGX+9sZKUw+pImGguqL+rxp9AEhbQU=; b=WMD94TIdueIJwD4R0dzXoVlrA+lBE3XxCJOkt5lcGwJl3T9aSx5oXLSImUAdS8gGWj nevEWuDRfJ5RPH0TtzsEO8S3/WbblgN6c7T0caLdrg4JVyKOqAgZy1gYCF24w5rLBjjL MGSsSfrwG4aZGC+l8fhUpOJRtBywlP3akFV3IGOYCLF3G4b5n7kiyAbJDLHKhRR8a7LS Z2ZsSKJ0xALhO2Jtv+CXbxq0jXTpVzfN+2istoSvNEtpe8cznSwbbzPN3KeRr/R4kSF7 IFSRNgff5R+GmFDJEXkLP5PhiObPKCY/RCtarbKc44EdzHR0zp2QleIG+ceGsJi5jxoD dz9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678487349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BSow9olcoHPDQWGX+9sZKUw+pImGguqL+rxp9AEhbQU=; b=i4FbxUgA6b7NSlcYN4wFF2S2I1aQHqyW3prH62mlVtdbSgDdnPZsjEoIlMHd9TTl23 8DLfHvULh8+2naELVIWw06ZQxTjgEz9fMEw7ecgsm1wKsA3xouGgXp96lXFqT3FVoiQa A4KRDG9a7buIF/ulsGZK7dbmdX4Xy5V36pm3IkDRoMx6toTz//fkDyS3Jy12mYPyRPyH AOVPEzvgpAoqGdwiyvLdFCSKTUFLrgxLwHU/MPepzB1TKZ6TA3jZ34oYIEdGpWiW+Crj e7JkoY//U6j6tZhYRc89FEGJoUucvC5NReEc5HfUw+P98tP4+swNHdP8FWMIBxlqFr00 3nyA== X-Gm-Message-State: AO0yUKVefbTM4StJQTqKiaKXQ6913Y8t4S0c2Is9n5Eiq0K+KWlpLBgu 715O39XJ2P+1g76qt5OF43S+og== X-Received: by 2002:a17:906:8156:b0:886:221b:44e5 with SMTP id z22-20020a170906815600b00886221b44e5mr26872458ejw.62.1678487348858; Fri, 10 Mar 2023 14:29:08 -0800 (PST) Received: from krzk-bin.. ([2a02:810d:15c0:828:34:52e3:a77e:cac5]) by smtp.gmail.com with ESMTPSA id x101-20020a50baee000000b004aeeb476c5bsm525467ede.24.2023.03.10.14.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 14:29:08 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Mark Brown <broonie@kernel.org>, Kamal Dasu <kdasu.kdev@gmail.com>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Heiko Stuebner <heiko@sntech.de>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Andi Shyti <andi@etezian.org>, Alim Akhtar <alim.akhtar@samsung.com>, Stephen Boyd <sboyd@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: [PATCH 07/16] spi: s3c64xx: Drop of_match_ptr for ID table Date: Fri, 10 Mar 2023 23:28:48 +0100 Message-Id: <20230310222857.315629-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230310222857.315629-1-krzysztof.kozlowski@linaro.org> References: <20230310222857.315629-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760022163446570505?= X-GMAIL-MSGID: =?utf-8?q?1760022163446570505?= |
Series |
[01/16] spi: armada-3700: Drop of_match_ptr for ID table
|
|
Commit Message
Krzysztof Kozlowski
March 10, 2023, 10:28 p.m. UTC
The driver can match only via the DT table (all platforms are OF-only)
so the table should be always used and the of_match_ptr does not have
any sense (this also allows ACPI matching via PRP0001, even though it is
not relevant here).
drivers/spi/spi-s3c64xx.c:1496:34: error: ‘s3c64xx_spi_dt_match’ defined but not used [-Werror=unused-const-variable=]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/spi/spi-s3c64xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Krzysztof, On Fri, Mar 10, 2023 at 11:28:48PM +0100, Krzysztof Kozlowski wrote: > The driver can match only via the DT table (all platforms are OF-only) > so the table should be always used and the of_match_ptr does not have > any sense (this also allows ACPI matching via PRP0001, even though it is > not relevant here). > > drivers/spi/spi-s3c64xx.c:1496:34: error: ‘s3c64xx_spi_dt_match’ defined but not used [-Werror=unused-const-variable=] > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Thanks, Andi
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index cc69f8ffdbdc..7aec496070e2 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -1526,7 +1526,7 @@ static struct platform_driver s3c64xx_spi_driver = { .driver = { .name = "s3c64xx-spi", .pm = &s3c64xx_spi_pm, - .of_match_table = of_match_ptr(s3c64xx_spi_dt_match), + .of_match_table = s3c64xx_spi_dt_match, }, .probe = s3c64xx_spi_probe, .remove_new = s3c64xx_spi_remove,