diff mbox series

soc: qcom: gsbi: mark OF related data as maybe unused

Message ID 20230310214413.275054-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series soc: qcom: gsbi: mark OF related data as maybe unused |

Commit Message

Krzysztof Kozlowski March 10, 2023, 9:44 p.m. UTC 
  The driver can be compile tested with !CONFIG_OF making certain data
unused:

  drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/soc/qcom/qcom_gsbi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio March 11, 2023, 12:04 a.m. UTC | #1 
On 10.03.2023 22:44, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
> 
>   drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Shouldn't this driver depend on OF?

Konrad
>  drivers/soc/qcom/qcom_gsbi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
> index 290bdefbf28a..f1742e5bddb9 100644
> --- a/drivers/soc/qcom/qcom_gsbi.c
> +++ b/drivers/soc/qcom/qcom_gsbi.c
> @@ -114,7 +114,7 @@ struct gsbi_info {
>  	struct regmap *tcsr;
>  };
>  
> -static const struct of_device_id tcsr_dt_match[] = {
> +static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
>  	{ .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
>  	{ .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
>  	{ .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},
Konrad Dybcio March 11, 2023, 12:05 a.m. UTC | #2 
On 11.03.2023 01:04, Konrad Dybcio wrote:
> 
> 
> On 10.03.2023 22:44, Krzysztof Kozlowski wrote:
>> The driver can be compile tested with !CONFIG_OF making certain data
>> unused:
>>
>>   drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> Shouldn't this driver depend on OF?
> 
Nevermind, can't read.

Konrad
> Konrad
>>  drivers/soc/qcom/qcom_gsbi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
>> index 290bdefbf28a..f1742e5bddb9 100644
>> --- a/drivers/soc/qcom/qcom_gsbi.c
>> +++ b/drivers/soc/qcom/qcom_gsbi.c
>> @@ -114,7 +114,7 @@ struct gsbi_info {
>>  	struct regmap *tcsr;
>>  };
>>  
>> -static const struct of_device_id tcsr_dt_match[] = {
>> +static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
>>  	{ .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
>>  	{ .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
>>  	{ .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},
Bjorn Andersson March 15, 2023, 11:35 p.m. UTC | #3 
On Fri, 10 Mar 2023 22:44:13 +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF making certain data
> unused:
> 
>   drivers/soc/qcom/qcom_gsbi.c:117:34: error: ‘tcsr_dt_match’ defined but not used [-Werror=unused-const-variable=]
> 
> 

Applied, thanks!

[1/1] soc: qcom: gsbi: mark OF related data as maybe unused
      commit: 903caf42eabec2e39d836cb0aa8bbc23717408e7

Best regards,
diff mbox series

Patch

diff --git a/drivers/soc/qcom/qcom_gsbi.c b/drivers/soc/qcom/qcom_gsbi.c
index 290bdefbf28a..f1742e5bddb9 100644
--- a/drivers/soc/qcom/qcom_gsbi.c
+++ b/drivers/soc/qcom/qcom_gsbi.c
@@ -114,7 +114,7 @@  struct gsbi_info {
 	struct regmap *tcsr;
 };
 
-static const struct of_device_id tcsr_dt_match[] = {
+static const struct of_device_id tcsr_dt_match[] __maybe_unused = {
 	{ .compatible = "qcom,tcsr-ipq8064", .data = &config_ipq8064},
 	{ .compatible = "qcom,tcsr-apq8064", .data = &config_apq8064},
 	{ .compatible = "qcom,tcsr-msm8960", .data = &config_msm8960},