Message ID | 20230310111544.57342-1-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp813708wrd; Fri, 10 Mar 2023 03:26:52 -0800 (PST) X-Google-Smtp-Source: AK7set/b1xwRtMNqxezBBWBTWnFQCDNXOMPU/pNS5Z76X/hVW7LhoQ32uD+xiroTsZsipT+oLogv X-Received: by 2002:a17:90b:2246:b0:229:f4f3:e904 with SMTP id hk6-20020a17090b224600b00229f4f3e904mr27537558pjb.11.1678447611961; Fri, 10 Mar 2023 03:26:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678447611; cv=none; d=google.com; s=arc-20160816; b=BsBXJOIU/36qiPEMxIAUFyLo7YbuF2MyONtNn+cycIgBcRi4ezmMeDo7BP8wQB2u56 AeVv9wM1oNtEO4BDKagB3IrQVOKNzLbI2LVLwBGCr1PCaAtm2iDJ4267R1Ftlge68TJw aDejWZNHeq9n0zldtr1h6o2kAiCeCoCAOQxygGoVADBuSf4BGN04iLyDOUsNQbWVT4es ZY+ywqWjgMw30c6sOj2Vi6jBxVXq7OAeoLXRK9KMxXn0DwmPkFjhDXDoBZKdVzmRPUpM Uw8YBqUdskpo8yNHNvhSts+DbMye4kyv/sA43Wp+MKV6BblvTzjL0RfHHVsVkqMudfrl QM2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=p6zHeuFc6biZFfMiAZB0xtI37sIKkZAK9NYVa46Zq/Q=; b=JqhxBXyXHOayryb/kvOBdxhNxGnjVZ+5PvZ3WOAP2AJuzzUJqefyx/RqEtZJhXH8RF PP9GhEGqQYByVU4AxgZZNQS8NKsGGKMig1qR/I+heIFdukGkeyztjlKpKi5Irv4NNJk7 S2gb4bRGWuCmskeAXSupTF4Psv9XB88ElzcK3gAVhxUGKkLAoBt4o6nYzDnFnqaeSzOu 29Tm/AVcKO630wp7m8UcfACQciwEqAL5h8UKQQlMV21YpOWQUEpHq53RUdpDF/jMwMpX ytS2bkQl77gOMJ75yCPGGW+iaRP3hhz+KqoLsYZCDdYUrg6l7wADIuT1ysomuHsqbKTj C3EQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=behbJHKm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 143-20020a630095000000b004f2ab5fd76asi1769624pga.371.2023.03.10.03.26.37; Fri, 10 Mar 2023 03:26:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=behbJHKm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230107AbjCJLP2 (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Fri, 10 Mar 2023 06:15:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54720 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbjCJLPL (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 10 Mar 2023 06:15:11 -0500 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84AB3104AFC; Fri, 10 Mar 2023 03:15:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678446909; x=1709982909; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=5cipnkTtV2IAeEseLv2I7GLwybIA9bfYWqS/t41seXQ=; b=behbJHKmmAQurLmtTN/OOE32egKcyFn5RlClNgesxEwOZQEkn7dbqvjk kvFCrcVdv9pcUp/CN4QZFi1JJNHdnU1mQYgppB1c0bBreaCDR4dJ91HBp 9TSKL2uCpKYr76nNu0ZnXLySWrtialM8Tn4aGNo6O61wqyQJXXrZ8KP7H sL9s/MWRbRLsLYee6/qc1I7WuGjzTvJrJNcAN18/LsyeH2QikhV1v6wP3 A0Reb1Zd5Igp0gt3iTiJWQO9qz6tft23CV54LcxP03bFxCFe9i9U4CEaT PETWd73X4xAcAN5tQcNKTPYdkourA1tz6Y10545gqiLDv8Y3MIaO165/b A==; X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="335402012" X-IronPort-AV: E=Sophos;i="5.98,249,1673942400"; d="scan'208";a="335402012" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2023 03:15:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10644"; a="677775939" X-IronPort-AV: E=Sophos;i="5.98,249,1673942400"; d="scan'208";a="677775939" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 10 Mar 2023 03:15:07 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id C940314F; Fri, 10 Mar 2023 13:15:50 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, kernel test robot <lkp@intel.com> Subject: [PATCH v1 1/1] spi: mpc5xxx-psc: Remove goto to the unexisted label Date: Fri, 10 Mar 2023 13:15:44 +0200 Message-Id: <20230310111544.57342-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759979883444901153?= X-GMAIL-MSGID: =?utf-8?q?1759979883444901153?= |
Series |
[v1,1/1] spi: mpc5xxx-psc: Remove goto to the unexisted label
|
|
Commit Message
Andy Shevchenko
March 10, 2023, 11:15 a.m. UTC
The previous cleanup patch had lost one of its parts in a crack,
Finish the cleanup by removing the leftovers.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 9e21720a4958 ("spi: mpc5xxx-psc: use devm_clk_get_enabled() for core clock")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/spi/spi-mpc512x-psc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
Comments
Hi Andy, On Fri, Mar 10, 2023 at 01:15:44PM +0200, Andy Shevchenko wrote: > The previous cleanup patch had lost one of its parts in a crack, > Finish the cleanup by removing the leftovers. I wonder how this was compiling. > Reported-by: kernel test robot <lkp@intel.com> > Fixes: 9e21720a4958 ("spi: mpc5xxx-psc: use devm_clk_get_enabled() for core clock") > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Andi Shyti <andi.shyti@kernel.org> Andi
On Fri, 10 Mar 2023 13:15:44 +0200, Andy Shevchenko wrote: > The previous cleanup patch had lost one of its parts in a crack, > Finish the cleanup by removing the leftovers. > > Applied to broonie/spi.git for-next Thanks! [1/1] spi: mpc5xxx-psc: Remove goto to the unexisted label commit: 21d19e601fd221cd61105286b0b6ec2f9c5a2576 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-mpc512x-psc.c b/drivers/spi/spi-mpc512x-psc.c index 77a228f633d1..0b86f1804682 100644 --- a/drivers/spi/spi-mpc512x-psc.c +++ b/drivers/spi/spi-mpc512x-psc.c @@ -511,13 +511,9 @@ static int mpc512x_psc_spi_of_probe(struct platform_device *pdev) ret = mpc512x_psc_spi_port_config(master, mps); if (ret < 0) - goto free_ipg_clock; - - ret = devm_spi_register_master(dev, master); - if (ret < 0) - goto free_ipg_clock; + return ret; - return ret; + return devm_spi_register_master(dev, master); } static const struct of_device_id mpc512x_psc_spi_of_match[] = {