| Message ID | 20230310140023.223612-1-arnd@kernel.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp943111wrd;
Fri, 10 Mar 2023 07:42:37 -0800 (PST)
X-Google-Smtp-Source:
AK7set+A6cwaoomhLRPBdepHk2GdrO6z1gOrO6AI2e432JASitsivKaEpFpkYhewpeTrgrp+NGNg
X-Received: by 2002:a05:6a20:840d:b0:be:c1b2:514d with SMTP id
c13-20020a056a20840d00b000bec1b2514dmr3191432pzd.13.1678462957605;
Fri, 10 Mar 2023 07:42:37 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1678462957; cv=none;
d=google.com; s=arc-20160816;
b=dkrMHBoct7x378+LjYv7/n4GxYN4mky80jEKpdDzQi5Eso5B3sBQWYG8VX8HqCNAzv
pXnmH/jS2MG+aOD7+1UJnqqzUuaN841uY1idkbCnWjQGNDkIZ9aVH66hBD81X4cD0yLE
ii/m8ArPrWJGzZGQpSuUVN0OXtDrqysdu4DpYXw1ehBQLs1FR4eZBvniuoyYXNZpL0P6
VZjIAMXhJAEbEYXZm///Sznu7imtMwNfM1uQbny3rK278kA6SdspI77FUz0fhPB8mgYL
8dNgKaW24QvbZqnAlcvxyp4a8E65c5j2UN0k2r6Mu9MszBemG3tQC/lHhSh9wG+Fgouk
UH5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=BEP2iSvVVgWUtAXQYlLD31EN7JKKJF9x5sU0oLequp8=;
b=uE16xDNK3XlvdraLerDC1+KWg6pXWwpNvn+vXOyTR0pi6z4XDphw1OgWrrULDA0lVx
dYqBaeEO+HDXuGB1wkvmscJ2c+QCtAf+VVIY1eO/WV9B8VCtI3rt18FI9NwNlDrz48HC
zqacEtmc+8xeQXABibPpNHVmqzWFYiRs5gSSCXwjZbzwY6woGUtPU9vGVWW1jMVVpIyS
NARVY3jSJ05MbqD6KNE4ZqLjOvJIAtDAKHT7mluui2K39sre8EV4cvem9fj+7IiHbm/S
zLwYNiSJzw0BT59unMSw7WN3eW8NaTLYGYzXWVGdD2yJaSIo1xjMXkDQUh+i7dFXA3/M
w+ew==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qb9QXgOA;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
c4-20020a624e04000000b00590569bc56esi2208120pfb.298.2023.03.10.07.42.23;
Fri, 10 Mar 2023 07:42:37 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Qb9QXgOA;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231469AbjCJOAk (ORCPT <rfc822;carlos.wei.hk@gmail.com>
+ 99 others); Fri, 10 Mar 2023 09:00:40 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48152 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231478AbjCJOAc (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 10 Mar 2023 09:00:32 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org
[IPv6:2604:1380:4601:e00::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEFF0112A58;
Fri, 10 Mar 2023 06:00:31 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by ams.source.kernel.org (Postfix) with ESMTPS id 4B12BB822BF;
Fri, 10 Mar 2023 14:00:30 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 990C2C4339B;
Fri, 10 Mar 2023 14:00:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
s=k20201202; t=1678456829;
bh=R+aNQ2IomzRQdSTKJnVX3oPGOyIiRzPDND+HRf7aPI0=;
h=From:To:Cc:Subject:Date:From;
b=Qb9QXgOArCM3c3j11ny4vRgLytx4TuwhR/v1DJbg6b5LZOHKqFyhbd4rG35ET74KI
0asBNh27HvLIVBlRkT0b6vMjVqzVNsKafrfOJz/gNIMRE4Hcb2/QXOMsi/HZ31JCRY
9ZoZCasjzG5rLFWIpDoxm/kqLcB/Uz+GRYwEPn2ppaPF7Rm38boI2wwjMWw1RCXirR
aKw0lfYG80hgGCAXDzMBJMZQ9A+1NwsmZaq2lWr06PxND0IS9+jZhk6AujCIcJ6Bnb
1ZufFC2pF0lXEP/3Qz9xxvH9S67bKQ28iSZf+l111wUl3Cz+WCEwLA5Vl4QrgP7GMR
BX2n9WwTwVBNw==
From: Arnd Bergmann <arnd@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] platform/x86: x86-android-tablets: add CONFIG_PMIC_OPREGION
dependency
Date: Fri, 10 Mar 2023 15:00:15 +0100
Message-Id: <20230310140023.223612-1-arnd@kernel.org>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1759995974583632178?=
X-GMAIL-MSGID: =?utf-8?q?1759995974583632178?=
|
| Series |
platform/x86: x86-android-tablets: add CONFIG_PMIC_OPREGION dependency
|
|
Commit Message
Arnd Bergmann
March 10, 2023, 2 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> The newly added call to intel_soc_pmic_exec_mipi_pmic_seq_element() requires that function to be defined: x86_64-linux-ld: drivers/platform/x86/x86-android-tablets/lenovo.o: in function `lenovo_yt3_init': lenovo.c:(.init.text+0x72): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element' x86_64-linux-ld: lenovo.c:(.init.text+0x8b): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element' Fixes: 9b1d2662b8c5 ("platform/x86: x86-android-tablets: Add touchscreen support for Lenovo Yoga Tab 3 Pro YT3-X90F") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/x86-android-tablets/Kconfig | 1 + 1 file changed, 1 insertion(+)
Comments
Hi Arnd, On 3/10/23 15:00, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The newly added call to intel_soc_pmic_exec_mipi_pmic_seq_element() > requires that function to be defined: > > x86_64-linux-ld: drivers/platform/x86/x86-android-tablets/lenovo.o: in function `lenovo_yt3_init': > lenovo.c:(.init.text+0x72): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element' > x86_64-linux-ld: lenovo.c:(.init.text+0x8b): undefined reference to `intel_soc_pmic_exec_mipi_pmic_seq_element' > > Fixes: 9b1d2662b8c5 ("platform/x86: x86-android-tablets: Add touchscreen support for Lenovo Yoga Tab 3 Pro YT3-X90F") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks, but this is a dup with: https://patchwork.kernel.org/project/platform-driver-x86/patch/20230309094035.18736-1-hdegoede@redhat.com/ I just did not get around to pushing that out to pdx86/for-next yet ... Regards, Hans > --- > drivers/platform/x86/x86-android-tablets/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/x86-android-tablets/Kconfig b/drivers/platform/x86/x86-android-tablets/Kconfig > index 2b3daca5380b..c31e4df34f80 100644 > --- a/drivers/platform/x86/x86-android-tablets/Kconfig > +++ b/drivers/platform/x86/x86-android-tablets/Kconfig > @@ -6,6 +6,7 @@ > config X86_ANDROID_TABLETS > tristate "X86 Android tablet support" > depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB > + depends on PMIC_OPREGION > help > X86 tablets which ship with Android as (part of) the factory image > typically have various problems with their DSDTs. The factory kernels
diff --git a/drivers/platform/x86/x86-android-tablets/Kconfig b/drivers/platform/x86/x86-android-tablets/Kconfig index 2b3daca5380b..c31e4df34f80 100644 --- a/drivers/platform/x86/x86-android-tablets/Kconfig +++ b/drivers/platform/x86/x86-android-tablets/Kconfig @@ -6,6 +6,7 @@ config X86_ANDROID_TABLETS tristate "X86 Android tablet support" depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB + depends on PMIC_OPREGION help X86 tablets which ship with Android as (part of) the factory image typically have various problems with their DSDTs. The factory kernels