Message ID | 20221025135323.98303-1-juzhe.zhong@rivai.ai |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1019779wru; Tue, 25 Oct 2022 06:54:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5i7wSn+8B91HC9ZuRAwZNAdjcaP0sxQ+QxFkGO+gsTTgHAHXXNC1eDllCwAENp/ktxHufB X-Received: by 2002:a17:907:2c67:b0:78d:49d2:6297 with SMTP id ib7-20020a1709072c6700b0078d49d26297mr33759918ejc.21.1666706048836; Tue, 25 Oct 2022 06:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666706048; cv=none; d=google.com; s=arc-20160816; b=fOBYtCspPS05arWCHGI7FVzAc1R54EFmx+FJq61oo/Bzxz7wc/oidf3pP6Jtt/tFsR JjFNiQjv28pB+25074c+m36wNeEujI4TUOc8hQ4e+houwTVTQyFhRAWS8sVRbG1jKEIA 2yEqEQttGHo5xMrmJ/aifAoneVRqB3+ZlQ0YBPDqRTqYHjwilhruFf4NvPNPc4wC30Ue 2X1As7E70V+iTBWENDTYOckyJL0NO9UVlQycQNQtf4QnQyAFPzAjDk5pwp2+eW3u6X12 Mhce7QFJr8pU2714eifk4NGsCqDWzR8Oi7BYIa7gOGUw0RW2/5VN8ql683E6etynkVH5 7xEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:to :from:dmarc-filter:delivered-to; bh=2fsWCYQzKbxwjOmCaxL73xMr/cnUSXCyoEIG5kkXBOM=; b=0uQk8H+6yi18f/65V6X1LXn6McdG51AyhEcX4Mky+csLVQxTqt+RlgRP/9hioqhrEm TMbwl/bh3UIr1vpAUyPF8+QCnsudVQBiZ/j1VBQv0d+WShGso6Ll+BqgQ8zdggOnDl5D GZK+W2AEucNpKPMAUBOhspO40QOirusXlOX4h02TB7mI2PdB31akuO6/cwCmyRxxoeFw fwr1lqnG4N+b3ahtd1Ucc8D8yV2T233LIGeOb5V0R02z9px8SpQt1wsxHXecgvp8NLvP p6MSorVXcNCwdGG3t5WxVsS9KcDz5GFuwkhpdPQEzzqO7EHWsGhoFi494dNdtPYiNh6Z fE7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id dr21-20020a170907721500b0078db794016csi2905250ejc.907.2022.10.25.06.54.08 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 06:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3B2ED3856DE5 for <ouuuleilei@gmail.com>; Tue, 25 Oct 2022 13:54:02 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbgsg1.qq.com (smtpbgsg1.qq.com [54.254.200.92]) by sourceware.org (Postfix) with ESMTPS id 78A10385AC22 for <gcc-patches@gcc.gnu.org>; Tue, 25 Oct 2022 13:53:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 78A10385AC22 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp81t1666706007trqcfflj Received: from rios-cad5.localdomain ( [42.247.22.66]) by bizesmtp.qq.com (ESMTP) with id ; Tue, 25 Oct 2022 21:53:25 +0800 (CST) X-QQ-SSF: 01400000002000D0K000B00A0000000 X-QQ-FEAT: eYFcRngxZtQP4mKnzX2Y4wwbwPWwGbuqKlkgcaYAoJ2BIR+Qktn4QjnVOaU9m VLtoo3l0DskNc86dTHKPmltXj6zEh7kHNoHtSTg/D912I3zoeJoXQwUTtKl3x7m1waaVN+m vxC2OznfdgMLVfdp4rdkR8k9jSyif9TkvwX3/bHspYQbkhHLtj/kbG/N7Dkm3XxZ/XnHFAA AXWYElbbXXwH5lG+HA89Lg0XFQ8XQgF0PR/9nW3kxwjbZfa0MiHibxVGdAsrjDbzR3VV7dz 9UMRZMvZpeHBkHJfnbqcmOXWji8clWhb8kuKIrC+4uWVMU7M1layjBDIcAX8Awbh6kHfQJA X3vbQZJwktB0H/OOp2bwVqbsWIheU7EpU1SlFFytAq6mIfbddQje7EuI0w8xIESnARC+xc8 53qUsscb9d0= X-QQ-GoodBg: 2 From: juzhe.zhong@rivai.ai To: gcc-patches@gcc.gnu.org Subject: [PATCH] RISC-V: Fix a mistake in previous patch. Date: Tue, 25 Oct 2022 21:53:23 +0800 Message-Id: <20221025135323.98303-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvr:qybglogicsvr7 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Cc: kito.cheng@gmail.com, Ju-Zhe Zhong <juzhe.zhong@rivai.ai> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747667961804032285?= X-GMAIL-MSGID: =?utf-8?q?1747667961804032285?= |
Series |
RISC-V: Fix a mistake in previous patch.
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
juzhe.zhong@rivai.ai
Oct. 25, 2022, 1:53 p.m. UTC
From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
I noticed that I have made a mistake in previous patch:
https://patchwork.sourceware.org/project/gcc/patch/20220817071950.271762-1-juzhe.zhong@rivai.ai/
The previous statement before this patch:
bool need_barrier_p = (get_frame_size () + cfun->machine->frame.arg_pointer_offset) != 0;
However, I changed it in the previous patch:
bool need_barrier_p = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset);
This is incorrect.
Now, I correct this statement in this patch.
gcc/ChangeLog:
* config/riscv/riscv.cc (riscv_expand_epilogue): Fix statement.
---
gcc/config/riscv/riscv.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Committed with title tweak, thanks On Tue, Oct 25, 2022 at 9:53 PM <juzhe.zhong@rivai.ai> wrote: > > From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai> > > I noticed that I have made a mistake in previous patch: > https://patchwork.sourceware.org/project/gcc/patch/20220817071950.271762-1-juzhe.zhong@rivai.ai/ > > The previous statement before this patch: > bool need_barrier_p = (get_frame_size () + cfun->machine->frame.arg_pointer_offset) != 0; > > However, I changed it in the previous patch: > bool need_barrier_p = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset); > This is incorrect. > > Now, I correct this statement in this patch. > > gcc/ChangeLog: > > * config/riscv/riscv.cc (riscv_expand_epilogue): Fix statement. > > --- > gcc/config/riscv/riscv.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc > index 08354a19c05..50ef38438a2 100644 > --- a/gcc/config/riscv/riscv.cc > +++ b/gcc/config/riscv/riscv.cc > @@ -5028,8 +5028,8 @@ riscv_expand_epilogue (int style) > rtx insn; > > /* We need to add memory barrier to prevent read from deallocated stack. */ > - bool need_barrier_p > - = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset); > + bool need_barrier_p = known_ne (get_frame_size () > + + cfun->machine->frame.arg_pointer_offset, 0); > > if (cfun->machine->naked_p) > { > -- > 2.36.1 >
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 08354a19c05..50ef38438a2 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -5028,8 +5028,8 @@ riscv_expand_epilogue (int style) rtx insn; /* We need to add memory barrier to prevent read from deallocated stack. */ - bool need_barrier_p - = known_ne (get_frame_size (), cfun->machine->frame.arg_pointer_offset); + bool need_barrier_p = known_ne (get_frame_size () + + cfun->machine->frame.arg_pointer_offset, 0); if (cfun->machine->naked_p) {