Message ID | 20230309135255.3861308-1-geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp324884wrd; Thu, 9 Mar 2023 06:38:01 -0800 (PST) X-Google-Smtp-Source: AK7set+ii0aEy9v/IOLVkzxWSO3m+kIdot6MPy64ICqItG63NqGgIHluURDnqIrHvGxElb5H80o6 X-Received: by 2002:a17:90b:3ecc:b0:23a:8d71:99d with SMTP id rm12-20020a17090b3ecc00b0023a8d71099dmr18812745pjb.22.1678372680774; Thu, 09 Mar 2023 06:38:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1678372680; cv=none; d=google.com; s=arc-20160816; b=0+x/RdMQTMBVM0ZFXZ4kHy/hblWGou1vZ6Nab6BADrSZyWpLoUXOUvrxfCACyvlwEa 9Va92HWH3KBH/ETjE6tEQt7LwQfnv5hZ0VILIEk0n4ZsZjoc6RdHBjQ3HABOFjSXBKFm faOUPI4wgdwVKeDSvv7KDI87KbWuyNTvg8oXWWNZo/5M7FOKIqCgEbvaqbxns0/NWJrq mu0pc5i0fPMILyntYS89H1oUOl4w0IN+Nn48ZYMDJlnXrVtJxK+js679vGFTKsa0lvtA 8w1o2ps7oyvXHSdP95EUF7S8ybEVhPsBrR0gCXYak/50rYCelzoMunbSz1QKZtdVkWlT muOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=czGKdmS3LUwYnuDnW+ZnNh5jcboy9b/0ZAG274JbvaM=; b=G8ZGXrHFb+CXlqBAl9sSvKonoiq/t4YQ3brSNTsHVdVXQsE1HT93sLd0wQLQ//Bjys Nck67vly7mFAbQ5b+edpQxT65RJ52vSbPPGwl/3GZXs5ZObhyuSyE3iag8oZIYYsRtf3 7g+hAWowzlBhKOSDkgpCfSnIoVgfms1lNg7zYHmJqu0/YYS9nLERSxCIyji/fbC+hRgR ZgkY8Uga6CVvd+DkTkRGo8pbHQ9siFf2d8HPTl8uhj4Mn73sHkclEmOKyhoMv1J/LNa7 2J11NfCHcDQ3qMY9IUiIAIkHC5pbpXjLKMXteTCMAci59gkiTIbn0C7lkB1bSFpgmSQj /qyg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s14-20020a17090a764e00b002375a3ccf51si49852pjl.9.2023.03.09.06.37.48; Thu, 09 Mar 2023 06:38:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231452AbjCINxd (ORCPT <rfc822;carlos.wei.hk@gmail.com> + 99 others); Thu, 9 Mar 2023 08:53:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231370AbjCINxD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 9 Mar 2023 08:53:03 -0500 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A9E23DBE for <linux-kernel@vger.kernel.org>; Thu, 9 Mar 2023 05:53:00 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed50:3a77:63e:b168:ae06]) by baptiste.telenet-ops.be with bizsmtp id WDsw2900754Hw2A01DswFl; Thu, 09 Mar 2023 14:52:56 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1paGgv-00BKoW-Iy; Thu, 09 Mar 2023 14:52:56 +0100 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1paGhU-00GCVN-3q; Thu, 09 Mar 2023 14:52:56 +0100 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>, linux-gpio@vger.kernel.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be>, Linux Kernel Functional Testing <lkft@linaro.org> Subject: [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h> Date: Thu, 9 Mar 2023 14:52:55 +0100 Message-Id: <20230309135255.3861308-1-geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, TVD_SPACE_RATIO autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759898985408024534?= X-GMAIL-MSGID: =?utf-8?q?1759901312302217883?= |
Series |
sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>
|
|
Commit Message
Geert Uytterhoeven
March 9, 2023, 1:52 p.m. UTC
shx3_defconfig:
arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’:
arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’
246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i;
| ^
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com
Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/sh/boards/mach-x3proto/setup.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Thu, Mar 09, 2023 at 02:52:55PM +0100, Geert Uytterhoeven wrote: > shx3_defconfig: > > arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’: > arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’ > 246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i; > | ^ > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Thank you! ... > #include <linux/gpio.h> > +#include <linux/gpio/driver.h> Do we still need the legacy header?
Hi Andy, On Thu, Mar 9, 2023 at 3:10 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Thu, Mar 09, 2023 at 02:52:55PM +0100, Geert Uytterhoeven wrote: > > shx3_defconfig: > > > > arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’: > > arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’ > > 246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i; > > | ^ > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com > > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Thank you! > > ... > > > #include <linux/gpio.h> > > +#include <linux/gpio/driver.h> > > Do we still need the legacy header? Apparently not. And "make arch/sh/boards/mach-x3proto/setup.i" confirms it's not included indirectly. Will send a v2... Gr{oetje,eeting}s, Geert
On Thu, Mar 09, 2023 at 03:08:47PM +0100, Linus Walleij wrote: > On Thu, Mar 9, 2023 at 2:52 PM Geert Uytterhoeven > <geert+renesas@glider.be> wrote: > > > shx3_defconfig: > > > > arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’: > > arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’ > > 246 | baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i; > > | ^ > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com > > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > This is fallout from cleanups in Bartosz GPIO tree, so it will be applied there. > Make sure Bartosz gets the patch (now on To:) > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Thanks, as for previous patch on the same topic, I am collecting this one. I will sent a new PR to Bart including all fixes, but I would wait one or a couple of weeks before doing that. Meanwhile these will be in Linux Next.
diff --git a/arch/sh/boards/mach-x3proto/setup.c b/arch/sh/boards/mach-x3proto/setup.c index 95b85f2e13dda75b..7f39fca95e57a109 100644 --- a/arch/sh/boards/mach-x3proto/setup.c +++ b/arch/sh/boards/mach-x3proto/setup.c @@ -17,6 +17,7 @@ #include <linux/usb/r8a66597.h> #include <linux/usb/m66592.h> #include <linux/gpio.h> +#include <linux/gpio/driver.h> #include <linux/gpio_keys.h> #include <mach/ilsel.h> #include <mach/hardware.h>