| Message ID | 1677664555-30191-2-git-send-email-quic_mojha@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp3554493wrd;
Wed, 1 Mar 2023 02:34:54 -0800 (PST)
X-Google-Smtp-Source:
AK7set9G3S7tVzUnTBx5lbmaPajpk5hKljDJZQ2B2W0J845Qg7qbln6A0HfbunuCFeuPbgWWd1RR
X-Received: by 2002:a17:906:468d:b0:8b1:1f2d:ecf1 with SMTP id
a13-20020a170906468d00b008b11f2decf1mr7041608ejr.67.1677666893813;
Wed, 01 Mar 2023 02:34:53 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677666893; cv=none;
d=google.com; s=arc-20160816;
b=Qph0zD+ccxzFTSoXCh27ln4zfxpygblqrDR8tPN5WUObnluWCORTOjDTmW/i/kDoaj
wJPUPOQ1/WvhcBGz3oYb3GlVFYDz0574mfyoRdcGLEsVGMNrbAj/bJm2csV5aHWx6D1K
1yEZvxkum7Xe2nJOUW1iv2OVYQ6f3YvcxL4KqxjD1Xu7dlFBEELBokPeOgO7bRRG3uCc
kx4QtvHUGbomxBIXF6NQAaUg7zU1NiIiEB+nD1xEFilOMAV5H/u+7MJIXXbLFVhWV7p/
eKdtJqATG67SyBrun0L3+zjJ3L9yKIQODP4ewNenx0HakHHBazhqO6bk4FsILSdUJtDI
GG5A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=NB0Aduk84/3OmNQrNgR+C215mUZdU6JD2zPgP4V56jM=;
b=YD10j1x3R5khCS2BqFF56fnE3+M8B+3NwgGtWpdRWTQ7i1CuOQtST2G0T+O/Ej+eMa
2S/96nVS3vVhW/lt2kyVffhm6Ww/FIkFlhfR5aiRhGWB0mVHttBTSLucz0gzhyughGXd
XbsKeKh+t1wQl3SBW09gcUqoq+sgBASHp0xMzXUQ0xQzv+uPs0/nSgYl9plMMgjj8+le
FND0rtyTCn/xO6A/1VZsjNa1HvEIIHvFb3EqR5dx9hj5SCO9k2aJ9WSxAIxpXhIDIgGJ
S3TdA9gdClWnQFPEfgQ+4AcQ9oGdA5r/0qFB499N8aA+/SWVBquoxocEVKQYhAR4fryJ
nq5Q==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=fYJzNcou;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
a9-20020a17090680c900b008d6b51de6bdsi13701210ejx.616.2023.03.01.02.34.31;
Wed, 01 Mar 2023 02:34:53 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=fYJzNcou;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229510AbjCAKbq (ORCPT <rfc822;dipsyhu@gmail.com> + 99 others);
Wed, 1 Mar 2023 05:31:46 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49490 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229793AbjCAKbk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 1 Mar 2023 05:31:40 -0500
Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com
[205.220.180.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ABAA3BD84;
Wed, 1 Mar 2023 02:31:33 -0800 (PST)
Received: from pps.filterd (m0279870.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
3212nIJV023915;
Wed, 1 Mar 2023 09:57:00 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-type; s=qcppdkim1;
bh=NB0Aduk84/3OmNQrNgR+C215mUZdU6JD2zPgP4V56jM=;
b=fYJzNcou9ZKtwIMSyuSM2FEVyawmwz4rXPoj3zfIPi31h+/NK1qDfGCjhcQJ/umSRige
7b+0kdPHBHVXxmGf/mrK8SyJ7e1vDKZXm4sg88F+AP1U6ihKCD//zoHYHI2Yhezj41wH
FR8cIxmD0q6h2ORfpjR5lZQC3aRMfKQEswdmvz7hwjcef8C5tOYo0442QIkckzyPfyvp
8ufz++J5jmSfg9G6AYUipSUcYPqqgfJYoAjmJOgxxBqVIX4WkifxMAlkA/7f3UDkLwAW
CwnrH8BfZWQQTFMkLxDAzm+54gmcf0r4qnnA1qX0zcSP0T1ggyv6D0fQAu0eebJ5pZUb bg==
Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com
[199.106.103.254])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p1n0tjjxd-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 01 Mar 2023 09:57:00 +0000
Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com
[10.45.79.139])
by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
3219uxBV007188
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 1 Mar 2023 09:56:59 GMT
Received: from hu-mojha-hyd.qualcomm.com (10.80.80.8) by
nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.986.41; Wed, 1 Mar 2023 01:56:56 -0800
From: Mukesh Ojha <quic_mojha@quicinc.com>
To: <agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>
CC: <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Mukesh Ojha" <quic_mojha@quicinc.com>
Subject: [PATCH v2 1/4] firmware: qcom_scm: Clear download bit during reboot
Date: Wed, 1 Mar 2023 15:25:52 +0530
Message-ID: <1677664555-30191-2-git-send-email-quic_mojha@quicinc.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1677664555-30191-1-git-send-email-quic_mojha@quicinc.com>
References: <1677664555-30191-1-git-send-email-quic_mojha@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.80.80.8]
X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To
nasanex01c.na.qualcomm.com (10.45.79.139)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-ORIG-GUID: IZs5N6I4OA1XxAP578gFv9GRGzT02Cs3
X-Proofpoint-GUID: IZs5N6I4OA1XxAP578gFv9GRGzT02Cs3
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22
definitions=2023-03-01_04,2023-02-28_03,2023-02-09_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
clxscore=1015 phishscore=0
malwarescore=0 adultscore=0 priorityscore=1501 bulkscore=0 suspectscore=0
spamscore=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 mlxlogscore=999
classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
definitions=main-2303010082
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1759161240465335802?=
X-GMAIL-MSGID: =?utf-8?q?1759161240465335802?=
|
| Series |
Refactor to support multiple download mode
|
|
Commit Message
Mukesh Ojha
March 1, 2023, 9:55 a.m. UTC
During normal restart of a system download bit should
be cleared irrespective of whether download mode is
set or not.
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Changes in v2:
- No change
drivers/firmware/qcom_scm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On 01/03/2023 09:55, Mukesh Ojha wrote: > During normal restart of a system download bit should > be cleared irrespective of whether download mode is > set or not. Looks like this is a fix, Fixes tag would help here. --srini > > Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com> > --- > Changes in v2: > - No change > > drivers/firmware/qcom_scm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c > index cdbfe54..51eb853 100644 > --- a/drivers/firmware/qcom_scm.c > +++ b/drivers/firmware/qcom_scm.c > @@ -1418,8 +1418,7 @@ static int qcom_scm_probe(struct platform_device *pdev) > static void qcom_scm_shutdown(struct platform_device *pdev) > { > /* Clean shutdown, disable download mode to allow normal restart */ > - if (download_mode) > - qcom_scm_set_download_mode(false); > + qcom_scm_set_download_mode(false); > } > > static const struct of_device_id qcom_scm_dt_match[] = {
diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index cdbfe54..51eb853 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -1418,8 +1418,7 @@ static int qcom_scm_probe(struct platform_device *pdev) static void qcom_scm_shutdown(struct platform_device *pdev) { /* Clean shutdown, disable download mode to allow normal restart */ - if (download_mode) - qcom_scm_set_download_mode(false); + qcom_scm_set_download_mode(false); } static const struct of_device_id qcom_scm_dt_match[] = {