diff mbox series

[2/6] dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365

Message ID 20230207-iommu-support-v1-2-4f0c81fd52c1@baylibre.com
State New
Headers
Series Add IOMMU support to MT8365 SoC |

Commit Message

Alexandre Mergnat March 7, 2023, 1:46 p.m. UTC 
  Add binding description for mediatek,mt8365-smi-larb

Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
 .../devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml     | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Krzysztof Kozlowski March 8, 2023, 10:30 a.m. UTC | #1 
On 07/03/2023 14:46, Alexandre Mergnat wrote:
> Add binding description for mediatek,mt8365-smi-larb
> 
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
> ---
>  .../devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml     | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> index 5f4ac3609887..aee7f6cf1300 100644
> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
> @@ -34,6 +34,10 @@ properties:
>            - const: mediatek,mt7623-smi-larb
>            - const: mediatek,mt2701-smi-larb
>  
> +      - items:
> +          - const: mediatek,mt8365-smi-larb
> +          - const: mediatek,mt8186-smi-larb

You need to fix the allOf:if. It expects single item, so you need to add
contains like for mt2701.

Best regards,
Krzysztof
Krzysztof Kozlowski March 8, 2023, 10:31 a.m. UTC | #2 
On 08/03/2023 11:30, Krzysztof Kozlowski wrote:
> On 07/03/2023 14:46, Alexandre Mergnat wrote:
>> Add binding description for mediatek,mt8365-smi-larb
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
>> ---
>>  .../devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml     | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> index 5f4ac3609887..aee7f6cf1300 100644
>> --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
>> @@ -34,6 +34,10 @@ properties:
>>            - const: mediatek,mt7623-smi-larb
>>            - const: mediatek,mt2701-smi-larb
>>  
>> +      - items:
>> +          - const: mediatek,mt8365-smi-larb
>> +          - const: mediatek,mt8186-smi-larb
> 
> You need to fix the allOf:if. It expects single item, so you need to add
> contains like for mt2701.

Wait, this was about common. LARB looks ok, but double check.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
index 5f4ac3609887..aee7f6cf1300 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
@@ -34,6 +34,10 @@  properties:
           - const: mediatek,mt7623-smi-larb
           - const: mediatek,mt2701-smi-larb
 
+      - items:
+          - const: mediatek,mt8365-smi-larb
+          - const: mediatek,mt8186-smi-larb
+
   reg:
     maxItems: 1