| Message ID | 20230308011705.291337-1-konrad.dybcio@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp79398wrd;
Tue, 7 Mar 2023 18:00:16 -0800 (PST)
X-Google-Smtp-Source:
AK7set/SBGrU6LLgBEpZ+vRojsXng1kPOzh4FAxY26sVvHub7TXXWiHlhMr94TgWqf39ukWr0r32
X-Received: by 2002:a17:907:c297:b0:8f6:88b7:73a7 with SMTP id
tk23-20020a170907c29700b008f688b773a7mr14518340ejc.7.1678240815893;
Tue, 07 Mar 2023 18:00:15 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1678240815; cv=none;
d=google.com; s=arc-20160816;
b=CA9596uN/CWPuduxs2oPaGTeg2woZPTYzdSU1mVgwODoWkTvSp5Fb4KGTUqwU7Wu2x
jyiZxUlZSTLT+skUjJGLNFysv65ZxqIEgoULoptxsejnC+zKMkp6ZBsAw4j0TYtl+VZY
H3Lydq0TvYFrPxX+QpuOW/sqeS+E5XzepP+9BgpGMaRosyl01rPGdWB6z17VW/lbYkMe
a51k3dPP6X2s0L0a7eaAxySbbXevkbUdqhNQUpxz4JqxWsPYBSTG/C56wQnY+SS40vxW
aUjasWp+v33zsV3jrmPajA2o8QpCJ78ktlqBgICpwdA+zZydn3B9HGwlQJ8YjecyPHXl
GDTg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=gnNZH9Drw/MoaoUZbOvjj8rfTjtiFcEzRwtiu8frN6A=;
b=P7ZfPWFaGjkDv6KmPMIPa7zgAYadXsaPl6Z43yY/tI9XMrjtCnUn/hr1+EIPxKd2mC
AqjHy9SXE87HsoYILP5LplaZrTdq2diWCjlJNt0EHKH2y5Ip0DWec9bmdosKfXLek6Vp
ufWh2h4GDm55IbEeSzWlv9aIiUxYu6vsmGwncHxkXfm+/KNAI1kgQgQyq2/lCNc29iYq
eRyHprBxBvPy4iJZfWXSFw3CsnMLa/z+8YcsbnNik+gyuPH+fvBVUA/kgl6oUSkN23Lr
i1M0Hbs0F8yfku9E0D25EPrGifjv0kRlfBqycGTrK5bseIVylKt4ENqZQXuSC/kaswMP
DFwA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=RQ07lhei;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
bs25-20020a170906d1d900b008e1cbdcd3c6si2784789ejb.462.2023.03.07.17.59.52;
Tue, 07 Mar 2023 18:00:15 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=RQ07lhei;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230012AbjCHBR0 (ORCPT <rfc822;toshivichauhan@gmail.com>
+ 99 others); Tue, 7 Mar 2023 20:17:26 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55448 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229718AbjCHBRY (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 7 Mar 2023 20:17:24 -0500
Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com
[IPv6:2a00:1450:4864:20::12b])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 397EEA6758
for <linux-kernel@vger.kernel.org>;
Tue, 7 Mar 2023 17:17:23 -0800 (PST)
Received: by mail-lf1-x12b.google.com with SMTP id f18so19485815lfa.3
for <linux-kernel@vger.kernel.org>;
Tue, 07 Mar 2023 17:17:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1678238241;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=gnNZH9Drw/MoaoUZbOvjj8rfTjtiFcEzRwtiu8frN6A=;
b=RQ07lhei6sASNDadIFt8TAzr9uPXoWua6pYttLSe2YpNRAynfMfJSciJUmyQFGmvRN
fi5D9OtC4b59JEVUPiXBwhXuUCSJw3X6R/wpSN4b5Id7/Ywjwdh2/YiwW2vBCRLGOsOl
GZMlyQ1dq7AEJ5pnjRXptijJtNzMEG+N0mLGdD8x945i3uTC0ontT3Mq+xd8FEfsdJ9g
l+jIjT3BAPCXAWAypfIsB0iNVabZ9E2JWfStnK4/yp5MMUHpCO9mQjBmMJzcHR0jOuUV
CHgKGDrxHisMvFmDefWiIA2uxuEfmJqo+y5zJVRcyRiGvXgQWVpVHkkXIbleq9gh151d
D1+g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112; t=1678238241;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=gnNZH9Drw/MoaoUZbOvjj8rfTjtiFcEzRwtiu8frN6A=;
b=rqC5oTQyulHUEclK9Z4z5OFKjiGMghKH1emuLTq8x6ZC8Pzlz23wtzt5nXSpcTtYMs
xmiuBCyBVL9VdSFu76Tu310EBOYoRIW8q2azqu2/8v2z0Uc7QofNwbETav+tYBoz/CaU
GVxrOgDhYWBjgYNk7Fbv3WNX1T9TDeso5FaWrpgZ5kuNqb6JFyIEmC7mQNEPvCnxhsR6
g8IL9LGmEG6V4am1OuELeCEIyT8FB1ZpcEhNRFGnNmpBBIMr3NW8WdfE/5VNcnQca8Fz
g8PI14S3B3ldZuvC+k/TRk1ooj2wF+4oe1CebemtNMFnIKTGKUaNRsF7OtGrcYNnJVts
eyBA==
X-Gm-Message-State: AO0yUKVsnhOAZwY1UshTnz/Y3u9/10u9hfrrx8TgeRY/+RsR5UYZ5xbv
PyfTKxO63W0YrjqW9gsKXBEv9Zxgv8ToU69NygQ=
X-Received: by 2002:a19:c208:0:b0:4bc:af5:b8d9 with SMTP id
l8-20020a19c208000000b004bc0af5b8d9mr4291879lfc.6.1678238241433;
Tue, 07 Mar 2023 17:17:21 -0800 (PST)
Received: from localhost.localdomain (abyj16.neoplus.adsl.tpnet.pl.
[83.9.29.16])
by smtp.gmail.com with ESMTPSA id
u3-20020ac243c3000000b004dc4cb4f9c4sm2183207lfl.35.2023.03.07.17.17.19
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 07 Mar 2023 17:17:20 -0800 (PST)
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org
Cc: marijn.suijten@somainline.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawn.guo@linaro.org>, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH] dt-bindings: interrupt-controller: Allow #power-domain-cells
Date: Wed, 8 Mar 2023 02:17:05 +0100
Message-Id: <20230308011705.291337-1-konrad.dybcio@linaro.org>
X-Mailer: git-send-email 2.39.2
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
RCVD_IN_SORBS_HTTP,RCVD_IN_SORBS_SOCKS,SPF_HELO_NONE,SPF_PASS,
URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1759763041493340713?=
X-GMAIL-MSGID: =?utf-8?q?1759763041493340713?=
|
| Series |
dt-bindings: interrupt-controller: Allow #power-domain-cells
|
|
Commit Message
Konrad Dybcio
March 8, 2023, 1:17 a.m. UTC
MPM provides a single genpd. Allow #power-domain-cells = <0>.
Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support")
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
.../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 3 +++
1 file changed, 3 insertions(+)
Comments
On Wed, Mar 8, 2023 at 9:17 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > MPM provides a single genpd. Allow #power-domain-cells = <0>. Indeed! It was missing from the initial submission. Thanks for fixing it up! > > Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > index 509d20c091af..4c470dc143e5 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml > @@ -62,6 +62,9 @@ properties: > - description: MPM pin number > - description: GIC SPI number for the MPM pin > > + '#power-domain-cells': Should we add it to the "required" list and examples? Shawn > + const: 0 > + > required: > - compatible > - reg > -- > 2.39.2 >
On 8.03.2023 08:24, Shawn Guo wrote: > On Wed, Mar 8, 2023 at 9:17 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: >> >> MPM provides a single genpd. Allow #power-domain-cells = <0>. > > Indeed! It was missing from the initial submission. Thanks for fixing it up! > >> >> Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> index 509d20c091af..4c470dc143e5 100644 >> --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml >> @@ -62,6 +62,9 @@ properties: >> - description: MPM pin number >> - description: GIC SPI number for the MPM pin >> >> + '#power-domain-cells': > > Should we add it to the "required" list and examples? I was debating it.. it's definitely not *required*, as the irqchip part works even without it and then on SoCs with MPM but without PSCI the setup may be tricky.. About the example, both yes/no are okay for me Konrad > > Shawn > >> + const: 0 >> + >> required: >> - compatible >> - reg >> -- >> 2.39.2 >>
On Wed, Mar 8, 2023 at 9:17 AM Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > MPM provides a single genpd. Allow #power-domain-cells = <0>. > > Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Acked-by: Shawn Guo <shawn.guo@linaro.org>
On 08/03/2023 02:17, Konrad Dybcio wrote: > MPM provides a single genpd. Allow #power-domain-cells = <0>. > > Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 3 +++ Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 08/03/2023 02:17, Konrad Dybcio wrote: > MPM provides a single genpd. Allow #power-domain-cells = <0>. > > Fixes: 54fc9851c0e0 ("dt-bindings: interrupt-controller: Add Qualcomm MPM support") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > .../devicetree/bindings/interrupt-controller/qcom,mpm.yaml | 3 +++ > 1 file changed, 3 insertions(+) > BTW, this can be also added to the example. Always useful to validate it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml index 509d20c091af..4c470dc143e5 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,mpm.yaml @@ -62,6 +62,9 @@ properties: - description: MPM pin number - description: GIC SPI number for the MPM pin + '#power-domain-cells': + const: 0 + required: - compatible - reg