Message ID | 20230228043423.19335-1-xry111@xry111.site |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2816042wrd; Mon, 27 Feb 2023 21:00:39 -0800 (PST) X-Google-Smtp-Source: AK7set/sPxbwNvVLIrVRPo15nMzlGSlzZC6RuHwTnlG5d5wBvraoimoxnpZwUe8hTH1dA2GteS3L X-Received: by 2002:a17:907:2057:b0:8b1:319c:c29e with SMTP id pg23-20020a170907205700b008b1319cc29emr1406624ejb.74.1677560439046; Mon, 27 Feb 2023 21:00:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677560439; cv=none; d=google.com; s=arc-20160816; b=lfcRyZNbP3+RtSUJ3/4OvbmFqYJgCuG95VhaRRs2bYulWQAxKp8/JOtmhNbfSzixDN 10V1f4fSFFT3kgm14sncjhYqjDWxND7k+T9TiZPL0Asw103E4onM84Cz+mArMeu06BN0 cGC8b+H7RM5gIHeRL3cpAiENzfmBfHY6mjHlqJG9GTL0GGYTnnbOJSlt5ZQoB01dSJKw lVGsH+SiH67CHY+3DFew8M4qP5HSdnPhr6eQUYj9BCIrwQ/fG/Q/y4R401CuXCknNvjF I3N42xFMXzz2z//gY2+vUgVK3ZKkpCw+hG1HeTXTmRdXRVOOWy0OSKPJ82388TRt0HLg nOEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lRr4cHmYWIEPTmAZ8MWp0+9sK5xK6bLHqqU4H01KSKk=; b=T3rLvpi3RgjFHpjiPX/7xLn0rDxnEhGsmqtmu+UbeAz2UUa7RH89ccbsJ2pzMF0Vw6 uFR/VSYnqX9IchUNI+gALA+m/tOA5gMLQdH5sMC0eQpV5vUdKMZUnSaxPlnyZkLpGyAE Vq7I5Ssurqyytq81LbKaakwdyDZBKksvcVs4l8Q+5nwMlfUaLj1VAIZCueRhMEwfn7VQ p66FGruc+gbe6IXU1njRefyteGqLtPorr/4OqkXnc3z+4iAePUAYP84z7x6FzTIDtacQ ZGk6OBbusRaf+sonI0uMd7UWzQFzI+SD+yvOebRWHoFpIlWb8IEka5GWxw6Rzmit9TyO mT1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=mMPjLB2J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a1709060a0e00b008b540d6ba52si10334690ejf.227.2023.02.27.21.00.16; Mon, 27 Feb 2023 21:00:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@xry111.site header.s=default header.b=mMPjLB2J; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=xry111.site Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229870AbjB1ErD (ORCPT <rfc822;brysonjbanks@gmail.com> + 99 others); Mon, 27 Feb 2023 23:47:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229511AbjB1ErC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 27 Feb 2023 23:47:02 -0500 X-Greylist: delayed 578 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 27 Feb 2023 20:47:00 PST Received: from xry111.site (xry111.site [89.208.246.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA6761C311; Mon, 27 Feb 2023 20:47:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1677559041; bh=m0XcrIM1rbnBFNvtyeHvQ8Hb1eIxnxGXZLNlR7KHvwk=; h=From:To:Cc:Subject:Date:From; b=mMPjLB2JcXBVoOlRsJ7QRK6rPJJRbsS10Hxj6C7KGI5WW75q+0Dvt0+L0oeZNWtuB pAGZMmPMgNX6vdgDZfDOwRVYlDYn5PLWP6ecZ1UeRXkbpwNxMcQt+YGVDCChvguv4f mNr85f6SQyHrNLvDtjZ8w9G/A5NHpCmfAq4Zro6k= Received: from stargazer.. (unknown [IPv6:240e:358:1178:d600:dc73:854d:832e:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id CA0EA65B60; Mon, 27 Feb 2023 23:37:17 -0500 (EST) From: Xi Ruoyao <xry111@xry111.site> To: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kw@linux.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Xiaowei Song <songxiaowei@huawei.com>, Xi Ruoyao <xry111@xry111.site>, stable@vger.kernel.org Subject: [PATCH] PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN Date: Tue, 28 Feb 2023 12:34:24 +0800 Message-Id: <20230228043423.19335-1-xry111@xry111.site> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1759049614983567214?= X-GMAIL-MSGID: =?utf-8?q?1759049614983567214?= |
Series |
PCI: kirin: Select REGMAP_MMIO for PCIE_KIRIN
|
|
Commit Message
Xi Ruoyao
Feb. 28, 2023, 4:34 a.m. UTC
pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to select
REGMAP_MMIO or vmlinux fails to link with "undefined reference to
`__devm_regmap_init_mmio_clk`.
Cc: stable@vger.kernel.org # at least for 6.1 and 6.2
Signed-off-by: Xi Ruoyao <xry111@xry111.site>
---
drivers/pci/controller/dwc/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Gentle ping. On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote: > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to > select > REGMAP_MMIO or vmlinux fails to link with "undefined reference to > `__devm_regmap_init_mmio_clk`. > > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2 > Signed-off-by: Xi Ruoyao <xry111@xry111.site> > --- > drivers/pci/controller/dwc/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/Kconfig > b/drivers/pci/controller/dwc/Kconfig > index 434f6a4f4041..d29551261e80 100644 > --- a/drivers/pci/controller/dwc/Kconfig > +++ b/drivers/pci/controller/dwc/Kconfig > @@ -307,6 +307,7 @@ config PCIE_KIRIN > tristate "HiSilicon Kirin series SoCs PCIe controllers" > depends on PCI_MSI > select PCIE_DW_HOST > + select REGMAP_MMIO > help > Say Y here if you want PCIe controller support > on HiSilicon Kirin series SoCs.
On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote: > Gentle ping. > > On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote: > > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to > > select > > REGMAP_MMIO or vmlinux fails to link with "undefined reference to > > `__devm_regmap_init_mmio_clk`. > > > > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2 I merged this (with a rewritten commit log, Fixes tag and CC stable - please have a look and check how this has to be written for future submissions): https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org This patch is dropped. Thanks, Lorenzo > > Signed-off-by: Xi Ruoyao <xry111@xry111.site> > > --- > > drivers/pci/controller/dwc/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/Kconfig > > b/drivers/pci/controller/dwc/Kconfig > > index 434f6a4f4041..d29551261e80 100644 > > --- a/drivers/pci/controller/dwc/Kconfig > > +++ b/drivers/pci/controller/dwc/Kconfig > > @@ -307,6 +307,7 @@ config PCIE_KIRIN > > tristate "HiSilicon Kirin series SoCs PCIe controllers" > > depends on PCI_MSI > > select PCIE_DW_HOST > > + select REGMAP_MMIO > > help > > Say Y here if you want PCIe controller support > > on HiSilicon Kirin series SoCs. > > -- > Xi Ruoyao <xry111@xry111.site> > School of Aerospace Science and Technology, Xidian University
On Fri, 2023-03-10 at 11:45 +0100, Lorenzo Pieralisi wrote: > On Tue, Mar 07, 2023 at 01:42:01PM +0800, Xi Ruoyao wrote: > > Gentle ping. > > > > On Tue, 2023-02-28 at 12:34 +0800, Xi Ruoyao wrote: > > > pcie-kirin.c invokes devm_regmap_init_mmio, so it's necessary to > > > select > > > REGMAP_MMIO or vmlinux fails to link with "undefined reference to > > > `__devm_regmap_init_mmio_clk`. > > > > > > Cc: stable@vger.kernel.org # at least for 6.1 and 6.2 > > I merged this (with a rewritten commit log, Fixes tag and > CC stable - please have a look and check how this has to > be written for future submissions): > > https://lore.kernel.org/linux-pci/167844411812.1209684.12017386820985241641.b4-ty@kernel.org > > This patch is dropped. Oh, didn't noticed someone has already done this in 2022 :).
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig index 434f6a4f4041..d29551261e80 100644 --- a/drivers/pci/controller/dwc/Kconfig +++ b/drivers/pci/controller/dwc/Kconfig @@ -307,6 +307,7 @@ config PCIE_KIRIN tristate "HiSilicon Kirin series SoCs PCIe controllers" depends on PCI_MSI select PCIE_DW_HOST + select REGMAP_MMIO help Say Y here if you want PCIe controller support on HiSilicon Kirin series SoCs.