| Message ID | 20230224080045.6577-1-manivannan.sadhasivam@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp775773wrd;
Fri, 24 Feb 2023 00:26:14 -0800 (PST)
X-Google-Smtp-Source:
AK7set/ScrQreqyFvl2U/W4dhZPxncrgjrwVPK1bxyDSQgsZNtLXO5CsVosEykK7CBB2qI5gcoPg
X-Received: by 2002:a17:90b:4c87:b0:233:f447:1271 with SMTP id
my7-20020a17090b4c8700b00233f4471271mr18045663pjb.43.1677227173967;
Fri, 24 Feb 2023 00:26:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677227173; cv=none;
d=google.com; s=arc-20160816;
b=qrNL1R9xWY0nn+40/Vs5ruRkSCimLkbu9FIqH3+k+Z+OylOfaEHt7VHQwgxqjhzWdA
d8Z3VEpmAm3+2bE/3cH3rkKrDz4DA9coR46i0OGQ0OqLmF4a8VHuNRlb1+CNbesGXMIG
XF5giotiI3ijav/Vxl45XJj2NluBt6gsWt58V6bJLvs0MAQJlAX00ptwdPZknUGsoDwY
33HgZGbG8PQsbeiVt9YluiDqXR9ARGahwL+LsngtQ0LKnmOa09iJ3v4vO1wUniEpNCg7
nupRT0G41kc3N+9Kt9cH5AKUXjUhYeZGVbTNjIWiAVhlTeW/zP0M9Bx161pLwCpE1a4p
kd1A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=PcsnC67wn+CqlKF18BOklq3hhvo7C+mJm1DzOVZsLT8=;
b=iG4PjzRvaJlx9tthZU8vqui3tG/clRsyu0ZBKGpVCW6hWceU4o6Ka5EB7cx57heb9Z
sZzLt+jIO6UqtH0FTV42i5VBVzUEfazlGLRDg49j+dvpkTlKWje3OwrxsW+fo45F2AE2
cjmq9GMVejHSmmRS5sEx6pSHQcB/tGCumCvmCTH3JsVEgHC1Rr/71whPPyCx8DJQPA9Z
jR7MQlgaTBOS8gitOldfLwo3EgsX9dLOr//kMt6dRGevBov90e+0Astxkeratf6xHwlS
To83XiULezCrPbz6XLcE1yNZexLPfCYkEm9HQWf+thXO1VKIZH8UemZM/65bVMWFCbPj
OOzg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=cRnat+0C;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
v2-20020a17090ac90200b0022dae6bb6c8si1872516pjt.30.2023.02.24.00.26.01;
Fri, 24 Feb 2023 00:26:13 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=cRnat+0C;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229638AbjBXIBB (ORCPT <rfc822;jeff.pang.chn@gmail.com>
+ 99 others); Fri, 24 Feb 2023 03:01:01 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50762 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229626AbjBXIA7 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 24 Feb 2023 03:00:59 -0500
Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com
[IPv6:2607:f8b0:4864:20::1035])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 829B925BAA
for <linux-kernel@vger.kernel.org>;
Fri, 24 Feb 2023 00:00:57 -0800 (PST)
Received: by mail-pj1-x1035.google.com with SMTP id u10so15635927pjc.5
for <linux-kernel@vger.kernel.org>;
Fri, 24 Feb 2023 00:00:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=PcsnC67wn+CqlKF18BOklq3hhvo7C+mJm1DzOVZsLT8=;
b=cRnat+0Cs7+bku17Q0RWfYOyZoaY/AM3gR/A4qjMETzHJ8K/6cMg6sGIDgVGEUi2us
Siv6tVSk8OJ5+NMBcy4u69Wi+IRYTZb2yyEQ8cJnQqoajbwvM+r8ywhAxau9pRpMoh6z
OxNBb8aaTRh7b3QNsM/2CObzPZWXqGwDli3mx5Z+XP6TFOlawPctW5DeNRZSNWo3fZfw
/A0QLienw62/ybqG/1ipvDDFWQSzUISSJ47SFKk2HvEf//fPLO+YQKMZIg5CvhdKVQyw
GX5AhiDnxUK5seaggpfa44E6V7EvuGqu0myYlM0AI72dHew3HhKu5t27GC7z75uN4+TN
xRrw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=PcsnC67wn+CqlKF18BOklq3hhvo7C+mJm1DzOVZsLT8=;
b=lKfXh6LGAbz0aXA3dD8E0WolYLZQZE2gGNwnLGR/MgQKh0j4DLbrC7dzo7T4VgPKhU
Blky4QEW7iZA/UmAoJQ+cUAkd/CoGHbNq6VxMCK9oZefY1j0XYqlU/QWxqhsCbpSUyRq
/3SvGyma4FlaOIQhUm2j0050ULFLUunmmHo0A05om193qmzh3dlauihKN2GbjF5nWiOZ
gLUM5SOqEJNzXCR4Tucs/mjEfrUyoM5qaewxM41nMKXchLsM7k1nC/pLE5OgfbbjgANk
7PI8+Ec9dJdK/ZiObmktgqVL9SjWVygvqntJTFmQrZZIc5F4J4JsyjLU0v9JZ0xvLyZ/
HBxg==
X-Gm-Message-State: AO0yUKWCPY0qGmWJH9Fbfd2syPyhSJVZwpgKEbz4XLz01olIXN6sDgZ4
wPtx4WL8LRXBsMHgey/7SUK3
X-Received: by 2002:a17:90b:3144:b0:237:99b9:c415 with SMTP id
ip4-20020a17090b314400b0023799b9c415mr725021pjb.38.1677225656986;
Fri, 24 Feb 2023 00:00:56 -0800 (PST)
Received: from localhost.localdomain ([117.217.187.3])
by smtp.gmail.com with ESMTPSA id
l3-20020a17090ac58300b002372106a5casm914211pjt.44.2023.02.24.00.00.51
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 24 Feb 2023 00:00:56 -0800 (PST)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: andersson@kernel.org
Cc: konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
bhupesh.sharma@linaro.org, srinivas.kandagatla@linaro.org,
quic_vkamble@quicinc.com,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
stable@vger.kernel.org
Subject: [PATCH] arm64: dts: qcom: sm8150: Fix the iommu mask used for PCIe
controllers
Date: Fri, 24 Feb 2023 13:30:45 +0530
Message-Id: <20230224080045.6577-1-manivannan.sadhasivam@linaro.org>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1758699171738373528?=
X-GMAIL-MSGID: =?utf-8?q?1758700161311560741?=
|
| Series |
arm64: dts: qcom: sm8150: Fix the iommu mask used for PCIe controllers
|
|
Commit Message
Manivannan Sadhasivam
Feb. 24, 2023, 8 a.m. UTC
The iommu mask should be 0x3f as per Qualcomm internal documentation.
Without the correct mask, the PCIe transactions from the endpoint will
result in SMMU faults. Hence, fix it!
Cc: stable@vger.kernel.org # 5.19
Fixes: a1c86c680533 ("arm64: dts: qcom: sm8150: Add PCIe nodes")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 24.02.2023 09:00, Manivannan Sadhasivam wrote: > The iommu mask should be 0x3f as per Qualcomm internal documentation. > Without the correct mask, the PCIe transactions from the endpoint will > result in SMMU faults. Hence, fix it! > > Cc: stable@vger.kernel.org # 5.19 > Fixes: a1c86c680533 ("arm64: dts: qcom: sm8150: Add PCIe nodes") > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sm8150.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index fd20096cfc6e..13e0ce828606 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -1826,7 +1826,7 @@ pcie0: pci@1c00000 { > "slave_q2a", > "tbu"; > > - iommus = <&apps_smmu 0x1d80 0x7f>; > + iommus = <&apps_smmu 0x1d80 0x3f>; > iommu-map = <0x0 &apps_smmu 0x1d80 0x1>, > <0x100 &apps_smmu 0x1d81 0x1>; > > @@ -1925,7 +1925,7 @@ pcie1: pci@1c08000 { > assigned-clocks = <&gcc GCC_PCIE_1_AUX_CLK>; > assigned-clock-rates = <19200000>; > > - iommus = <&apps_smmu 0x1e00 0x7f>; > + iommus = <&apps_smmu 0x1e00 0x3f>; > iommu-map = <0x0 &apps_smmu 0x1e00 0x1>, > <0x100 &apps_smmu 0x1e01 0x1>; >
On Fri, 24 Feb 2023 13:30:45 +0530, Manivannan Sadhasivam wrote: > The iommu mask should be 0x3f as per Qualcomm internal documentation. > Without the correct mask, the PCIe transactions from the endpoint will > result in SMMU faults. Hence, fix it! > > Applied, thanks! [1/1] arm64: dts: qcom: sm8150: Fix the iommu mask used for PCIe controllers commit: 672a58fc7c477e59981653a11241566870fff852 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index fd20096cfc6e..13e0ce828606 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -1826,7 +1826,7 @@ pcie0: pci@1c00000 { "slave_q2a", "tbu"; - iommus = <&apps_smmu 0x1d80 0x7f>; + iommus = <&apps_smmu 0x1d80 0x3f>; iommu-map = <0x0 &apps_smmu 0x1d80 0x1>, <0x100 &apps_smmu 0x1d81 0x1>; @@ -1925,7 +1925,7 @@ pcie1: pci@1c08000 { assigned-clocks = <&gcc GCC_PCIE_1_AUX_CLK>; assigned-clock-rates = <19200000>; - iommus = <&apps_smmu 0x1e00 0x7f>; + iommus = <&apps_smmu 0x1e00 0x3f>; iommu-map = <0x0 &apps_smmu 0x1e00 0x1>, <0x100 &apps_smmu 0x1e01 0x1>;