diff mbox series

[2/8] clk: HI655X: select REGMAP instead of depending on it

Message ID	20230226053953.4681-3-rdunlap@infradead.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Randy Dunlap <rdunlap@infradead.org> To: linux-kernel@vger.kernel.org Cc: Randy Dunlap <rdunlap@infradead.org>, Riku Voipio <riku.voipio@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Michael Turquette <mturquette@baylibre.com>, linux-clk@vger.kernel.org Subject: [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it Date: Sat, 25 Feb 2023 21:39:47 -0800 Message-Id: <20230226053953.4681-3-rdunlap@infradead.org> In-Reply-To: <20230226053953.4681-1-rdunlap@infradead.org> References: <20230226053953.4681-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	drivers: select REGMAP instead of depending on it \| [0/8] drivers: select REGMAP instead of depending on it [1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it [2/8] clk: HI655X: select REGMAP instead of depending on it [3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it [4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it [5/8] platform: mellanox: select REGMAP instead of depending on it [6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it [7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it [8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it

Commit Message

Randy Dunlap Feb. 26, 2023, 5:39 a.m. UTC

  REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change the use of "depends on REGMAP" to "select REGMAP".

Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Riku Voipio <riku.voipio@linaro.org>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org
---
 drivers/clk/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stephen Boyd March 6, 2023, 7:30 p.m. UTC | #1

Quoting Randy Dunlap (2023-02-25 21:39:47)
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
> 
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
> 
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
> 
> Fixes: 3a49afb84ca0 ("clk: enable hi655x common clk automatically")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Riku Voipio <riku.voipio@linaro.org>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: Michael Turquette <mturquette@baylibre.com>
> Cc: linux-clk@vger.kernel.org
> ---

Applied to clk-fixes

diff mbox series

Patch

diff -- a/drivers/clk/Kconfig b/drivers/clk/Kconfig
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -91,7 +91,7 @@  config COMMON_CLK_RK808
 config COMMON_CLK_HI655X
 	tristate "Clock driver for Hi655x" if EXPERT
 	depends on (MFD_HI655X_PMIC || COMPILE_TEST)
-	depends on REGMAP
+	select REGMAP
 	default MFD_HI655X_PMIC
 	help
 	  This driver supports the hi655x PMIC clock. This