| Message ID | 20221025050450.1743072-1-pedro.guilherme@espectro.eng.br |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp822936wru;
Mon, 24 Oct 2022 22:40:27 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM46NvetG5I7zf+Jlx7wQ0S74v7eSYAacRIbSkJmMPYm7t09xfpD9DGTv83EloGfbiLfVQ++
X-Received: by 2002:a17:907:31c1:b0:742:28a3:5d08 with SMTP id
xf1-20020a17090731c100b0074228a35d08mr30658890ejb.112.1666676416165;
Mon, 24 Oct 2022 22:40:16 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666676416; cv=none;
d=google.com; s=arc-20160816;
b=hm/4GZn/d4DQz41cy8OAkODFkh8NfqUp9dHSFeylJS1Sr67zKanoHWyfeqM++95fOk
uD71FvMfSWPRda6KMiDmzOV+C/Js1KeY6KEIAgq6N3H9w/BOCSa9vU3mU4CnUa5phZRZ
TUbx8QeIIowfoP+9gZpQLTQFER30y+PJeAn0uDr7K0AdDbwSSwqtWj1HZCveNeXaRUKv
Pued5+OvFzsha8RB0nrsbMI7Io56u5fwxbwi4fDBMNVf+i7HaBN1ddy33yQebscwHiMZ
baPiK7PsLAKFbrETpT/pZRaTdhcxLMBI/cxtRMAtC/pAl7Ylewceh8s9vDYMCeyzwSAr
N1cw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=j1lYGNJg0gApexWL949sEnOeM+1QJ7GI5fjt0dDISPA=;
b=x91/l5m2EmY/chzX6Ae+ECMa7/jWclqAkvJlF6AZDXdW5tqZx40wzR5IiIPlq7PWeE
D1aCtjvwvF2FFX//ZacyxnX+7/6gbCfy1xxd6mFn6mz9ffTCEv/bOI747IouCrFkSU33
xA2eoewt8u3vJUit8UN0R/ni748/bOQ+HLsHDyYb6hzDgRB7i7S5eVtOfxG3gtDyxfrV
i2IRM2FSGTCS6BPC9bu/LAbDpMypvtYc+8eQCOgfRkHkfiXk+TpDXipZ7Rvt1trJckrr
y5H3PZqn9iK6ZPDPBVStvycEFo0uB5HHUBoq5p/Dk2EfCYLO2V4rNr7Lv3wXIrGXj/Ew
zcGg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
a24-20020a170906469800b00783d1a13d69si1597487ejr.231.2022.10.24.22.39.52;
Mon, 24 Oct 2022 22:40:16 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230244AbiJYF02 (ORCPT <rfc822;pwkd43@gmail.com> + 99 others);
Tue, 25 Oct 2022 01:26:28 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47442 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229515AbiJYF0Z (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 25 Oct 2022 01:26:25 -0400
X-Greylist: delayed 1280 seconds by postgrey-1.37 at
lindbergh.monkeyblade.net; Mon, 24 Oct 2022 22:26:25 PDT
Received: from gateway22.websitewelcome.com (gateway22.websitewelcome.com
[192.185.46.224])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 321B3BBE1D
for <linux-kernel@vger.kernel.org>;
Mon, 24 Oct 2022 22:26:24 -0700 (PDT)
Received: from atl1wswcm04.websitewelcome.com (unknown [50.6.129.165])
by atl1wswob02.websitewelcome.com (Postfix) with ESMTP id 268911B394
for <linux-kernel@vger.kernel.org>;
Tue, 25 Oct 2022 05:05:01 +0000 (UTC)
Received: from br984.hostgator.com.br ([162.241.203.37])
by cmsmtp with ESMTP
id nC7Yomv9ZgEOMnC7YoEZka; Tue, 25 Oct 2022 05:05:01 +0000
X-Authority-Reason: nr=8
Received: from [177.194.67.221] (port=44582
helo=arch-avell.meuintelbras.local)
by br984.hostgator.com.br with esmtpsa (TLS1.2) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.95)
(envelope-from <pedro.guilherme@espectro.eng.br>)
id 1onC7X-001KDW-TL;
Tue, 25 Oct 2022 02:05:00 -0300
From: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br>
To: laurent.pinchart@ideasonboard.com
Cc: mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Pedro Guilherme Siqueira Moreira
<pedro.guilherme@espectro.eng.br>
Subject: [PATCH v2 1/3] media: uvc_driver: fix missing newline after
declarations
Date: Tue, 25 Oct 2022 02:04:48 -0300
Message-Id: <20221025050450.1743072-1-pedro.guilherme@espectro.eng.br>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-AntiAbuse: This header was added to track abuse,
please include it with any abuse report
X-AntiAbuse: Primary Hostname - br984.hostgator.com.br
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - espectro.eng.br
X-BWhitelist: no
X-Source-IP: 177.194.67.221
X-Source-L: No
X-Exim-ID: 1onC7X-001KDW-TL
X-Source:
X-Source-Args:
X-Source-Dir:
X-Source-Sender: (arch-avell.meuintelbras.local) [177.194.67.221]:44582
X-Source-Auth: pedro.guilherme@espectro.eng.br
X-Email-Count: 1
X-Source-Cap: ZXNwZWN0ODU7ZXNwZWN0ODU7YnI5ODQuaG9zdGdhdG9yLmNvbS5icg==
X-Local-Domain: yes
X-CMAE-Envelope:
MS4xfPqS8vGiHVTShZo100c4PoQMv60P+fklr+y0GGnHEJMyercji0iSNI+UOFnAksNRdkXxefRMbbFusTImqIpMqhmA0pmCjnS8HmreA5RzA7IKMO+yhcP4
vkGNDDaH+IaStK75BH/J9YlMCjs9a49FW+xgL/M3txYqCyMMEmH9kcTbc3UJ+jFZvP/Mx04LypPOVVpJZvRBS5zcIDinIaWGULJUOOy5kt0S0/OQQnZdW4ij
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,
RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747622339980602871?=
X-GMAIL-MSGID: =?utf-8?q?1747636889690058376?=
|
| Series |
[v2,1/3] media: uvc_driver: fix missing newline after declarations
|
|
Commit Message
Pedro Guilherme Siqueira Moreira
Oct. 25, 2022, 5:04 a.m. UTC
Fixes 'Missing a blank line after declarations' warning issued by
scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c
Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br>
---
drivers/media/usb/uvc/uvc_driver.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
Hi Pedro, Thank you for the patch. On Tue, Oct 25, 2022 at 02:04:48AM -0300, Pedro Guilherme Siqueira Moreira wrote: > Fixes 'Missing a blank line after declarations' warning issued by > scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c > > Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/usb/uvc/uvc_driver.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > index 215fb483efb0..b591ad823c66 100644 > --- a/drivers/media/usb/uvc/uvc_driver.c > +++ b/drivers/media/usb/uvc/uvc_driver.c > @@ -732,6 +732,7 @@ static int uvc_parse_streaming(struct uvc_device *dev, > /* Parse the alternate settings to find the maximum bandwidth. */ > for (i = 0; i < intf->num_altsetting; ++i) { > struct usb_host_endpoint *ep; > + > alts = &intf->altsetting[i]; > ep = uvc_find_endpoint(alts, > streaming->header.bEndpointAddress); > @@ -1859,12 +1860,14 @@ static void uvc_delete(struct kref *kref) > > list_for_each_safe(p, n, &dev->chains) { > struct uvc_video_chain *chain; > + > chain = list_entry(p, struct uvc_video_chain, list); > kfree(chain); > } > > list_for_each_safe(p, n, &dev->entities) { > struct uvc_entity *entity; > + > entity = list_entry(p, struct uvc_entity, list); > #ifdef CONFIG_MEDIA_CONTROLLER > uvc_mc_cleanup_entity(entity); > @@ -1874,6 +1877,7 @@ static void uvc_delete(struct kref *kref) > > list_for_each_safe(p, n, &dev->streams) { > struct uvc_streaming *streaming; > + > streaming = list_entry(p, struct uvc_streaming, list); > usb_driver_release_interface(&uvc_driver.driver, > streaming->intf);
I forgot to mention, the subject line should start with "media: uvcvideo:", not "media: uvc_driver:". You can have a look at the git log to see how subject lines are usually formatted for a driver or subsystem. No need to send a v3, I'll change this in my tree, for all three patches in the series. On Tue, Oct 25, 2022 at 09:51:03PM +0300, Laurent Pinchart wrote: > Hi Pedro, > > Thank you for the patch. > > On Tue, Oct 25, 2022 at 02:04:48AM -0300, Pedro Guilherme Siqueira Moreira wrote: > > Fixes 'Missing a blank line after declarations' warning issued by > > scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c > > > > Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > --- > > drivers/media/usb/uvc/uvc_driver.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c > > index 215fb483efb0..b591ad823c66 100644 > > --- a/drivers/media/usb/uvc/uvc_driver.c > > +++ b/drivers/media/usb/uvc/uvc_driver.c > > @@ -732,6 +732,7 @@ static int uvc_parse_streaming(struct uvc_device *dev, > > /* Parse the alternate settings to find the maximum bandwidth. */ > > for (i = 0; i < intf->num_altsetting; ++i) { > > struct usb_host_endpoint *ep; > > + > > alts = &intf->altsetting[i]; > > ep = uvc_find_endpoint(alts, > > streaming->header.bEndpointAddress); > > @@ -1859,12 +1860,14 @@ static void uvc_delete(struct kref *kref) > > > > list_for_each_safe(p, n, &dev->chains) { > > struct uvc_video_chain *chain; > > + > > chain = list_entry(p, struct uvc_video_chain, list); > > kfree(chain); > > } > > > > list_for_each_safe(p, n, &dev->entities) { > > struct uvc_entity *entity; > > + > > entity = list_entry(p, struct uvc_entity, list); > > #ifdef CONFIG_MEDIA_CONTROLLER > > uvc_mc_cleanup_entity(entity); > > @@ -1874,6 +1877,7 @@ static void uvc_delete(struct kref *kref) > > > > list_for_each_safe(p, n, &dev->streams) { > > struct uvc_streaming *streaming; > > + > > streaming = list_entry(p, struct uvc_streaming, list); > > usb_driver_release_interface(&uvc_driver.driver, > > streaming->intf);
Hi Laurent, Thank you for the info and for accepting my patch! I'll better revise the subject lines from now on. On 25/10/2022 15:57, Laurent Pinchart wrote: > I forgot to mention, the subject line should start with "media: > uvcvideo:", not "media: uvc_driver:". You can have a look at the git log > to see how subject lines are usually formatted for a driver or > subsystem. > > No need to send a v3, I'll change this in my tree, for all three patches > in the series. > > On Tue, Oct 25, 2022 at 09:51:03PM +0300, Laurent Pinchart wrote: >> Hi Pedro, >> >> Thank you for the patch. >> >> On Tue, Oct 25, 2022 at 02:04:48AM -0300, Pedro Guilherme Siqueira Moreira wrote: >>> Fixes 'Missing a blank line after declarations' warning issued by >>> scripts/checkpatch.pl on drivers/media/usb/uvc/uvc_driver.c >>> >>> Signed-off-by: Pedro Guilherme Siqueira Moreira <pedro.guilherme@espectro.eng.br> >> >> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> >>> --- >>> drivers/media/usb/uvc/uvc_driver.c | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c >>> index 215fb483efb0..b591ad823c66 100644 >>> --- a/drivers/media/usb/uvc/uvc_driver.c >>> +++ b/drivers/media/usb/uvc/uvc_driver.c >>> @@ -732,6 +732,7 @@ static int uvc_parse_streaming(struct uvc_device *dev, >>> /* Parse the alternate settings to find the maximum bandwidth. */ >>> for (i = 0; i < intf->num_altsetting; ++i) { >>> struct usb_host_endpoint *ep; >>> + >>> alts = &intf->altsetting[i]; >>> ep = uvc_find_endpoint(alts, >>> streaming->header.bEndpointAddress); >>> @@ -1859,12 +1860,14 @@ static void uvc_delete(struct kref *kref) >>> >>> list_for_each_safe(p, n, &dev->chains) { >>> struct uvc_video_chain *chain; >>> + >>> chain = list_entry(p, struct uvc_video_chain, list); >>> kfree(chain); >>> } >>> >>> list_for_each_safe(p, n, &dev->entities) { >>> struct uvc_entity *entity; >>> + >>> entity = list_entry(p, struct uvc_entity, list); >>> #ifdef CONFIG_MEDIA_CONTROLLER >>> uvc_mc_cleanup_entity(entity); >>> @@ -1874,6 +1877,7 @@ static void uvc_delete(struct kref *kref) >>> >>> list_for_each_safe(p, n, &dev->streams) { >>> struct uvc_streaming *streaming; >>> + >>> streaming = list_entry(p, struct uvc_streaming, list); >>> usb_driver_release_interface(&uvc_driver.driver, >>> streaming->intf); >
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index 215fb483efb0..b591ad823c66 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -732,6 +732,7 @@ static int uvc_parse_streaming(struct uvc_device *dev, /* Parse the alternate settings to find the maximum bandwidth. */ for (i = 0; i < intf->num_altsetting; ++i) { struct usb_host_endpoint *ep; + alts = &intf->altsetting[i]; ep = uvc_find_endpoint(alts, streaming->header.bEndpointAddress); @@ -1859,12 +1860,14 @@ static void uvc_delete(struct kref *kref) list_for_each_safe(p, n, &dev->chains) { struct uvc_video_chain *chain; + chain = list_entry(p, struct uvc_video_chain, list); kfree(chain); } list_for_each_safe(p, n, &dev->entities) { struct uvc_entity *entity; + entity = list_entry(p, struct uvc_entity, list); #ifdef CONFIG_MEDIA_CONTROLLER uvc_mc_cleanup_entity(entity); @@ -1874,6 +1877,7 @@ static void uvc_delete(struct kref *kref) list_for_each_safe(p, n, &dev->streams) { struct uvc_streaming *streaming; + streaming = list_entry(p, struct uvc_streaming, list); usb_driver_release_interface(&uvc_driver.driver, streaming->intf);