diff mbox series

x86/mm: fix __swp_entry_to_pte() for Xen PV guests

Message ID 20230306123259.12461-1-jgross@suse.com
State New
Headers
Series x86/mm: fix __swp_entry_to_pte() for Xen PV guests |

Commit Message

Juergen Gross March 6, 2023, 12:32 p.m. UTC 
  Normally __swp_entry_to_pte() is never called with a value translating
to a valid PTE. The only known exception is pte_swap_tests(), resulting
in a WARN splat in Xen PV guests, as __pte_to_swp_entry() did
translate the PFN of the valid PTE to a guest local PFN, while
__swp_entry_to_pte() doesn't do the opposite translation.

Fix that by using __pte() in __swp_entry_to_pte() instead of open
coding the native variant of it.

For correctness do the similar conversion for __swp_entry_to_pmd().

Fixes: 05289402d717 ("mm/debug_vm_pgtable: add tests validating arch helpers for core MM features")
Signed-off-by: Juergen Gross <jgross@suse.com>
---
 arch/x86/include/asm/pgtable_64.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dave Hansen March 6, 2023, 2:08 p.m. UTC | #1 
On 3/6/23 04:32, Juergen Gross wrote:
> Fixes: 05289402d717 ("mm/debug_vm_pgtable: add tests validating arch helpers for core MM features")
> Signed-off-by: Juergen Gross <jgross@suse.com>

This looks sane.  Any reason this shouldn't be cc:stable@?
Juergen Gross March 6, 2023, 2:25 p.m. UTC | #2 
On 06.03.23 15:08, Dave Hansen wrote:
> On 3/6/23 04:32, Juergen Gross wrote:
>> Fixes: 05289402d717 ("mm/debug_vm_pgtable: add tests validating arch helpers for core MM features")
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> This looks sane.  Any reason this shouldn't be cc:stable@?

It wasn't missed for several years now, and production kernels will
probably not have CONFIG_DEBUG_VM_PGTABLE set.

In the end I don't mind either way. It was just a bug I stumbled over
during development of my MTRR series (someone mentioned a problem and
I enabled said config option).


Juergen
Juergen Gross March 27, 2023, 2:26 p.m. UTC | #3 
On 06.03.23 13:32, Juergen Gross wrote:
> Normally __swp_entry_to_pte() is never called with a value translating
> to a valid PTE. The only known exception is pte_swap_tests(), resulting
> in a WARN splat in Xen PV guests, as __pte_to_swp_entry() did
> translate the PFN of the valid PTE to a guest local PFN, while
> __swp_entry_to_pte() doesn't do the opposite translation.
> 
> Fix that by using __pte() in __swp_entry_to_pte() instead of open
> coding the native variant of it.
> 
> For correctness do the similar conversion for __swp_entry_to_pmd().
> 
> Fixes: 05289402d717 ("mm/debug_vm_pgtable: add tests validating arch helpers for core MM features")
> Signed-off-by: Juergen Gross <jgross@suse.com>

Any further comments (apart from "It looks sane")?


Juergen
Juergen Gross April 25, 2023, 8:32 a.m. UTC | #4 
Ping?

On 06.03.23 13:32, Juergen Gross wrote:
> Normally __swp_entry_to_pte() is never called with a value translating
> to a valid PTE. The only known exception is pte_swap_tests(), resulting
> in a WARN splat in Xen PV guests, as __pte_to_swp_entry() did
> translate the PFN of the valid PTE to a guest local PFN, while
> __swp_entry_to_pte() doesn't do the opposite translation.
> 
> Fix that by using __pte() in __swp_entry_to_pte() instead of open
> coding the native variant of it.
> 
> For correctness do the similar conversion for __swp_entry_to_pmd().
> 
> Fixes: 05289402d717 ("mm/debug_vm_pgtable: add tests validating arch helpers for core MM features")
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>   arch/x86/include/asm/pgtable_64.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h
> index 7929327abe00..a629b1b9f65a 100644
> --- a/arch/x86/include/asm/pgtable_64.h
> +++ b/arch/x86/include/asm/pgtable_64.h
> @@ -237,8 +237,8 @@ static inline void native_pgd_clear(pgd_t *pgd)
>   
>   #define __pte_to_swp_entry(pte)		((swp_entry_t) { pte_val((pte)) })
>   #define __pmd_to_swp_entry(pmd)		((swp_entry_t) { pmd_val((pmd)) })
> -#define __swp_entry_to_pte(x)		((pte_t) { .pte = (x).val })
> -#define __swp_entry_to_pmd(x)		((pmd_t) { .pmd = (x).val })
> +#define __swp_entry_to_pte(x)		(__pte((x).val))
> +#define __swp_entry_to_pmd(x)		(__pmd((x).val))
>   
>   extern void cleanup_highmap(void);
>
Juergen Gross May 8, 2023, 12:23 p.m. UTC | #5 
PING (3rd one, after 2 months of getting no feedback)!

I'm inclined to carry it just via the Xen tree if x86 maintainers continue
to ignore it ...


Juergen

On 06.03.23 13:32, Juergen Gross wrote:
> Normally __swp_entry_to_pte() is never called with a value translating
> to a valid PTE. The only known exception is pte_swap_tests(), resulting
> in a WARN splat in Xen PV guests, as __pte_to_swp_entry() did
> translate the PFN of the valid PTE to a guest local PFN, while
> __swp_entry_to_pte() doesn't do the opposite translation.
> 
> Fix that by using __pte() in __swp_entry_to_pte() instead of open
> coding the native variant of it.
> 
> For correctness do the similar conversion for __swp_entry_to_pmd().
> 
> Fixes: 05289402d717 ("mm/debug_vm_pgtable: add tests validating arch helpers for core MM features")
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>   arch/x86/include/asm/pgtable_64.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h
> index 7929327abe00..a629b1b9f65a 100644
> --- a/arch/x86/include/asm/pgtable_64.h
> +++ b/arch/x86/include/asm/pgtable_64.h
> @@ -237,8 +237,8 @@ static inline void native_pgd_clear(pgd_t *pgd)
>   
>   #define __pte_to_swp_entry(pte)		((swp_entry_t) { pte_val((pte)) })
>   #define __pmd_to_swp_entry(pmd)		((swp_entry_t) { pmd_val((pmd)) })
> -#define __swp_entry_to_pte(x)		((pte_t) { .pte = (x).val })
> -#define __swp_entry_to_pmd(x)		((pmd_t) { .pmd = (x).val })
> +#define __swp_entry_to_pte(x)		(__pte((x).val))
> +#define __swp_entry_to_pmd(x)		(__pmd((x).val))
>   
>   extern void cleanup_highmap(void);
>
diff mbox series

Patch

diff --git a/arch/x86/include/asm/pgtable_64.h b/arch/x86/include/asm/pgtable_64.h
index 7929327abe00..a629b1b9f65a 100644
--- a/arch/x86/include/asm/pgtable_64.h
+++ b/arch/x86/include/asm/pgtable_64.h
@@ -237,8 +237,8 @@  static inline void native_pgd_clear(pgd_t *pgd)
 
 #define __pte_to_swp_entry(pte)		((swp_entry_t) { pte_val((pte)) })
 #define __pmd_to_swp_entry(pmd)		((swp_entry_t) { pmd_val((pmd)) })
-#define __swp_entry_to_pte(x)		((pte_t) { .pte = (x).val })
-#define __swp_entry_to_pmd(x)		((pmd_t) { .pmd = (x).val })
+#define __swp_entry_to_pte(x)		(__pte((x).val))
+#define __swp_entry_to_pmd(x)		(__pmd((x).val))
 
 extern void cleanup_highmap(void);