dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994

Message ID 20230305122428.167580-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994 |

Commit Message

Krzysztof Kozlowski March 5, 2023, 12:24 p.m. UTC
  Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
TXT to DT schema:

  apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]

Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Konrad Dybcio March 6, 2023, 10:46 a.m. UTC | #1
On 5.03.2023 13:24, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
> 
>   apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
> 
> Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
It's funny how it was used in the dt in like 2016 but only added
to the driver in 2020..

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> index 16fd67c0bd1f..3580b209cd4a 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
> @@ -40,6 +40,7 @@ properties:
>        - qcom,rpm-msm8953
>        - qcom,rpm-msm8974
>        - qcom,rpm-msm8976
> +      - qcom,rpm-msm8994
>        - qcom,rpm-msm8996
>        - qcom,rpm-msm8998
>        - qcom,rpm-sdm660
> @@ -84,6 +85,7 @@ if:
>            - qcom,rpm-msm8974
>            - qcom,rpm-msm8976
>            - qcom,rpm-msm8953
> +          - qcom,rpm-msm8994
>  then:
>    properties:
>      qcom,glink-channels: false
  
Petr Vorel March 7, 2023, 7:48 p.m. UTC | #2
Hi all,

Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

Kind regards,
Petr
  
Krzysztof Kozlowski March 8, 2023, 8:39 a.m. UTC | #3
On 07/03/2023 20:48, Petr Vorel wrote:
> Hi all,
> 
> Reviewed-by: Petr Vorel <petr.vorel@gmail.com>

What did you review?

Best regards,
Krzysztof
  
Rob Herring March 8, 2023, 10:19 p.m. UTC | #4
On Sun, 05 Mar 2023 13:24:28 +0100, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
> 
>   apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
> 
> Fixes: f935a752f229 ("dt-bindings: soc: qcom: smd-rpm: Convert binding to YAML schema")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
  
Bjorn Andersson March 22, 2023, 2:45 p.m. UTC | #5
On Sun, 5 Mar 2023 13:24:28 +0100, Krzysztof Kozlowski wrote:
> Re-add the qcom,rpm-msm8994 compatible, dropped during conversion from
> TXT to DT schema:
> 
>   apq8094-sony-xperia-kitakami-karin_windy.dtb: smd: rpm:rpm-requests:compatible:0: 'qcom,rpm-msm8994' is not one of ['qcom,rpm-apq8084' ...]
> 
> 

Applied, thanks!

[1/1] dt-bindings: soc: qcom: smd-rpm: re-add missing qcom,rpm-msm8994
      commit: 34d84c3b0f63978efcb5136a6fd2e7e9d889da70

Best regards,
  

Patch

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
index 16fd67c0bd1f..3580b209cd4a 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smd-rpm.yaml
@@ -40,6 +40,7 @@  properties:
       - qcom,rpm-msm8953
       - qcom,rpm-msm8974
       - qcom,rpm-msm8976
+      - qcom,rpm-msm8994
       - qcom,rpm-msm8996
       - qcom,rpm-msm8998
       - qcom,rpm-sdm660
@@ -84,6 +85,7 @@  if:
           - qcom,rpm-msm8974
           - qcom,rpm-msm8976
           - qcom,rpm-msm8953
+          - qcom,rpm-msm8994
 then:
   properties:
     qcom,glink-channels: false