| Message ID | 20230226053953.4681-4-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1809578wrd;
Sat, 25 Feb 2023 21:42:01 -0800 (PST)
X-Google-Smtp-Source:
AK7set8HQqwXDlxgAf7x+n694JwVl/nzTGznzaVecea0fcioM8bsnju8zBYOP0UZkULSl18cESkW
X-Received: by 2002:a17:90a:1a49:b0:237:1610:be01 with SMTP id
9-20020a17090a1a4900b002371610be01mr21077170pjl.13.1677390121463;
Sat, 25 Feb 2023 21:42:01 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677390121; cv=none;
d=google.com; s=arc-20160816;
b=sZ7bBPHAEY7l54eY7ytr7PzyBbpGlpzeFj37H3wU1+OC/8fFufpn5pmS12+nIKR4LL
bNewGass+X/BZyQdFKp7kBJveFV232r0VpKeixa11MTwilDUFp1fWV/JALotKY1oWpNj
cgVnh/CAAZCLR1zGnCs1NMCeRoLxH99ggWYfV9jj20XrsrxioP13TFkeDiH2d/3zaQ4q
7VySWmibpzSbrWEjyBdsU8QedDl5W6vZ0KGKIY9ltGZVfQ2wZ8Zvq7pGMNKmVzAfCHYr
WDb2SKSYILy6JG93FCDjOtWjFFDwv5isRgCy+PEPeQaCJAK/bXe/bPsOHhzJm2Yh66cb
7SSQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=6v9IARzIwbKOte5wIp9AIhAolACRtWXmOhlJpgpaN3Y=;
b=tqy66xx4dSemjXUoKaS0WRqVN+Gn66itGXTljyU5kOcqCc0v4Z/egc8sLRplOygbG7
XTdjuOp4tHl8BpupoUWJLlElr0Imub0+B//EHwvA0n3A5JKC5iv/mhR3AIz1TU1Ve6+U
XDT7Ay56/aKf1oCz/44fOK/KrJNCnT3icD1UyMpsZhNnKhaf3vqTJZQTPNxszwzPFefC
dQ2wXBj1BPgBlFnyxOw0KAlPAtHhZKdigdfd5MiObH25OsHVfBnnbuyE0ybcuTgF1crd
c/XdhhFCIKFgZdwvDwP2obKVNY/Qx460lZA+rktFiKNXjdr2dkj7RG8bvLK6zgs30Xm6
svtQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=WFsJLwpK;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
74-20020a63034d000000b00502f457058fsi3609180pgd.249.2023.02.25.21.41.49;
Sat, 25 Feb 2023 21:42:01 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=WFsJLwpK;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229695AbjBZFkP (ORCPT <rfc822;guoshuai5156@gmail.com>
+ 99 others); Sun, 26 Feb 2023 00:40:15 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56668 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229597AbjBZFj7 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 26 Feb 2023 00:39:59 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org
[IPv6:2607:7c80:54:3::133])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B48136EA;
Sat, 25 Feb 2023 21:39:58 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
:Reply-To:Content-Type:Content-ID:Content-Description;
bh=6v9IARzIwbKOte5wIp9AIhAolACRtWXmOhlJpgpaN3Y=;
b=WFsJLwpKRp042RteZ5099Lv9Q/
IYDDh6FBSdDCOpOzVw/X0tnu3oyQrkokrHwzhI9BZmkcL2W81fDAIAwPZtDeOwBbD5LiqSfZa/TaB
Lj16t/8lxset8GyzVL5oZzP9mMoQ5JnAJ+9I/CkjkAET9HyYjdZvj62WRvNL7gUclDN8o9gL4wDyv
OMHZAZhkoYlAgnpKw9Cu0mI7tUhANa9sZD8/tMuyQ6/21I4TsXvPWoUaqOuJoDnsU4qrvp2ap3x6a
DqHfVoNpVCI8TDlyD9jlfsjY2MAvr8hXyCBU4NtKItIUSxIdYPtTOuNrmxqECDTyHhy+ElsYnLCMs
y0MfmFqw==;
Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat
Linux))
id 1pW9lL-006qYL-Sq; Sun, 26 Feb 2023 05:39:56 +0000
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Michael Walle <michael@walle.cc>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, linux-gpio@vger.kernel.org
Subject: [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on
it
Date: Sat, 25 Feb 2023 21:39:48 -0800
Message-Id: <20230226053953.4681-4-rdunlap@infradead.org>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230226053953.4681-1-rdunlap@infradead.org>
References: <20230226053953.4681-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1758871023747743129?=
X-GMAIL-MSGID: =?utf-8?q?1758871023747743129?=
|
| Series |
drivers: select REGMAP instead of depending on it
|
|
Commit Message
Randy Dunlap
Feb. 26, 2023, 5:39 a.m. UTC
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using regmap")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Walle <michael@walle.cc>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: linux-gpio@vger.kernel.org
---
drivers/gpio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Am 2023-02-26 06:39, schrieb Randy Dunlap: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using > regmap") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Michael Walle <michael@walle.cc> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: linux-gpio@vger.kernel.org Acked-by: Michael Walle <michael@walle.cc> Thanks, -michael
On Sun, Feb 26, 2023 at 6:40 AM Randy Dunlap <rdunlap@infradead.org> wrote: > > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: ebe363197e52 ("gpio: add a reusable generic gpio_chip using regmap") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Michael Walle <michael@walle.cc> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Bartosz Golaszewski <brgl@bgdev.pl> > Cc: linux-gpio@vger.kernel.org > --- > drivers/gpio/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -100,7 +100,7 @@ config GPIO_GENERIC > tristate > > config GPIO_REGMAP > - depends on REGMAP > + select REGMAP > tristate > > # put drivers in the right section, in alphabetical order Queued for fixes, thanks! Bart
diff -- a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -100,7 +100,7 @@ config GPIO_GENERIC tristate config GPIO_REGMAP - depends on REGMAP + select REGMAP tristate # put drivers in the right section, in alphabetical order