diff mbox series

[v1,1/1] gpiolib: cdev: Fix typo in kernel doc for struct line

Message ID 20221020153914.63260-1-andriy.shevchenko@linux.intel.com
State New
Headers
Series [v1,1/1] gpiolib: cdev: Fix typo in kernel doc for struct line |

Commit Message

Andy Shevchenko Oct. 20, 2022, 3:39 p.m. UTC 
  When eflags has been renamed to the edflags, the kernel doc change were
missed. Update kernel doc accordingly.

Fixes: b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpio/gpiolib-cdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kent Gibson Oct. 21, 2022, 12:53 p.m. UTC | #1 
On Thu, Oct 20, 2022 at 06:39:14PM +0300, Andy Shevchenko wrote:
> When eflags has been renamed to the edflags, the kernel doc change were
> missed. Update kernel doc accordingly.
> 
> Fixes: b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Kent Gibson <warthog618@gmail.com>

> ---
>  drivers/gpio/gpiolib-cdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
> index 0c84b011a64a..f9288e41e3a7 100644
> --- a/drivers/gpio/gpiolib-cdev.c
> +++ b/drivers/gpio/gpiolib-cdev.c
> @@ -412,7 +412,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip)
>   * @desc: the GPIO descriptor for this line.
>   * @req: the corresponding line request
>   * @irq: the interrupt triggered in response to events on this GPIO
> - * @eflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
> + * @edflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
>   * GPIO_V2_LINE_FLAG_EDGE_FALLING, indicating the edge detection applied
>   * @timestamp_ns: cache for the timestamp storing it between hardirq and
>   * IRQ thread, used to bring the timestamp close to the actual event
> -- 
> 2.35.1
>
Andy Shevchenko Oct. 25, 2022, 4:48 p.m. UTC | #2 
On Fri, Oct 21, 2022 at 08:53:36PM +0800, Kent Gibson wrote:
> On Thu, Oct 20, 2022 at 06:39:14PM +0300, Andy Shevchenko wrote:
> > When eflags has been renamed to the edflags, the kernel doc change were
> > missed. Update kernel doc accordingly.
> > 
> > Fixes: b1a92e94560d ("gpiolib: cdev: consolidate edge detector configuration flags")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Kent Gibson <warthog618@gmail.com>

Pushed to my review and testing queue, thanks!
diff mbox series

Patch

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index 0c84b011a64a..f9288e41e3a7 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -412,7 +412,7 @@  static int linehandle_create(struct gpio_device *gdev, void __user *ip)
  * @desc: the GPIO descriptor for this line.
  * @req: the corresponding line request
  * @irq: the interrupt triggered in response to events on this GPIO
- * @eflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
+ * @edflags: the edge flags, GPIO_V2_LINE_FLAG_EDGE_RISING and/or
  * GPIO_V2_LINE_FLAG_EDGE_FALLING, indicating the edge detection applied
  * @timestamp_ns: cache for the timestamp storing it between hardirq and
  * IRQ thread, used to bring the timestamp close to the actual event