Message ID | 20230226130539.277336-2-peng.fan@oss.nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1933155wrd; Sun, 26 Feb 2023 05:04:06 -0800 (PST) X-Google-Smtp-Source: AK7set9dyCdOs69QSiefqNQyhYRLfZIY7LU9VGGYnVs3XxKogeAJbA3TIR1GI81fRKVpTHiKtc8n X-Received: by 2002:a05:6402:4313:b0:4ae:eb0e:301d with SMTP id m19-20020a056402431300b004aeeb0e301dmr24599611edc.4.1677416646452; Sun, 26 Feb 2023 05:04:06 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1677416646; cv=pass; d=google.com; s=arc-20160816; b=ACseAkA3qUblqYirdLSEhKtF5DTK3JRQzq6c1aWTHGt+nKFswBkD9sjU1uG8Y+tIOu 5EqkO8SqBUCjVntK93wT0VTDwratZ2FV+0EnbNOKc26V8b3+R5PK3hEagfrU0v0Aa2c4 v/ZtBPbOmSc6Cw9leTU2RBJJSoHW1Txw6f3CA8JkMCS/VjIc76aSv1VCmsGYWiVqdLQG nM0MacGXDRbUo69cRmGESqVklV/GWayH3sQxcAN3u6vcrEtYfp5e2DdssjiGcYfwdRLZ A6u1/NFzxcIoT53Aqbj1mjxTukOW7281m93eB1rT+pkZBBWoHAPhZwt8LDXBlHLxFdU/ 5M+g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eDZaeAs1gGdg+asb9N+gR0yNFVxWeH255sGDbjSZkgQ=; b=VmuHZB3s2A5XZfQOlWNtCxMpHnXl7zZrSuZ4Sk2SUsqC81+x5RCAK3LFJ6oe97VmCO utNdelpH2iCJYPO/Dsgmn9oceMcSlsG5YuXEcC3Kzo3nNA/YVnJKTXA4mCm1wEg5jIDE zMfuBKEWt9gAb+DQSnaUbjQUJclPecXyaAVHuzfOxd6dMyW0j0nI664XZmm9ngZetY3U VZbIg08RLYgyDB3/UDmrMWYqr2DwKH/kMaFbdVFyiWBjscgiRFaVM+NpOhD4p5RzFTaH UxJnukg1Zl4Kxf9200UmMrYvPS/LE6ayYHK2pos3KXfz6v5UM5K0+DXDj2AFW4erYIrR VYsw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=FT8K897O; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m21-20020a50ef15000000b004ab2521aed1si5918123eds.293.2023.02.26.05.03.43; Sun, 26 Feb 2023 05:04:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@NXP1.onmicrosoft.com header.s=selector2-NXP1-onmicrosoft-com header.b=FT8K897O; arc=pass (i=1 spf=pass spfdomain=oss.nxp.com dkim=pass dkdomain=oss.nxp.com dmarc=pass fromdomain=oss.nxp.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229678AbjBZNAw (ORCPT <rfc822;tertiaryakionsight@gmail.com> + 99 others); Sun, 26 Feb 2023 08:00:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229669AbjBZNAp (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 26 Feb 2023 08:00:45 -0500 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2064.outbound.protection.outlook.com [40.107.20.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56A6F1205D; Sun, 26 Feb 2023 05:00:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ghWYwaT4bHpB7auYyk2ZvaNxM9oDpdpDC49pvoTF0pqsG7IHFHmfKokNcDxO0LRfqp77L515akmoXw8EQrfNzt0iX8zhuJvhdV+b8Mkq1MI+nOdfZLKvK2x00gTyfTj8elAveALRHXpW7hEmqSmE6HyXjnCS9lyvrKKFe0U860a/Fr3HQAWUsoN/lh1ggwParElt7K1ZUJzb5UDAfXC9BGqGKyZBzqcQjVgk4G9tjti3OI+E13vtmgdh05TF64qlqtnDNvSAeMVin4LPGjTW4vJEJ4qSDC6R7ttVqtnUI4jLVvQrgVJFh50FzP979spUmewmBEF8TWzo6XHOyVjxWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eDZaeAs1gGdg+asb9N+gR0yNFVxWeH255sGDbjSZkgQ=; b=Bg6UKzlAteH3eE5hWAr6A38a7DUjTQLldrQ7SXKfot+9AZos9GSaNwLfiDRy+iEJ8PaYrD1aJJJsltprNO/x68MfAhLEw6ct9EoYC5Fe3kdsmvbgwwXGCvbuG7TmSKNF1S1Jhp/kdzeU6ymEKDboZjwErTKRfjCcLb1togWHBuiQRLV0OwTZllwrDOq0YW0jpibHBw+KND1sKbXNlnLP6YO3N3zLueaC0UgGVyORCVfid+wfmmdF3igE0/sWm06wXzfsIG5nh4oa9sO+pE5iZHcqT9tPVxwVrqglid3SNbYCrDPpa5UBeMfTVH1NIwTFkgZjPiiKbRZeWcXYVA72iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eDZaeAs1gGdg+asb9N+gR0yNFVxWeH255sGDbjSZkgQ=; b=FT8K897O+Fj6Mm4YszIFiud2iWTNHUJI060VVg6A8cAxOH1ZN7qMVzpTrKj6iU/D2MTo4kLGpm+/u+9RztauANInwynt50VIzBj09gkXE1wcbTVVAgjAkcr5Vhp95gj2AqWEg6WmfXRCJXbilU9v4OAUxpct0yDH+EPuaaqq/kE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by DU2PR04MB8968.eurprd04.prod.outlook.com (2603:10a6:10:2e3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.27; Sun, 26 Feb 2023 13:00:37 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::f55a:cf12:da08:6d2a]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::f55a:cf12:da08:6d2a%3]) with mapi id 15.20.6134.025; Sun, 26 Feb 2023 13:00:37 +0000 From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com> To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, xu.yang_2@nxp.com Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jun.li@nxp.com, Peng Fan <peng.fan@nxp.com> Subject: [PATCH V3 1/7] dt-bindings: usb: usbmisc-imx: convert to DT schema Date: Sun, 26 Feb 2023 21:05:33 +0800 Message-Id: <20230226130539.277336-2-peng.fan@oss.nxp.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230226130539.277336-1-peng.fan@oss.nxp.com> References: <20230226130539.277336-1-peng.fan@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2P153CA0002.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::16) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|DU2PR04MB8968:EE_ X-MS-Office365-Filtering-Correlation-Id: ab383b70-597c-4fef-f85a-08db17f97434 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fTaR3JOE0SFQThXbJIZvuvou9LW5o+sD0CaQdQeSxoQlZPxnrMM44k0EKx1P3eDBr8jYGSjAPQkCJ+zHJyvu7HdM3BrLruBpSdgFHiar6K6V7PN/JQr1zowYJl94ZnvJgeeaX9HXDa/IcFEte6003H8WBiHLTI9BjdSbd0IIwcAhtLhEuRSYjkhxlzh8y2aJ7QZq6ihvyJP7qHdhjnwd/Z8jvVk26zLBTaDwy9TeeDUwwvqPJVbWP4OmH1bdiifU+p6L5Ew3fkfjO4mXUD6W7MLa+7w6BBGX+lyWt39MkU6eaFzHM+QhxHJlhkiDmNrGd5sKO0t7axhMIBoUEqQMJa3DWgGDyw9Cep+ppoDciV5m3vboNuc+O15zojQf2Rqk5/qsjnLVYUKU+HoIU0x1xrRaFHnIFlADGhgxKgILn/2j1XfcQgQRMD58eMn5DH4UMFE8tXrtpQdB/S960NFQ8G0bZZzgmSv4RXJNV+E9sYc+uXZxiVQPvcwp4sUqKe5NbxSfSu5RjfnE4rivTQD9fN7Ti/y2daXDsLh3mg5xpm5mc7gqRMQFoyqw5QZAt+oDEeq4KLkI7QGYRXONjdU+7kpr6/FFnI3PNqnwp5L9DnJf19mzvOoJlzxebLE1YmB3STD0wbzJN7S7HaWqJaI6lrAiPNP541p1MCxDw/jhadnwz74XOM/aFVFBupE+jFtC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(136003)(366004)(39860400002)(346002)(396003)(376002)(451199018)(83380400001)(8676002)(6666004)(38350700002)(38100700002)(86362001)(8936002)(5660300002)(478600001)(7416002)(2616005)(26005)(6486002)(966005)(1076003)(6512007)(6506007)(66556008)(66476007)(4326008)(2906002)(66946007)(316002)(52116002)(186003)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: OyrQT8DldUyUPOkmQbtfiw7+HM7epQl/S8+hbkq/Yh/bQle1TLlCCF7lEY9rxUKOPAmaCxVDE7Bfu5M/zu9i3mow4G+vY+mZGM6QeGJfNuOHuc+8La8d04U4gel6F2cub3PGAYpJc/va5JF/suaPKdfkobp/OgO8MDAxxfnTo3ais4Bcif8OlOO14rlvqkabsphZ0aRo73yUY5ojiYY+ybX0f67yFjr369GKG3iu+z1yxISN8nPhst9prD5/M3szls82FXlm2+zAUfVpArasIwpVkpKbElSKeGn01sP3j2zDiHuwa8noQ/k6a7+csuEspsIwCUArvwMrMl6oVhNE7gb9TSL+b0C5WTfQa4FcQIZqE4JMSpNEoTdSN6NLRyPhsLDw8G1o8uFY79FZAGn68YHkFmEYz6XD8MZosk9+UIAbTVyHIuWasT+YwL4uWYnPq81AV8eGqglcLBXvgEqf5c4OIYReacHSJOYu7NiiNebfRJ0vGL88kgqbYsfVJLtRiHcUB1DWJjuiFrP7hmdULmgxFZ1CIkFQjIHXpiBr4+jbPtKkOxW7Ap1Mdm50dbY6dexdQ+0Yk90dUStODEbhRkbcarkBWT80iOVo4XJpSH504zUennHckd5H8DvG5Wjt4TJDe+PyI2zZ8PIUblZ3tiT4/onsTWQBIfKjLIlKbPvjoZYXRBy8jYpeMdRhTSOrIz0Fz/yzMvslGfg5KvpQ3TjWLNWglWSV+6FwHK+3wLu400/iJqY1PNaP94pKEMWpdLxWwYmyoqmLtvNH3IkRHiEjeSFkuTjpMGbkwQmHI/Vk9Ggrfz1lYmOlW8ceRVeisJTkkZ1E6NO1yMTbTfomlmH4AjLUQxgcAKGWqhOf/dPMJ8SV6yQfMX8NFPnQNbCwpuMVJ8Mlkou10WvirFJwaNPBqsX6GcGYFxnT7VGWdKoS6nB/0L3XfYfNxK1uTLpz0dJqMX8A6t7WQ3NC8bSzrnPKkb79rAaqn9QI3OWKroc4oOrGHbD6lmISECLdukaVJh9rjoRucfHgm5bKdB0pxvTG20v8VgfFHy6U9+VClVbUwnDcJnpOf4EXhaTgyw8VML2NtF1hXC3UApH6rzX89Lbaz0hHr5OCJ6hU8byIKBxXGlc6soXxrAAUcoAMpBgdE9S2gMTzyXI+uzTDFQGPaH4rjtB83OEgPXzmc41doGlitEIHL3KTJOPUwu1zKHSBBm2O/qfUA8PPy9qnhA8wSOQMDQ91zJ7SKiKaoGXmH5JDqvZwjfQ4NtFgJbl4W0r/6j8iVdQxH04rt6kBFohDcv3gQkLDqzr1VlO5BRJFVWYoTymMlLLFRfCpYSudYq4z4nxZYgZaGQK0UleDtAD8A7RuQiFz12u8jK1EhwVi8fFErkcPtfUba93W/graOiN9GHgB9mkCy1+HxhWohej214zj2ZsapEvBhaTmGgLkT1uM7b8pNrEbh1W7Lbgw46VyA0KlEoPQ7WS3YSrz9B8fYcx3kPQ1XE20c+eNrEOrJwpqyS14k2seDDAw6vXWnIAXb4fffWypHqpOWPWg/tmeT24C4YZqL23yIxO3pdkRL0t09cFl9ewYGxe2+zNvG8Xc X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab383b70-597c-4fef-f85a-08db17f97434 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2023 13:00:36.9793 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lLxIY0pZ0TBD9B6fm+icw+7NgAh5QziSbtdxtuSSifTeiOAz5UB+jqK1tEpEoQx1O3Osd/2WdL8gQ6MBYWBz5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8968 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758898837533955206?= X-GMAIL-MSGID: =?utf-8?q?1758898837533955206?= |
Series |
dt-bindings: usb: covert ci-hdrc-usb2/usbmisc-imx to yaml
|
|
Commit Message
Peng Fan (OSS)
Feb. 26, 2023, 1:05 p.m. UTC
From: Peng Fan <peng.fan@nxp.com> Convert usbmisc-imx to DT schema format. Signed-off-by: Peng Fan <peng.fan@nxp.com> --- .../devicetree/bindings/usb/fsl,usbmisc.yaml | 54 +++++++++++++++++++ .../devicetree/bindings/usb/usbmisc-imx.txt | 19 ------- 2 files changed, 54 insertions(+), 19 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt
Comments
On Sun, Feb 26, 2023 at 09:05:33PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > Convert usbmisc-imx to DT schema format. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > .../devicetree/bindings/usb/fsl,usbmisc.yaml | 54 +++++++++++++++++++ > .../devicetree/bindings/usb/usbmisc-imx.txt | 19 ------- > 2 files changed, 54 insertions(+), 19 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > delete mode 100644 Documentation/devicetree/bindings/usb/usbmisc-imx.txt > > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > new file mode 100644 > index 000000000000..517390b9d2c6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX wrapper module for Chipidea USB2 controller > + > +maintainers: > + - Xu Yang <xu.yang_2@nxp.com> > + - Peng Fan <peng.fan@nxp.com> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx6q-usbmisc > + - fsl,imx7ulp-usbmisc > + - fsl,vf610-usbmisc > + - items: > + - enum: > + - fsl,imx6ul-usbmisc > + - fsl,imx6sx-usbmisc > + - fsl,imx7d-usbmisc > + - const: fsl,imx6q-usbmisc > + - items: > + - enum: > + - fsl,imx7ulp-usbmisc > + - fsl,imx8mm-usbmisc > + - const: fsl,imx7d-usbmisc So imx8mm is compatible with imx7d, and imx7d is compatible with imx6q, but imx8mm is not compatible with imx6q? That doesn't really make sense. Maybe all 3 compatibles makes sense, but only if s/w understanding only one of the fallback compatibles would function without knowledge of the newer h/w. > + > + reg: > + maxItems: 1 > + > + '#index-cells': > + const: 1 > + description: Cells used to describe usb controller index. Please mark this as deprecated. If it is always 1 cell, then there's no point. > + > +required: > + - compatible > + - reg > + - '#index-cells' And drop as required. That all can be a follow-up patch if you prefer or in this patch is fine. Primarily, I don't want this pattern copied. > + > +additionalProperties: false > + > +examples: > + - | > + usbmisc@2184800 { > + #index-cells = <1>; > + compatible = "fsl,imx6q-usbmisc"; > + reg = <0x02184800 0x200>; > + }; > + > +... > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt > deleted file mode 100644 > index 29b8f65ff849..000000000000 > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt > +++ /dev/null > @@ -1,19 +0,0 @@ > -* Freescale i.MX non-core registers > - > -Required properties: > -- #index-cells: Cells used to describe usb controller index. Should be <1> > -- compatible: Should be one of below: > - "fsl,imx6q-usbmisc" for imx6q > - "fsl,vf610-usbmisc" for Vybrid vf610 > - "fsl,imx6sx-usbmisc" for imx6sx > - "fsl,imx7d-usbmisc" for imx7d > - "fsl,imx7ulp-usbmisc" for imx7ulp > - "fsl,imx8mm-usbmisc" for imx8mm > -- reg: Should contain registers location and length > - > -Examples: > -usbmisc@2184800 { > - #index-cells = <1>; > - compatible = "fsl,imx6q-usbmisc"; > - reg = <0x02184800 0x200>; > -}; > -- > 2.37.1 >
> Subject: Re: [PATCH V3 1/7] dt-bindings: usb: usbmisc-imx: convert to DT > schema > > On Sun, Feb 26, 2023 at 09:05:33PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > Convert usbmisc-imx to DT schema format. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > .../devicetree/bindings/usb/fsl,usbmisc.yaml | 54 +++++++++++++++++++ > > .../devicetree/bindings/usb/usbmisc-imx.txt | 19 ------- > > 2 files changed, 54 insertions(+), 19 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > > delete mode 100644 > > Documentation/devicetree/bindings/usb/usbmisc-imx.txt > > > > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > > b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > > new file mode 100644 > > index 000000000000..517390b9d2c6 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > > @@ -0,0 +1,54 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fusb%2Ffsl%2Cusbmisc.yaml%23&data=05%7C0 > 1%7Cpen > > > +g.fan%40nxp.com%7C688a52ac42294bd0a9e208db19048b8c%7C686ea1d3 > bc2b4c6f > > > +a92cd99c5c301635%7C0%7C0%7C638131279545141829%7CUnknown%7CT > WFpbGZsb3d > > > +8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0 > %3D%7 > > > +C3000%7C%7C%7C&sdata=4V5Lpsj6g0mJqJyGZTVoFeas%2B1IvTEW0ERe3y > 9vjsxE%3D > > +&reserved=0 > > +$schema: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > +cetree.org%2Fmeta- > schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%40nx > > > +p.com%7C688a52ac42294bd0a9e208db19048b8c%7C686ea1d3bc2b4c6fa9 > 2cd99c5c > > > +301635%7C0%7C0%7C638131279545141829%7CUnknown%7CTWFpbGZsb > 3d8eyJWIjoiM > > > +C4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C300 > 0%7C%7 > > > +C%7C&sdata=PVGWk1%2B9YP1vixM%2BiB4XDH0UKWTTM%2FOiA5aZiPcn > 6Qk%3D&reser > > +ved=0 > > + > > +title: Freescale i.MX wrapper module for Chipidea USB2 controller > > + > > +maintainers: > > + - Xu Yang <xu.yang_2@nxp.com> > > + - Peng Fan <peng.fan@nxp.com> > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - fsl,imx6q-usbmisc > > + - fsl,imx7ulp-usbmisc > > + - fsl,vf610-usbmisc > > + - items: > > + - enum: > > + - fsl,imx6ul-usbmisc > > + - fsl,imx6sx-usbmisc > > + - fsl,imx7d-usbmisc > > + - const: fsl,imx6q-usbmisc > > + - items: > > + - enum: > > + - fsl,imx7ulp-usbmisc > > + - fsl,imx8mm-usbmisc > > + - const: fsl,imx7d-usbmisc > > So imx8mm is compatible with imx7d, and imx7d is compatible with imx6q, > but imx8mm is not compatible with imx6q? That doesn't really make sense. > Maybe all 3 compatibles makes sense, but only if s/w understanding only > one of the fallback compatibles would function without knowledge of the > newer h/w. I added the list according the current device tree in use. If using three compatibles, that would involve device tree upate, and firmware update for SR-IR. My understanding is imx8mm is compatible with imx7d, imx7d is compatible with imx6q, then imx8mm is compatible with imx6q. it is just not put them under one item. Please correct if my understanding is wrong. > > > + > > + reg: > > + maxItems: 1 > > + > > + '#index-cells': > > + const: 1 > > + description: Cells used to describe usb controller index. > > Please mark this as deprecated. If it is always 1 cell, then there's no point. Fix in v4. > > > + > > +required: > > + - compatible > > + - reg > > + - '#index-cells' > > And drop as required. That all can be a follow-up patch if you prefer or in > this patch is fine. Primarily, I don't want this pattern copied. > Fix in v4. Thanks, Peng. > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + usbmisc@2184800 { > > + #index-cells = <1>; > > + compatible = "fsl,imx6q-usbmisc"; > > + reg = <0x02184800 0x200>; > > + }; > > + > > +... > > diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt > > b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt > > deleted file mode 100644 > > index 29b8f65ff849..000000000000 > > --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt > > +++ /dev/null > > @@ -1,19 +0,0 @@ > > -* Freescale i.MX non-core registers > > - > > -Required properties: > > -- #index-cells: Cells used to describe usb controller index. Should > > be <1> > > -- compatible: Should be one of below: > > - "fsl,imx6q-usbmisc" for imx6q > > - "fsl,vf610-usbmisc" for Vybrid vf610 > > - "fsl,imx6sx-usbmisc" for imx6sx > > - "fsl,imx7d-usbmisc" for imx7d > > - "fsl,imx7ulp-usbmisc" for imx7ulp > > - "fsl,imx8mm-usbmisc" for imx8mm > > -- reg: Should contain registers location and length > > - > > -Examples: > > -usbmisc@2184800 { > > - #index-cells = <1>; > > - compatible = "fsl,imx6q-usbmisc"; > > - reg = <0x02184800 0x200>; > > -}; > > -- > > 2.37.1 > >
Hi Rob, Krzysztof, On 2/28/2023 1:55 PM, Peng Fan wrote: >> Subject: Re: [PATCH V3 1/7] dt-bindings: usb: usbmisc-imx: convert to DT >> schema ... >>> + >>> +title: Freescale i.MX wrapper module for Chipidea USB2 controller >>> + >>> +maintainers: >>> + - Xu Yang <xu.yang_2@nxp.com> >>> + - Peng Fan <peng.fan@nxp.com> >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - enum: >>> + - fsl,imx6q-usbmisc >>> + - fsl,imx7ulp-usbmisc >>> + - fsl,vf610-usbmisc >>> + - items: >>> + - enum: >>> + - fsl,imx6ul-usbmisc >>> + - fsl,imx6sx-usbmisc >>> + - fsl,imx7d-usbmisc >>> + - const: fsl,imx6q-usbmisc >>> + - items: >>> + - enum: >>> + - fsl,imx7ulp-usbmisc >>> + - fsl,imx8mm-usbmisc >>> + - const: fsl,imx7d-usbmisc >> >> So imx8mm is compatible with imx7d, and imx7d is compatible with imx6q, >> but imx8mm is not compatible with imx6q? That doesn't really make sense. >> Maybe all 3 compatibles makes sense, but only if s/w understanding only >> one of the fallback compatibles would function without knowledge of the >> newer h/w. > > I added the list according the current device tree in use. If using > three compatibles, that would involve device tree upate, and firmware > update for SR-IR. > > My understanding is imx8mm is compatible with imx7d, imx7d is compatible > with imx6q, then imx8mm is compatible with imx6q. it is just not put > them under one item. Please correct if my understanding is wrong. >> Do you have any guidance here? I am not sure how to proceed on V4. Thanks, Peng >>> + >>> + reg: >>> + maxItems: 1 >>> + >>> + '#index-cells': >>> + const: 1 >>> + description: Cells used to describe usb controller index. >> >> Please mark this as deprecated. If it is always 1 cell, then there's no point. > > Fix in v4. >> >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - '#index-cells' >> >> And drop as required. That all can be a follow-up patch if you prefer or in >> this patch is fine. Primarily, I don't want this pattern copied. >> > > Fix in v4. > > Thanks, > Peng. >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + usbmisc@2184800 { >>> + #index-cells = <1>; >>> + compatible = "fsl,imx6q-usbmisc"; >>> + reg = <0x02184800 0x200>; >>> + }; >>> + >>> +... >>> diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt >>> b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt >>> deleted file mode 100644 >>> index 29b8f65ff849..000000000000 >>> --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt >>> +++ /dev/null >>> @@ -1,19 +0,0 @@ >>> -* Freescale i.MX non-core registers >>> - >>> -Required properties: >>> -- #index-cells: Cells used to describe usb controller index. Should >>> be <1> >>> -- compatible: Should be one of below: >>> - "fsl,imx6q-usbmisc" for imx6q >>> - "fsl,vf610-usbmisc" for Vybrid vf610 >>> - "fsl,imx6sx-usbmisc" for imx6sx >>> - "fsl,imx7d-usbmisc" for imx7d >>> - "fsl,imx7ulp-usbmisc" for imx7ulp >>> - "fsl,imx8mm-usbmisc" for imx8mm >>> -- reg: Should contain registers location and length >>> - >>> -Examples: >>> -usbmisc@2184800 { >>> - #index-cells = <1>; >>> - compatible = "fsl,imx6q-usbmisc"; >>> - reg = <0x02184800 0x200>; >>> -}; >>> -- >>> 2.37.1 >>>
diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml new file mode 100644 index 000000000000..517390b9d2c6 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/fsl,usbmisc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Freescale i.MX wrapper module for Chipidea USB2 controller + +maintainers: + - Xu Yang <xu.yang_2@nxp.com> + - Peng Fan <peng.fan@nxp.com> + +properties: + compatible: + oneOf: + - enum: + - fsl,imx6q-usbmisc + - fsl,imx7ulp-usbmisc + - fsl,vf610-usbmisc + - items: + - enum: + - fsl,imx6ul-usbmisc + - fsl,imx6sx-usbmisc + - fsl,imx7d-usbmisc + - const: fsl,imx6q-usbmisc + - items: + - enum: + - fsl,imx7ulp-usbmisc + - fsl,imx8mm-usbmisc + - const: fsl,imx7d-usbmisc + + reg: + maxItems: 1 + + '#index-cells': + const: 1 + description: Cells used to describe usb controller index. + +required: + - compatible + - reg + - '#index-cells' + +additionalProperties: false + +examples: + - | + usbmisc@2184800 { + #index-cells = <1>; + compatible = "fsl,imx6q-usbmisc"; + reg = <0x02184800 0x200>; + }; + +... diff --git a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt b/Documentation/devicetree/bindings/usb/usbmisc-imx.txt deleted file mode 100644 index 29b8f65ff849..000000000000 --- a/Documentation/devicetree/bindings/usb/usbmisc-imx.txt +++ /dev/null @@ -1,19 +0,0 @@ -* Freescale i.MX non-core registers - -Required properties: -- #index-cells: Cells used to describe usb controller index. Should be <1> -- compatible: Should be one of below: - "fsl,imx6q-usbmisc" for imx6q - "fsl,vf610-usbmisc" for Vybrid vf610 - "fsl,imx6sx-usbmisc" for imx6sx - "fsl,imx7d-usbmisc" for imx7d - "fsl,imx7ulp-usbmisc" for imx7ulp - "fsl,imx8mm-usbmisc" for imx8mm -- reg: Should contain registers location and length - -Examples: -usbmisc@2184800 { - #index-cells = <1>; - compatible = "fsl,imx6q-usbmisc"; - reg = <0x02184800 0x200>; -};