diff mbox series

[1/2] dt-bindings: ath10k: Add vdd-smps supply

Message ID 20230303024246.2175382-1-konrad.dybcio@linaro.org
State New
Headers
Series [1/2] dt-bindings: ath10k: Add vdd-smps supply |

Commit Message

Konrad Dybcio March 3, 2023, 2:42 a.m. UTC 
  Mention the newly added vdd-smps supply.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski March 3, 2023, 7:12 a.m. UTC | #1 
On 03/03/2023 03:42, Konrad Dybcio wrote:
> Mention the newly added vdd-smps supply.

There is no explanation here, but looking at your driver change it
suggests name is not correct. You named it based on regulator (so the
provider), not the consumer.

Best regards,
Krzysztof
Konrad Dybcio March 3, 2023, 11:28 a.m. UTC | #2 
On 3.03.2023 08:12, Krzysztof Kozlowski wrote:
> On 03/03/2023 03:42, Konrad Dybcio wrote:
>> Mention the newly added vdd-smps supply.
> 
> There is no explanation here, but looking at your driver change it
> suggests name is not correct. You named it based on regulator (so the
> provider), not the consumer.

Right, I admit this could have been posted with an RFC tag.
Maybe Kalle knows more.

Konrad
> 
> Best regards,
> Krzysztof
>
Kalle Valo March 3, 2023, 12:56 p.m. UTC | #3 
Konrad Dybcio <konrad.dybcio@linaro.org> writes:

> On 3.03.2023 08:12, Krzysztof Kozlowski wrote:
>> On 03/03/2023 03:42, Konrad Dybcio wrote:
>>> Mention the newly added vdd-smps supply.
>> 
>> There is no explanation here, but looking at your driver change it
>> suggests name is not correct. You named it based on regulator (so the
>> provider), not the consumer.

Yeah, it would be nice to have more than just one sentence in the commit
log.

> Right, I admit this could have been posted with an RFC tag.
> Maybe Kalle knows more.

Unfortunately not, but maybe Bjorn knows?
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
index b61c2d5a0ff7..8697e63aeffa 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt
@@ -66,7 +66,7 @@  Optional properties:
 - <supply-name>-supply: handle to the regulator device tree node
 			   optional "supply-name" are "vdd-0.8-cx-mx",
 			   "vdd-1.8-xo", "vdd-1.3-rfa", "vdd-3.3-ch0",
-			   and "vdd-3.3-ch1".
+			   "vdd-3.3-ch1" and "vdd-smps".
 - memory-region:
 	Usage: optional
 	Value type: <phandle>