diff mbox series

[7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it

Message ID 20230226053953.4681-8-rdunlap@infradead.org
State New
Headers
Series drivers: select REGMAP instead of depending on it |

Commit Message

Randy Dunlap Feb. 26, 2023, 5:39 a.m. UTC 
  REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.

Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.

Therefore, change the use of "depends on REGMAP" to "select REGMAP".

Fixes: b474303ffd57 ("thermal: add Intel BXT WhiskeyCove PMIC thermal driver")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
Cc: Bin Gao <bin.gao@intel.com>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Rafael J. Wysocki <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Amit Kucheria <amitk@kernel.org>
Cc: linux-pm@vger.kernel.org
---
 drivers/thermal/intel/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Rafael J. Wysocki March 1, 2023, 6:34 p.m. UTC | #1 
On Sun, Feb 26, 2023 at 6:40 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> Therefore, change the use of "depends on REGMAP" to "select REGMAP".
>
> Fixes: b474303ffd57 ("thermal: add Intel BXT WhiskeyCove PMIC thermal driver")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Yegnesh S Iyer <yegnesh.s.iyer@intel.com>
> Cc: Bin Gao <bin.gao@intel.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: Rafael J. Wysocki <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Amit Kucheria <amitk@kernel.org>
> Cc: linux-pm@vger.kernel.org
> ---
>  drivers/thermal/intel/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -- a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
> --- a/drivers/thermal/intel/Kconfig
> +++ b/drivers/thermal/intel/Kconfig
> @@ -73,7 +73,8 @@ endmenu
>
>  config INTEL_BXT_PMIC_THERMAL
>         tristate "Intel Broxton PMIC thermal driver"
> -       depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
> +       depends on X86 && INTEL_SOC_PMIC_BXTWC
> +       select REGMAP
>         help
>           Select this driver for Intel Broxton PMIC with ADC channels monitoring
>           system temperature measurements and alerts.

Applied as 6.3-rc material, thanks!
diff mbox series

Patch

diff -- a/drivers/thermal/intel/Kconfig b/drivers/thermal/intel/Kconfig
--- a/drivers/thermal/intel/Kconfig
+++ b/drivers/thermal/intel/Kconfig
@@ -73,7 +73,8 @@  endmenu
 
 config INTEL_BXT_PMIC_THERMAL
 	tristate "Intel Broxton PMIC thermal driver"
-	depends on X86 && INTEL_SOC_PMIC_BXTWC && REGMAP
+	depends on X86 && INTEL_SOC_PMIC_BXTWC
+	select REGMAP
 	help
 	  Select this driver for Intel Broxton PMIC with ADC channels monitoring
 	  system temperature measurements and alerts.