| Message ID | 20221024220015.1759428-4-nfraprado@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp708076wru;
Mon, 24 Oct 2022 16:46:46 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM7XuBOl7HcfirAnhsTFxzf6O/KCVsql2gFPQoXMFuj1yphKchE8K+7ZzZUhjwftcb0aC5Nu
X-Received: by 2002:a17:90a:5386:b0:212:fbbb:ec6c with SMTP id
y6-20020a17090a538600b00212fbbbec6cmr11744987pjh.101.1666655206480;
Mon, 24 Oct 2022 16:46:46 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666655206; cv=none;
d=google.com; s=arc-20160816;
b=mYiGC9RLR61Agem+nIAbXXrEFc/mqHV9oHh0UYq1kYG8Nv+u17rPaofQQjcGE177IG
QOZz6Epfed+dLe809dd9o4J97OaFTIHexQBm1PtRCafoAyePt/QfhJpNRgCEUh9odouV
RQ7jYfX7vBXerTjbynYU5CFzBCIdkeEa2SHvdx163W+FvzrXfuNYvMB3ezcRLYze18lY
1+jbW5z5kjDQCh1lzSbByZViAouRAaIuF/RPouszuT0BLCc/5wLMr/RqardQgJjHisn4
i4VL/ipTdU4vkZtepDs9wU2x/Qu4SRomC81TXfmRy5FH/4nzbEGgI/ROXw9T7Xw2UZ2b
o3pA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=NWWBP2SmEWTSNzXWwdTT0bevJm8OZZN/Luz+9cwmoKg=;
b=nHrBLLlKFWZQpsdKITqAxStEyoJGOgcPH507uc60NtFaH8C4h2Y/Ftaz3t+ns+RwW6
9M+uiw27msRFdYO9gfz7Oe5HtW1PySHU3wXtx47ADEoBZMSRbEvY2h5ebP3AUfsSfyev
B1wNEaz0kevBL9zGD07tUXsTIMeOT+SjDH+GTMgGsseg4w80N56h/aPRetWixFWCYQsq
6yrlHuM6NWM6VXlEIFH7D+T7Tt21kNCOgrCUAfIHk8ar0fHNNQ3uR0lccC3blEvnXgv4
TE1BVHLrVdDmeq+wmR9YhafQPaWtqLqlD3+IxuNzInzw/p8Ubp22WpnQkSl74dOU5yvk
tIlQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=GGQxoeeu;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
me1-20020a17090b17c100b001fe2de6a2c9si1799984pjb.4.2022.10.24.16.46.32;
Mon, 24 Oct 2022 16:46:46 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=GGQxoeeu;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229864AbiJXXlz (ORCPT <rfc822;pwkd43@gmail.com> + 99 others);
Mon, 24 Oct 2022 19:41:55 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53564 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229744AbiJXXlb (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 24 Oct 2022 19:41:31 -0400
Received: from madras.collabora.co.uk (madras.collabora.co.uk
[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E9D2F70EF;
Mon, 24 Oct 2022 15:00:32 -0700 (PDT)
Received: from notapiano.myfiosgateway.com (unknown [194.36.25.51])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: nfraprado)
by madras.collabora.co.uk (Postfix) with ESMTPSA id C0E496602820;
Mon, 24 Oct 2022 23:00:27 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1666648829;
bh=yUOJmnlfdy5bC2kZgeZWbD0yF667HQA6aNkS15dlW6A=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=GGQxoeeulNxtBsMzpjtPmZyyGa4mApgfpXJiUxsfMh8TjJFkSpE1FpW0wUBr6Xt69
3gZ3eY1j7ub80kQgEWBC//c94Ojomkwy0PVU7EunnRhexxGD5C68E3yef5fuLeG5+W
srwyYfZg/MDqcf/2gs+731jRqJcm36f6Oe5mvY8Vj+4xATnTwllLTzUrmFRH1nhgZW
/ayYlLCZnCnYFH/5rRLq/DuIf6ymFrcIX7SOLb5wcKmT7L1rsqsLZOp8GCkLqEqyNB
pWfoMJYYX/XUuFsMt5mzA9BLAvt9JnDJkiM/AB07acH6xEKJ9fWEcKeIn+OGZ1rLwL
14iQFRP4iIGqQ==
From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>
To: Mark Brown <broonie@kernel.org>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>,
kernel@collabora.com,
=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/4] ASoC: dt-bindings: rt5682: Set sound-dai-cells to 1
Date: Mon, 24 Oct 2022 18:00:14 -0400
Message-Id: <20221024220015.1759428-4-nfraprado@collabora.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221024220015.1759428-1-nfraprado@collabora.com>
References: <20221024220015.1759428-1-nfraprado@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747614650202539863?=
X-GMAIL-MSGID: =?utf-8?q?1747614650202539863?=
|
| Series |
Add missing dt-binding properties to rt5682(s)
|
|
Commit Message
Nícolas F. R. A. Prado
Oct. 24, 2022, 10 p.m. UTC
Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
defined the sound-dai-cells property as 0. However, rt5682 has two DAIs,
AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix
it.
Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells")
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Changes in v2:
- Added this commit
Documentation/devicetree/bindings/sound/rt5682.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Il 25/10/22 00:00, Nícolas F. R. A. Prado ha scritto: > Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, > AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix > it. > > Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On 24/10/2022 18:00, Nícolas F. R. A. Prado wrote: > Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, > AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix > it. > > Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Mon, Oct 24, 2022 at 3:02 PM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > Commit 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > defined the sound-dai-cells property as 0. However, rt5682 has two DAIs, > AIF1 and AIF2, and therefore should have sound-dai-cells set to 1. Fix > it. > > Fixes: 0adccaf1eac9 ("ASoC: dt-bindings: rt5682: Add #sound-dai-cells") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt index c5f2b8febcee..6b87db68337c 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -46,7 +46,7 @@ Optional properties: - realtek,dmic-clk-driving-high : Set the high driving of the DMIC clock out. -- #sound-dai-cells: Should be set to '<0>'. +- #sound-dai-cells: Should be set to '<1>'. Pins on the device (for linking into audio routes) for RT5682: