| Message ID | 20230211063257.311746-2-srinivas.pandruvada@linux.intel.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1362170wrn;
Fri, 10 Feb 2023 22:34:03 -0800 (PST)
X-Google-Smtp-Source:
AK7set96xl5bDM7ntd5qBOuCzMIOltZiJRotXLgRzBIF0cV7Cy7Ch58JP6biNhBeJinoo/xW54QG
X-Received: by 2002:a17:906:860a:b0:879:9c06:c8bc with SMTP id
o10-20020a170906860a00b008799c06c8bcmr13567730ejx.15.1676097243095;
Fri, 10 Feb 2023 22:34:03 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1676097243; cv=none;
d=google.com; s=arc-20160816;
b=n89HZ/FwG+nSmAqSplKHXvRMfXzQFCieNlf+oI46IBFbXTqhtjU0Law0OkTqCh8SrF
MEBy2DsVVTTgkFsqrSxSyErM++GY6ZXnOcyZAgvYkTPfTXsMXRtDSDVA61ddyfYNvSq7
D8pJmq0duH/f2SxIYfG85UyW7j4mwb8h+wmChpn8xRMmEv+FQMxC1biF3J+ju5EkHzuO
PI9+ogiUOZ68yg4DBs63oc3s39enz74XOpQO0XmLDV2iDLip7O+i7AR0yJYx10TpCGx1
OmQ8OdoOc4rU4SHQlhmT1H7cXrWnoWTlnKVQNHmb+ivhNdu3+p8r4W7XCNl9CLXKLwxs
6n9A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=C0fx9Xtg4BDnpLDdv0WeA2zWj1Nw5P77Ub3WaXoeaVQ=;
b=M5ib8JJwd1tnTRT7NXiiTz4GAHcf4focS+qx32RVz5pykmtqlo5DqguaMbq1z98LY3
6RSTRGg89L09vwfwnC28+IYMOLRpHeavZRaPKyMdgljrFPoBID9EUYnxgps6CaWJeNv+
GZH3dhd9TEC/4HoDx+fVTCAd/Ym9z0ETfueUkVsr3NxLcvMipToIwcXnbhCDfebGQE6W
FV9Fto2bALFNTIlJ5k89V7U+fnMlBXL6+j3xreHcT9eWWwjbxZP6+f7sZzsb4pBpc3y3
jJLXF/NzKsOXlcEEhtIa/b6NsGxCkajvacUG+tA9kjhXGx8KohltEvIvpTcWPp76ojPs
0cJA==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=YMVX+3+r;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
wg12-20020a1709078f0c00b00897a440d85asi6803089ejc.615.2023.02.10.22.33.40;
Fri, 10 Feb 2023 22:34:03 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@intel.com header.s=Intel header.b=YMVX+3+r;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229609AbjBKGdM (ORCPT <rfc822;ybw1215001957@gmail.com>
+ 99 others); Sat, 11 Feb 2023 01:33:12 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39460 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229585AbjBKGdJ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 11 Feb 2023 01:33:09 -0500
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6256A7BFD6;
Fri, 10 Feb 2023 22:33:01 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1676097181; x=1707633181;
h=from:to:cc:subject:date:message-id:in-reply-to:
references:mime-version:content-transfer-encoding;
bh=7i8zMF0K839+UX0WmEQKEd/eIgzkZJvjyjtd/qQGye0=;
b=YMVX+3+r3JqtYDns8ewpeLR5rTAMcpjpSkqN/JPIZXkI4hm+Sqwr8TY3
cFbaZ57DCVSvztuHxFshFodaHwua89vyav9oYcGZwqGJ4tXXMexzxQOTS
Ha3nREwTE3wrGX5MnBBaSoqdcJ/txAdJE9z13JRfyTFPHQW2fQI0s4frc
CUXCrV8griac5c49y0oYiTnelnU9UsMlI5g/voqPqOZbZfz2g8kT9wbtL
KPIlSpIT1ZTufYeEVEpQHQz6ey881/gkF45bDkjFuOknk9AVB67WX/1Mi
F2cVz7KPzk7zSl2zdDElGh5+PWk22+hmD1eM+4s6+xXL9PHshhKkPzd31
A==;
X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="310223195"
X-IronPort-AV: E=Sophos;i="5.97,289,1669104000";
d="scan'208";a="310223195"
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
10 Feb 2023 22:33:00 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=McAfee;i="6500,9779,10617"; a="997171761"
X-IronPort-AV: E=Sophos;i="5.97,289,1669104000";
d="scan'208";a="997171761"
Received: from spandruv-desk.jf.intel.com ([10.54.75.8])
by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2023 22:33:00 -0800
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: hdegoede@redhat.com, markgross@kernel.org
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH 01/12] platform/x86: ISST: Fix kernel documentation warnings
Date: Fri, 10 Feb 2023 22:32:46 -0800
Message-Id: <20230211063257.311746-2-srinivas.pandruvada@linux.intel.com>
X-Mailer: git-send-email 2.39.1
In-Reply-To: <20230211063257.311746-1-srinivas.pandruvada@linux.intel.com>
References: <20230211063257.311746-1-srinivas.pandruvada@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757515342607023925?=
X-GMAIL-MSGID: =?utf-8?q?1757515342607023925?=
|
| Series |
platform/x86: ISST: Use TPMI interface
|
|
Commit Message
srinivas pandruvada
Feb. 11, 2023, 6:32 a.m. UTC
Fix warning displayed for "make W=1" for kernel documentation.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 3 ++-
drivers/platform/x86/intel/speed_select_if/isst_if_common.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
Comments
Hi, On 2/11/23 07:32, Srinivas Pandruvada wrote: > Fix warning displayed for "make W=1" for kernel documentation. > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Thanks, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I'll rebase that branch once 6.3-rc1 is out and then push the rebased patch to the fixes branch and include it in my next 6.3 fixes pull-req to Linus. Regards, Hans > --- > drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 3 ++- > drivers/platform/x86/intel/speed_select_if/isst_if_common.h | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c > index a7e02b24a87a..63d49fe17a16 100644 > --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c > +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c > @@ -112,6 +112,7 @@ static void isst_delete_hash(void) > * isst_store_cmd() - Store command to a hash table > * @cmd: Mailbox command. > * @sub_cmd: Mailbox sub-command or MSR id. > + * @cpu: Target CPU for the command > * @mbox_cmd_type: Mailbox or MSR command. > * @param: Mailbox parameter. > * @data: Mailbox request data or MSR data. > @@ -363,7 +364,7 @@ static struct pci_dev *_isst_if_get_pci_dev(int cpu, int bus_no, int dev, int fn > /** > * isst_if_get_pci_dev() - Get the PCI device instance for a CPU > * @cpu: Logical CPU number. > - * @bus_number: The bus number assigned by the hardware. > + * @bus_no: The bus number assigned by the hardware. > * @dev: The device number assigned by the hardware. > * @fn: The function number assigned by the hardware. > * > diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h > index fdecdae248d7..35ff506b402e 100644 > --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h > +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h > @@ -40,6 +40,7 @@ > * @offset: Offset to the first valid member in command structure. > * This will be the offset of the start of the command > * after command count field > + * @owner: Registered module owner > * @cmd_callback: Callback function to handle IOCTL. The callback has the > * command pointer with data for command. There is a pointer > * called write_only, which when set, will not copy the
Hi Hans, Since some patches you are adding to your review branch, shall I exclude those from new series by rebasing on your review-hans branch? ? Thanks, Srinivas On Wed, 2023-03-01 at 15:23 +0100, Hans de Goede wrote: > Hi, > > On 2/11/23 07:32, Srinivas Pandruvada wrote: > > Fix warning displayed for "make W=1" for kernel documentation. > > > > Signed-off-by: Srinivas Pandruvada > > <srinivas.pandruvada@linux.intel.com> > > Thanks, I've applied this patch to my review-hans branch: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > > I'll rebase that branch once 6.3-rc1 is out and then push the rebased > patch to the fixes branch and include it in my next 6.3 fixes pull- > req > to Linus. > > Regards, > > Hans > > > > > > > --- > > drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 3 > > ++- > > drivers/platform/x86/intel/speed_select_if/isst_if_common.h | 1 + > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git > > a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c > > b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c > > index a7e02b24a87a..63d49fe17a16 100644 > > --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c > > +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c > > @@ -112,6 +112,7 @@ static void isst_delete_hash(void) > > * isst_store_cmd() - Store command to a hash table > > * @cmd: Mailbox command. > > * @sub_cmd: Mailbox sub-command or MSR id. > > + * @cpu: Target CPU for the command > > * @mbox_cmd_type: Mailbox or MSR command. > > * @param: Mailbox parameter. > > * @data: Mailbox request data or MSR data. > > @@ -363,7 +364,7 @@ static struct pci_dev *_isst_if_get_pci_dev(int > > cpu, int bus_no, int dev, int fn > > /** > > * isst_if_get_pci_dev() - Get the PCI device instance for a CPU > > * @cpu: Logical CPU number. > > - * @bus_number: The bus number assigned by the hardware. > > + * @bus_no: The bus number assigned by the hardware. > > * @dev: The device number assigned by the hardware. > > * @fn: The function number assigned by the hardware. > > * > > diff --git > > a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h > > b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h > > index fdecdae248d7..35ff506b402e 100644 > > --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h > > +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h > > @@ -40,6 +40,7 @@ > > * @offset: Offset to the first valid member in command > > structure. > > * This will be the offset of the start of the command > > * after command count field > > + * @owner: Registered module owner > > * @cmd_callback: Callback function to handle IOCTL. The callback > > has the > > * command pointer with data for command. There is a > > pointer > > * called write_only, which when set, will not copy > > the >
Hi, On 3/1/23 15:48, srinivas pandruvada wrote: > Hi Hans, > > Since some patches you are adding to your review branch, > shall I exclude those from new series by rebasing on > your review-hans branch? > ? Yes please rebase on my review-hans branch. Regards, Hans > On Wed, 2023-03-01 at 15:23 +0100, Hans de Goede wrote: >> Hi, >> >> On 2/11/23 07:32, Srinivas Pandruvada wrote: >>> Fix warning displayed for "make W=1" for kernel documentation. >>> >>> Signed-off-by: Srinivas Pandruvada >>> <srinivas.pandruvada@linux.intel.com> >> >> Thanks, I've applied this patch to my review-hans branch: >> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans >> >> I'll rebase that branch once 6.3-rc1 is out and then push the rebased >> patch to the fixes branch and include it in my next 6.3 fixes pull- >> req >> to Linus. >> >> Regards, >> >> Hans >> >> >> >> >> >>> --- >>> drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 3 >>> ++- >>> drivers/platform/x86/intel/speed_select_if/isst_if_common.h | 1 + >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git >>> a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c >>> b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c >>> index a7e02b24a87a..63d49fe17a16 100644 >>> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c >>> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c >>> @@ -112,6 +112,7 @@ static void isst_delete_hash(void) >>> * isst_store_cmd() - Store command to a hash table >>> * @cmd: Mailbox command. >>> * @sub_cmd: Mailbox sub-command or MSR id. >>> + * @cpu: Target CPU for the command >>> * @mbox_cmd_type: Mailbox or MSR command. >>> * @param: Mailbox parameter. >>> * @data: Mailbox request data or MSR data. >>> @@ -363,7 +364,7 @@ static struct pci_dev *_isst_if_get_pci_dev(int >>> cpu, int bus_no, int dev, int fn >>> /** >>> * isst_if_get_pci_dev() - Get the PCI device instance for a CPU >>> * @cpu: Logical CPU number. >>> - * @bus_number: The bus number assigned by the hardware. >>> + * @bus_no: The bus number assigned by the hardware. >>> * @dev: The device number assigned by the hardware. >>> * @fn: The function number assigned by the hardware. >>> * >>> diff --git >>> a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h >>> b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h >>> index fdecdae248d7..35ff506b402e 100644 >>> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h >>> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h >>> @@ -40,6 +40,7 @@ >>> * @offset: Offset to the first valid member in command >>> structure. >>> * This will be the offset of the start of the command >>> * after command count field >>> + * @owner: Registered module owner >>> * @cmd_callback: Callback function to handle IOCTL. The callback >>> has the >>> * command pointer with data for command. There is a >>> pointer >>> * called write_only, which when set, will not copy >>> the >> >
diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c index a7e02b24a87a..63d49fe17a16 100644 --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c @@ -112,6 +112,7 @@ static void isst_delete_hash(void) * isst_store_cmd() - Store command to a hash table * @cmd: Mailbox command. * @sub_cmd: Mailbox sub-command or MSR id. + * @cpu: Target CPU for the command * @mbox_cmd_type: Mailbox or MSR command. * @param: Mailbox parameter. * @data: Mailbox request data or MSR data. @@ -363,7 +364,7 @@ static struct pci_dev *_isst_if_get_pci_dev(int cpu, int bus_no, int dev, int fn /** * isst_if_get_pci_dev() - Get the PCI device instance for a CPU * @cpu: Logical CPU number. - * @bus_number: The bus number assigned by the hardware. + * @bus_no: The bus number assigned by the hardware. * @dev: The device number assigned by the hardware. * @fn: The function number assigned by the hardware. * diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h index fdecdae248d7..35ff506b402e 100644 --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.h +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.h @@ -40,6 +40,7 @@ * @offset: Offset to the first valid member in command structure. * This will be the offset of the start of the command * after command count field + * @owner: Registered module owner * @cmd_callback: Callback function to handle IOCTL. The callback has the * command pointer with data for command. There is a pointer * called write_only, which when set, will not copy the