| Message ID | 20230226053953.4681-5-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1809548wrd;
Sat, 25 Feb 2023 21:41:52 -0800 (PST)
X-Google-Smtp-Source:
AK7set8TLvzjNw/e8D1tKfdI4QZSzvBqYdpooAWJIOu9hpDaswz4FrT7Gxq+7HjlqUUdj7k8z+V8
X-Received: by 2002:a17:902:f907:b0:19c:dc14:ea6b with SMTP id
kw7-20020a170902f90700b0019cdc14ea6bmr6081735plb.63.1677390112289;
Sat, 25 Feb 2023 21:41:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677390112; cv=none;
d=google.com; s=arc-20160816;
b=XNIl6ioOyHdq9pVSpRacgLcHj9lz/TztsH4/viOSunYHmTwB7otLXGNef1U6UbK7Gv
+9BktsutCULjnrDuo6gpqABDGxw1bLd4TwuRcZ4tYo4GqKMHs2C1eenspgoC4Bjb7xE5
mmXNH31gR7d0sAYO/6yHhGupkpfpfzJqySCncnrBLfDGfSpOBdcFD+dOsNJf4pZ8WByG
6RC6qyYw+hYMSFPWCxD+g8uzFamMalkLVcTDmFrLsjPYpfjD2ROnujAlnFeWGqj4jwkU
wDF5FgErnLjTrEdks0EaShFChgsiuDqy37eBdC0dPtYQrt6kjBaG9gZrm6CkQ5IGYqqQ
MDCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=jZDKgKykgJivmPlxfhgmYfxwzNIu4E7QMWQ1piQj3M0=;
b=WaPfksBBxUhuvoOiD2Oe9bTL8SQCmmiYflzJURJgLfahTvTyqNzhV4D3ZmGkGTWRvl
hvIia4MvTlWd42KQ9egAasrRt02tmHF9lSRu3K3xEwboXbG09QKW6B/7fvQVSAw+egZ2
ycx71NEz9ZVSkGzQ6EEYYWNMaNmBW5L+/KdYrj2vkpgue+6gICqWypOVW+w/w7iIfhee
VEhgIUwXknbmT+/msb1env9oxng9PmwlGocy4JXYYQIb/BpIei84+Lsvz3IIES3xE4eJ
iNiijMx87GWH+rCrWQReqtYxcpWIwYtJ5lLEcSj12+pbsvprtQb40U62HiWPKYIgVfQP
Z/AQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=GjLoAa0R;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
kh6-20020a170903064600b001965a0fc34fsi3293901plb.139.2023.02.25.21.41.39;
Sat, 25 Feb 2023 21:41:52 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=GjLoAa0R;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229667AbjBZFkD (ORCPT <rfc822;guoshuai5156@gmail.com>
+ 99 others); Sun, 26 Feb 2023 00:40:03 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56642 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229558AbjBZFj6 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sun, 26 Feb 2023 00:39:58 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org
[IPv6:2607:7c80:54:3::133])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51077136EB;
Sat, 25 Feb 2023 21:39:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender
:Reply-To:Content-Type:Content-ID:Content-Description;
bh=jZDKgKykgJivmPlxfhgmYfxwzNIu4E7QMWQ1piQj3M0=;
b=GjLoAa0RZXwFgvWheSIzYKnhB2
5q247ieUuUeaZQJRGP6uSVuJ0z+MR23HQ4AKgtll3atMiQzrt0MGLRewIVUp/N+87gq5CwD5t+CSZ
SPzwJhki1nja2wyo1c1I/nYfYtcLDPzqhT2b7FzrOjtSthNTPYq205C7Lm/duIFaCs0CVMpj73kb6
a85pW3FGbjy1bQzW/9yY4edwPCKDval1gWADrnVnXeRG/JdtO7fC+ROpPvIfVpN6p3l4TFmdqiPIF
AlVSY+I/EhretKFUVykVXdHyUXM5uftacbK70mIIHV8oleNfV5WrnmVTalSFof4UHvFbUsKyW2e66
H4tn0zvQ==;
Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat
Linux))
id 1pW9lM-006qYL-CI; Sun, 26 Feb 2023 05:39:56 +0000
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>, Dan Murphy <dmurphy@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org
Subject: [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending
on it
Date: Sat, 25 Feb 2023 21:39:49 -0800
Message-Id: <20230226053953.4681-5-rdunlap@infradead.org>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230226053953.4681-1-rdunlap@infradead.org>
References: <20230226053953.4681-1-rdunlap@infradead.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1758871014698519701?=
X-GMAIL-MSGID: =?utf-8?q?1758871014698519701?=
|
| Series |
drivers: select REGMAP instead of depending on it
|
|
Commit Message
Randy Dunlap
Feb. 26, 2023, 5:39 a.m. UTC
REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
Therefore, change the use of "depends on REGMAP" to "select REGMAP".
Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dan Murphy <dmurphy@ti.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc: Lee Jones <lee@kernel.org>
Cc: linux-leds@vger.kernel.org
---
drivers/leds/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat 2023-02-25 21:39:49, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Dan Murphy <dmurphy@ti.com> Acked-by: Pavel Machek <pavel@ucw.cz> Best regards, Pavel
On Sat, 25 Feb 2023, Randy Dunlap wrote: > REGMAP is a hidden (not user visible) symbol. Users cannot set it > directly thru "make *config", so drivers should select it instead of > depending on it if they need it. > > Consistently using "select" or "depends on" can also help reduce > Kconfig circular dependency issues. > > Therefore, change the use of "depends on REGMAP" to "select REGMAP". > > Fixes: 3fce8e1eb994 ("leds: TI LMU: Add common code for TI LMU devices") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Dan Murphy <dmurphy@ti.com> > Cc: Pavel Machek <pavel@ucw.cz> > Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Lee Jones <lee@kernel.org> > Cc: linux-leds@vger.kernel.org > --- > drivers/leds/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks
diff -- a/drivers/leds/Kconfig b/drivers/leds/Kconfig --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -795,7 +795,7 @@ config LEDS_SPI_BYTE config LEDS_TI_LMU_COMMON tristate "LED driver for TI LMU" depends on LEDS_CLASS - depends on REGMAP + select REGMAP help Say Y to enable the LED driver for TI LMU devices. This supports common features between the TI LM3532, LM3631, LM3632,