diff mbox series

[2/2] testsuite: Fix analyzer errors for newlib-fd

Message ID 20230228184958.4992D20438@pchp3.se.axis.com
State Repeat Merge
Headers
Series [1/2] testsuite: Fix analyzer errors for newlib-errno |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Hans-Peter Nilsson Feb. 28, 2023, 6:49 p.m. UTC 
  Ok to commit?  (After this, there's
gcc.dg/analyzer/flex-without-call-summaries.c left to do.)

-- >8 --
Investigating analyzer testsuite errors for cris-elf.  The same are
seen for pru-elf according to posts to gcc-testresults@.

The test fd-access-mode-target-headers.c uses the analyzer
"sm-fd" which for this use requires (e.g.) that constants
O_ACCMODE, O_RDONLY and O_WRONLY are defined as literal
constants.  While for glibc, O_ACCMODE is defined as:
 #define O_ACCMODE 0003
in newlib, it's defined as:
 #define O_ACCMODE (O_RDONLY|O_WRONLY|O_RDWR)
and the analyzer is not able to make use of an expression
like this (even though O_RDONLY, O_WRONLY and O_RDWR are
defined as literal constants and the whole evaluates to 3).
Better do as for AIX and skip this test.

testsuite:
	* gcc.dg/analyzer/fd-access-mode-target-headers.c: Skip for
	newlib targets too.
---
 gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Malcolm Feb. 28, 2023, 7:13 p.m. UTC | #1 
On Tue, 2023-02-28 at 19:49 +0100, Hans-Peter Nilsson wrote:
> Ok to commit? 

OK
diff mbox series

Patch

diff --git a/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c b/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c
index 847d47e06342..cf273b217d17 100644
--- a/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c
+++ b/gcc/testsuite/gcc.dg/analyzer/fd-access-mode-target-headers.c
@@ -1,4 +1,4 @@ 
-/* { dg-skip-if "" { powerpc*-*-aix* } } */
+/* { dg-skip-if "" { powerpc*-*-aix* || newlib } } */
 
 #include <sys/stat.h>
 #include <fcntl.h>