| Message ID | 20230227130535.2828181-1-trix@redhat.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp2405598wrd;
Mon, 27 Feb 2023 05:10:15 -0800 (PST)
X-Google-Smtp-Source:
AK7set8/+zaQjiaDHSmO1ceXdpDs2eaGBLMNh/RwwafkJElTggkNugj2vPSXhLw0huOcRWL4No5+
X-Received: by 2002:a17:90b:1806:b0:234:eeb:8df4 with SMTP id
lw6-20020a17090b180600b002340eeb8df4mr26489679pjb.14.1677503414748;
Mon, 27 Feb 2023 05:10:14 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677503414; cv=none;
d=google.com; s=arc-20160816;
b=LKtm5nFa1Wt3BW6q7ZHn5J6+ilbKpzPCVLsoDtN9/kc780/cAZwQdt9rel/hPTMKOH
WCjjARgCyZhK5k2jxZUqLBGM+WsvW5+NvUykcuqhej9SPdxVS+TfBbbiA6XN7F9EfqEt
y0oQyNXgEhzK2Ui6kQP9ssIcCSO9qp08s1feC5r3bWZSrQrkIpBY4lKjX9iesMb8Lh94
A1Idw/aVyopIUl/uWVXxgNe2Ejo9IZOnde/wbUC/A1jKkGCIgZDX6O5KH3YT5WYSShOP
UmD6to2hk2fqaoUgX7Q/REmwOS2ktwUK1ZDWfIEioRTsC6Jom3WkT+QYluK2ZwX5sl8Y
lcNA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=Q92sQcBkpoH/Y89DMN/b2PnZ1a4R3LQUabxaooE41f4=;
b=0SqsLCFP2jbf1CPE6NXNZeqPxcEB9SqudknWZ+qeBG7LQZLgmhGvTlrvwtTQB1mc2S
Mw3pwXKwG8zBPGYiXSL9y4fMlVa7yK87VmVVHnGr4JLaQkNo+wgxCbq+z/HMF0YFW/NT
FyuosA+jXTrgBoWvNvA/E8WIDnE5dj0YyIShsBN5fPnIku5nkIcgsrm5dfDIxeWD8wXw
VOJAQ/alNqmmGYWGc790VFBtH3JgDJZ22iHyjYq3sY9WCIaNtJMBwMsDLsdZKjcoK2Yj
i0lHJpu0updyTDzsM1s9aeksAyFfUtzYVTh5dedHxPtUSSq+nPUQcE8mabNl5rdy6b+q
xOMQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=Cve3AzZt;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
jx6-20020a17090b46c600b0022645e2a88csi7272831pjb.56.2023.02.27.05.10.01;
Mon, 27 Feb 2023 05:10:14 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=Cve3AzZt;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229917AbjB0NGl (ORCPT <rfc822;wenzhi022@gmail.com> + 99 others);
Mon, 27 Feb 2023 08:06:41 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43544 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229759AbjB0NGk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 27 Feb 2023 08:06:40 -0500
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A93431E5EB
for <linux-kernel@vger.kernel.org>;
Mon, 27 Feb 2023 05:05:50 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1677503149;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=Q92sQcBkpoH/Y89DMN/b2PnZ1a4R3LQUabxaooE41f4=;
b=Cve3AzZt/JXYEOQ3/uHWJz5rOGGi3ViP/6YMw9lDLxksNO9znxhCKatEh+/CX+f6bsb5Xy
6DBkJYZG1EA5igJM9j0v03HMXRNoN9W/OwzvI8fJ2X4gA7XrYjj9zlBodrde3nwh7CyOtr
Yst0sh82rHWEdyTixjkicrMbRoJ5z60=
Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com
[209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
us-mta-484-LyQOOrGsNRi3G5UrEFr9nA-1; Mon, 27 Feb 2023 08:05:48 -0500
X-MC-Unique: LyQOOrGsNRi3G5UrEFr9nA-1
Received: by mail-qk1-f197.google.com with SMTP id
c13-20020a05620a0ced00b007422bf7c4aeso4022500qkj.0
for <linux-kernel@vger.kernel.org>;
Mon, 27 Feb 2023 05:05:48 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=Q92sQcBkpoH/Y89DMN/b2PnZ1a4R3LQUabxaooE41f4=;
b=xvadd5ZrSIRvL1LPekeXDaPw8CUMF2a4WHdkr61Losz0ta8R8poxntmneT0XEqD/ne
hN1uP8FYuEyPUnYo7Sr0D4+kfANEESLMMxRJjPHmmuFLV9AGvF5IZfwvrNWSvgPhH+mS
hA1FdQw+BNQf0EpASTPsl7/dBjgZtb9VDG9LbAIRYD2VVrwAwypKcISFIJwXzDSVRecs
V914k3QlQl7dDk/tPpCNDqeXJA78ziFcqLr1rEAbcX2ORWjGAtI/Xu9zywmkUuEVqKGV
EiIi4DlYRZcYrz5NC9Q0PJg/N7bB8+mmZ6zlwJjr/+EVAM8spGLjZlVI6sViYg5qulNZ
zQaw==
X-Gm-Message-State: AO0yUKWyl/oB3rj/AdGAmvv8vNmW1ozhXqt0kRZGQXamEZ8iICdnyDIc
IfnxRi8xD8CjncgyhiQlsMhOquhhOsQNC3o0FNpzMjLHULRRpcXC1veqZGThOq+C3i+uOpkLFoE
VUkDaGKtzWpf8XatCDcJ3llVM
X-Received: by 2002:a05:622a:198d:b0:3ba:1c07:e472 with SMTP id
u13-20020a05622a198d00b003ba1c07e472mr31833336qtc.51.1677503148160;
Mon, 27 Feb 2023 05:05:48 -0800 (PST)
X-Received: by 2002:a05:622a:198d:b0:3ba:1c07:e472 with SMTP id
u13-20020a05622a198d00b003ba1c07e472mr31833272qtc.51.1677503147482;
Mon, 27 Feb 2023 05:05:47 -0800 (PST)
Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com
(nat-pool-bos-t.redhat.com. [66.187.233.206])
by smtp.gmail.com with ESMTPSA id
t136-20020a37aa8e000000b0073b967b9b35sm4830749qke.106.2023.02.27.05.05.45
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 27 Feb 2023 05:05:46 -0800 (PST)
From: Tom Rix <trix@redhat.com>
To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, steen.hegelund@microchip.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Rix <trix@redhat.com>
Subject: [PATCH v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a link
error
Date: Mon, 27 Feb 2023 08:05:35 -0500
Message-Id: <20230227130535.2828181-1-trix@redhat.com>
X-Mailer: git-send-email 2.27.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1758989820461725128?=
X-GMAIL-MSGID: =?utf-8?q?1758989820461725128?=
|
| Series |
[v2] net: lan743x: LAN743X selects FIXED_PHY to resolve a link error
|
|
Commit Message
Tom Rix
Feb. 27, 2023, 1:05 p.m. UTC
A rand config causes this link error
drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open':
drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register'
lan743x_netdev_open is controlled by LAN743X
fixed_phy_register is controlled by FIXED_PHY
and the error happens when
CONFIG_LAN743X=y
CONFIG_FIXED_PHY=m
So LAN743X should also select FIXED_PHY
Signed-off-by: Tom Rix <trix@redhat.com>
---
v2: Add config setting that trigger the error to commit log
---
drivers/net/ethernet/microchip/Kconfig | 1 +
1 file changed, 1 insertion(+)
Comments
Hello, On Mon, 2023-02-27 at 08:05 -0500, Tom Rix wrote: > A rand config causes this link error > drivers/net/ethernet/microchip/lan743x_main.o: In function `lan743x_netdev_open': > drivers/net/ethernet/microchip/lan743x_main.c:1512: undefined reference to `fixed_phy_register' > > lan743x_netdev_open is controlled by LAN743X > fixed_phy_register is controlled by FIXED_PHY > > and the error happens when > CONFIG_LAN743X=y > CONFIG_FIXED_PHY=m > > So LAN743X should also select FIXED_PHY > > Signed-off-by: Tom Rix <trix@redhat.com> You are targeting the -net tree, but this lacks a 'Fixes' tag, please post a new version with such info. If instead the intended target was net-next (as I think it was agreed on previous revision) please repost after that net-next re-opens (in ~1w from now). Thanks, Paolo
diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig index 24c994baad13..43ba71e82260 100644 --- a/drivers/net/ethernet/microchip/Kconfig +++ b/drivers/net/ethernet/microchip/Kconfig @@ -47,6 +47,7 @@ config LAN743X depends on PCI depends on PTP_1588_CLOCK_OPTIONAL select PHYLIB + select FIXED_PHY select CRC16 select CRC32 help