diff mbox series

cpuidle: psci: Extend information in log about OSI/PC mode

Message ID 20221020115513.93809-1-ulf.hansson@linaro.org
State New
Headers
Series cpuidle: psci: Extend information in log about OSI/PC mode |

Commit Message

Ulf Hansson Oct. 20, 2022, 11:55 a.m. UTC 
  It's useful to understand whether we are using OS-initiated (OSI) mode or
Platform Coordinated (PC) mode, when initializing the CPU PM domains.
Therefore, let's extend the print in the log after a successful probe with
this information.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Sudeep Holla Oct. 25, 2022, 10:21 a.m. UTC | #1 
On Thu, Oct 20, 2022 at 01:55:13PM +0200, Ulf Hansson wrote:
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>

Looks good to me.

Acked-by: Sudeep Holla <sudeep.holla@arm.com
Dmitry Baryshkov Oct. 25, 2022, 10:23 a.m. UTC | #2 
On 20/10/2022 14:55, Ulf Hansson wrote:
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
> 
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>   drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Acked-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Rafael J. Wysocki Oct. 25, 2022, 1:15 p.m. UTC | #3 
On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> It's useful to understand whether we are using OS-initiated (OSI) mode or
> Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> Therefore, let's extend the print in the log after a successful probe with
> this information.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>  drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> index 821984947ed9..c80cf9ddabd8 100644
> --- a/drivers/cpuidle/cpuidle-psci-domain.c
> +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
>         if (ret)
>                 goto remove_pd;
>
> -       pr_info("Initialized CPU PM domain topology\n");
> +       pr_info("Initialized CPU PM domain topology using %s mode\n",
> +               use_osi ? "OSI" : "PC");
>         return 0;
>
>  put_node:
> --

Am I expected to pick up this one?
Ulf Hansson Oct. 25, 2022, 1:17 p.m. UTC | #4 
On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> >
> > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > Therefore, let's extend the print in the log after a successful probe with
> > this information.
> >
> > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > ---
> >  drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > index 821984947ed9..c80cf9ddabd8 100644
> > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> >         if (ret)
> >                 goto remove_pd;
> >
> > -       pr_info("Initialized CPU PM domain topology\n");
> > +       pr_info("Initialized CPU PM domain topology using %s mode\n",
> > +               use_osi ? "OSI" : "PC");
> >         return 0;
> >
> >  put_node:
> > --
>
> Am I expected to pick up this one?

Yes, please!

Kind regards
Uffe
Rafael J. Wysocki Oct. 28, 2022, 6:09 p.m. UTC | #5 
On Tue, Oct 25, 2022 at 3:18 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Tue, 25 Oct 2022 at 15:16, Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Thu, Oct 20, 2022 at 1:55 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
> > >
> > > It's useful to understand whether we are using OS-initiated (OSI) mode or
> > > Platform Coordinated (PC) mode, when initializing the CPU PM domains.
> > > Therefore, let's extend the print in the log after a successful probe with
> > > this information.
> > >
> > > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> > > ---
> > >  drivers/cpuidle/cpuidle-psci-domain.c | 3 ++-
> > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
> > > index 821984947ed9..c80cf9ddabd8 100644
> > > --- a/drivers/cpuidle/cpuidle-psci-domain.c
> > > +++ b/drivers/cpuidle/cpuidle-psci-domain.c
> > > @@ -181,7 +181,8 @@ static int psci_cpuidle_domain_probe(struct platform_device *pdev)
> > >         if (ret)
> > >                 goto remove_pd;
> > >
> > > -       pr_info("Initialized CPU PM domain topology\n");
> > > +       pr_info("Initialized CPU PM domain topology using %s mode\n",
> > > +               use_osi ? "OSI" : "PC");
> > >         return 0;
> > >
> > >  put_node:
> > > --
> >
> > Am I expected to pick up this one?
>
> Yes, please!

Done, thanks!
diff mbox series

Patch

diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c
index 821984947ed9..c80cf9ddabd8 100644
--- a/drivers/cpuidle/cpuidle-psci-domain.c
+++ b/drivers/cpuidle/cpuidle-psci-domain.c
@@ -181,7 +181,8 @@  static int psci_cpuidle_domain_probe(struct platform_device *pdev)
 	if (ret)
 		goto remove_pd;
 
-	pr_info("Initialized CPU PM domain topology\n");
+	pr_info("Initialized CPU PM domain topology using %s mode\n",
+		use_osi ? "OSI" : "PC");
 	return 0;
 
 put_node: