diff mbox series

[v3,15/20] thermal/hwmon: Use the thermal_core.h header

Message ID	20230226225406.979703-16-daniel.lezcano@linaro.org
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Daniel Lezcano <daniel.lezcano@linaro.org> To: rafael@kernel.org, daniel.lezcano@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>, Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com> Subject: [PATCH v3 15/20] thermal/hwmon: Use the thermal_core.h header Date: Sun, 26 Feb 2023 23:54:01 +0100 Message-Id: <20230226225406.979703-16-daniel.lezcano@linaro.org> In-Reply-To: <20230226225406.979703-1-daniel.lezcano@linaro.org> References: <20230226225406.979703-1-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Self-encapsulate the thermal zone device structure \| [v3,00/20] Self-encapsulate the thermal zone device structure [v3,01/20] thermal/core: Add a thermal zone 'devdata' accessor [v3,02/20] thermal/core: Use the thermal zone 'devdata' accessor in thermal located drivers [v3,03/20] thermal/core: Use the thermal zone 'devdata' accessor in hwmon located drivers [v3,04/20] thermal/core: Use the thermal zone 'devdata' accessor in remaining drivers [v3,05/20] thermal/core: Show a debug message when get_temp() fails [v3,06/20] thermal: Remove debug or error messages in get_temp() ops [v3,07/20] thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs() [v3,08/20] thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs() [v3,09/20] thermal: Don't use 'device' internal thermal zone structure field [v3,10/20] thermal/core: Add thermal_zone_device structure 'type' accessor [v3,11/20] thermal/drivers/spear: Don't use tz->device but pdev->dev [v3,12/20] thermal: Add a thermal zone id accessor [v3,13/20] thermal: Use thermal_zone_device_type() accessor [v3,14/20] thermal/drivers/da9062: Don't access the thermal zone device fields [v3,15/20] thermal/hwmon: Use the thermal_core.h header [v3,16/20] thermal/drivers/tegra: Remove unneeded lock when setting a trip point [v3,17/20] thermal/tegra: Do not enable the thermal zone, it is already enabled [v3,18/20] thermal/drivers/acerhdf: Make interval setting only at module load time [v3,19/20] thermal/drivers/acerhdf: Remove pointless governor test [v3,20/20] thermal/traces: Replace the thermal zone structure parameter with the field value

Commit Message

Daniel Lezcano Feb. 26, 2023, 10:54 p.m. UTC

  The thermal_hwmon is playing with the thermal core code
internals. Changing the code would be too invasive for now.

We can consider the thermal_hwmon.c is part of the thermal core code
as it provides a glue to tie the hwmon and the thermal zones.

Let's include the thermal_core.h header.

No functional change intended.

Cc: Jean Delvare <jdelvare@suse.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/thermal/thermal_hwmon.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jean Delvare Feb. 27, 2023, 2:21 p.m. UTC | #1

On Sun, 26 Feb 2023 23:54:01 +0100, Daniel Lezcano wrote:
> The thermal_hwmon is playing with the thermal core code
> internals. Changing the code would be too invasive for now.
> 
> We can consider the thermal_hwmon.c is part of the thermal core code
> as it provides a glue to tie the hwmon and the thermal zones.
> 
> Let's include the thermal_core.h header.
> 
> No functional change intended.
> 
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/thermal/thermal_hwmon.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
> index bc02095b314c..c59db17dddd6 100644
> --- a/drivers/thermal/thermal_hwmon.c
> +++ b/drivers/thermal/thermal_hwmon.c
> @@ -17,6 +17,7 @@
>  #include <linux/thermal.h>
>  
>  #include "thermal_hwmon.h"
> +#include "thermal_core.h"
>  
>  /* hwmon sys I/F */
>  /* thermal zone devices with the same type share one hwmon device */

Reviewed-by: Jean Delvare <jdelvare@suse.de>

diff mbox series

Patch

diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c
index bc02095b314c..c59db17dddd6 100644
--- a/drivers/thermal/thermal_hwmon.c
+++ b/drivers/thermal/thermal_hwmon.c
@@ -17,6 +17,7 @@ 
 #include <linux/thermal.h>
 
 #include "thermal_hwmon.h"
+#include "thermal_core.h"
 
 /* hwmon sys I/F */
 /* thermal zone devices with the same type share one hwmon device */