erofs: don't warn ztailpacking feature anymore

Message ID 20230227084457.3510-1-zbestahu@gmail.com
State New
Headers
Series erofs: don't warn ztailpacking feature anymore |

Commit Message

Yue Hu Feb. 27, 2023, 8:44 a.m. UTC
  From: Yue Hu <huyue2@coolpad.com>

The ztailpacking feature has been merged for a year, it has been mostly
stable now.

Signed-off-by: Yue Hu <huyue2@coolpad.com>
---
 fs/erofs/super.c | 2 --
 1 file changed, 2 deletions(-)
  

Comments

Gao Xiang Feb. 27, 2023, 9:42 a.m. UTC | #1
On 2023/2/27 16:44, Yue Hu wrote:
> From: Yue Hu <huyue2@coolpad.com>
> 
> The ztailpacking feature has been merged for a year, it has been mostly
> stable now.
> 
> Signed-off-by: Yue Hu <huyue2@coolpad.com>

Let's update erofs-utils as well?

> ---
>   fs/erofs/super.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 19b1ae79cec4..733c22bcc3eb 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -417,8 +417,6 @@ static int erofs_read_superblock(struct super_block *sb)
>   	/* handle multiple devices */
>   	ret = erofs_scan_devices(sb, dsb);
>   
> -	if (erofs_sb_has_ztailpacking(sbi))
> -		erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
>   	if (erofs_is_fscache_mode(sb))
>   		erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
>   	if (erofs_sb_has_fragments(sbi))
  
Yue Hu Feb. 27, 2023, 9:52 a.m. UTC | #2
On Mon, 27 Feb 2023 17:42:40 +0800
Gao Xiang <hsiangkao@linux.alibaba.com> wrote:

> On 2023/2/27 16:44, Yue Hu wrote:
> > From: Yue Hu <huyue2@coolpad.com>
> > 
> > The ztailpacking feature has been merged for a year, it has been mostly
> > stable now.
> > 
> > Signed-off-by: Yue Hu <huyue2@coolpad.com>  
> 
> Let's update erofs-utils as well?

Ok, I will update it later.

> 
> > ---
> >   fs/erofs/super.c | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> > index 19b1ae79cec4..733c22bcc3eb 100644
> > --- a/fs/erofs/super.c
> > +++ b/fs/erofs/super.c
> > @@ -417,8 +417,6 @@ static int erofs_read_superblock(struct super_block *sb)
> >   	/* handle multiple devices */
> >   	ret = erofs_scan_devices(sb, dsb);
> >   
> > -	if (erofs_sb_has_ztailpacking(sbi))
> > -		erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
> >   	if (erofs_is_fscache_mode(sb))
> >   		erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
> >   	if (erofs_sb_has_fragments(sbi))
  
Gao Xiang March 3, 2023, 12:53 a.m. UTC | #3
On 2023/2/27 16:44, Yue Hu wrote:
> From: Yue Hu <huyue2@coolpad.com>
> 
> The ztailpacking feature has been merged for a year, it has been mostly
> stable now.
> 
> Signed-off-by: Yue Hu <huyue2@coolpad.com>

Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>

Thanks,
Gao Xiang

> ---
>   fs/erofs/super.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/fs/erofs/super.c b/fs/erofs/super.c
> index 19b1ae79cec4..733c22bcc3eb 100644
> --- a/fs/erofs/super.c
> +++ b/fs/erofs/super.c
> @@ -417,8 +417,6 @@ static int erofs_read_superblock(struct super_block *sb)
>   	/* handle multiple devices */
>   	ret = erofs_scan_devices(sb, dsb);
>   
> -	if (erofs_sb_has_ztailpacking(sbi))
> -		erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
>   	if (erofs_is_fscache_mode(sb))
>   		erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
>   	if (erofs_sb_has_fragments(sbi))
  
Chao Yu April 16, 2023, 2:30 p.m. UTC | #4
On 2023/2/27 16:44, Yue Hu wrote:
> From: Yue Hu <huyue2@coolpad.com>
> 
> The ztailpacking feature has been merged for a year, it has been mostly
> stable now.
> 
> Signed-off-by: Yue Hu <huyue2@coolpad.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,
  

Patch

diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 19b1ae79cec4..733c22bcc3eb 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -417,8 +417,6 @@  static int erofs_read_superblock(struct super_block *sb)
 	/* handle multiple devices */
 	ret = erofs_scan_devices(sb, dsb);
 
-	if (erofs_sb_has_ztailpacking(sbi))
-		erofs_info(sb, "EXPERIMENTAL compressed inline data feature in use. Use at your own risk!");
 	if (erofs_is_fscache_mode(sb))
 		erofs_info(sb, "EXPERIMENTAL fscache-based on-demand read feature in use. Use at your own risk!");
 	if (erofs_sb_has_fragments(sbi))