| Message ID | 20230217111613.306978-1-konrad.dybcio@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp833778wrn;
Fri, 17 Feb 2023 03:31:48 -0800 (PST)
X-Google-Smtp-Source:
AK7set8Yr/rAsPAU1q8z0xyKpu3UFL5cOHuFeTul9TswU6L8zxqMao8LCg1GynAMO67qidgog/xL
X-Received: by 2002:a05:6a20:4299:b0:c7:4c1a:3e49 with SMTP id
o25-20020a056a20429900b000c74c1a3e49mr4634815pzj.35.1676633508620;
Fri, 17 Feb 2023 03:31:48 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1676633508; cv=none;
d=google.com; s=arc-20160816;
b=Z5+oKcdEc+aMEBm2zNQ8k2uOIbFs7kB5chtnlp1ibUzas2H0OPyKlzTS57Dy48U8zK
dnEVUcKPVvxNBFKdud7QQxLO/Yxp4+yMp68t2YKUE3hYfRHiyB6bEcrEvxTolaEEcarQ
vkZMyqoiG5I73gOuV+hpknQq79THccvDnDBrIqME9HOJjobpNIh9m/hg0/meS3PwzC8e
cIXVyInp77mBVRq1+yssPRH2gLoP4DoumQ3JUHbAGoPU4GQKT4LKfRTuHRc/QrvpVUyJ
wfbk1hBCikKXGjL5ihynSf1jX/vf8VYtRmnBaKlBx9ugFPRaVuoo+fBibhAcN6lklyS/
/O0g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=+0wgn2J7sEsdXuKmA4KpznfU8V8XceUpwL6C1j73+Vk=;
b=XzBgPeouUi2FBx6qFxz0WZDlBFnv4zi/5Tby3xTNpnZ2GDJV6Tv8jNLo7uInQN97ce
cgr3yQ667SR/bgK1vRbY3IkklY+x7CGvYkMORy8fbKs/OJ/dxJAUCQX0jUgnkCfxc6wt
DKrXFPwSNPnyPjyjjhfRl0Bz5uFEzlwtA9AQ1GeePWVeWaulv0wsTSueNHqr9vRk5jfk
qA13zvKipgyga++2KbCQrekCM78y6PsZXqLj9FtB+XUwtAGDbYcwEw7k3vAlYTEhqg5E
bDLwNYhi0sfFnDrw0XsDWKerNSYQHL2nNIQ8z8hUGx8VLdNqR10svtgfiLV4jAnXD9Rq
edLg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=RAvARnqI;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
h185-20020a6383c2000000b004fa0cf58e12si4828204pge.630.2023.02.17.03.31.35;
Fri, 17 Feb 2023 03:31:48 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=RAvARnqI;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229908AbjBQLQm (ORCPT <rfc822;aimixsaka@gmail.com> + 99 others);
Fri, 17 Feb 2023 06:16:42 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60288 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229864AbjBQLQg (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 17 Feb 2023 06:16:36 -0500
Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com
[IPv6:2a00:1450:4864:20::22e])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27BB365370
for <linux-kernel@vger.kernel.org>;
Fri, 17 Feb 2023 03:16:22 -0800 (PST)
Received: by mail-lj1-x22e.google.com with SMTP id y14so698964ljq.10
for <linux-kernel@vger.kernel.org>;
Fri, 17 Feb 2023 03:16:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=+0wgn2J7sEsdXuKmA4KpznfU8V8XceUpwL6C1j73+Vk=;
b=RAvARnqIsPMy9f5GaK1MNvreQnSXl+M+pThsIcYiN1Q9g2t6VHJrVFo2U4+M0uOJ5Z
/KpjrpL+RAWFVVykX5XuvRbaB5OjhOnMJt15UEeAPh1ps25cs9UJzU0dU3dPUU1NHVAA
PacZGS9yXbcmZEJ+6/pgV6SmHPZWcz5VvuUZclo33OAZshSidIuzmtsRqtZjHRZIbtFX
bOlQu6paNxXzYEjiJ48huFwvJzkdGVy1iZLTWlHhZ8OGKp7fUm2M2j9M8r3RL45+hK9g
0UVkMrk68o1tqkIGy/db0388OPitMpo9JP43Hamoszy5PmRWkrqkjdNCm9HoHWVVv52h
n5tw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=+0wgn2J7sEsdXuKmA4KpznfU8V8XceUpwL6C1j73+Vk=;
b=5xOijdZ3vH1pJCHOWh+R+4NDP0s4HiugLXYKJIwBwtBRqBFn8RUChFpF1ro6TUJqp9
Bxy0YIN2wBwnxJ+eE9sDLhKQJx1QWHIoxiqMN4PcyVYa07j6sTX6CPbKOS2UUWgjZ2/B
2mAPAo0hafYmqj28IiPyu3hA9EZGlBi2H12NvqX6b6VxEKBr1CXpH5NP+jyoDnf/kuUQ
oTowMQl2X4uh/SPWYiNlz/QPXyq+6r8eYM2sucA7ZgNlFKw/hq9+YzRGmhdRRHQPvto1
Xv38+6plpU1eylY59NYlx5fVbF38DvruDPYcWLOFGH9H+bos480eMwusNshRdKsh2jRx
OIiQ==
X-Gm-Message-State: AO0yUKVUgQvkVqPgTix3nEWM/CdZkgMTgYCd735A8JWzrgpQTm1HQCkO
0wkv0z3EHu02IqNYvq9I5eXgFg==
X-Received: by 2002:a05:651c:512:b0:28b:6d76:e9ce with SMTP id
o18-20020a05651c051200b0028b6d76e9cemr198780ljp.23.1676632580456;
Fri, 17 Feb 2023 03:16:20 -0800 (PST)
Received: from localhost.localdomain (abxh117.neoplus.adsl.tpnet.pl.
[83.9.1.117])
by smtp.gmail.com with ESMTPSA id
u21-20020a2e9b15000000b002935899fe3fsm554818lji.116.2023.02.17.03.16.18
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 17 Feb 2023 03:16:19 -0800 (PST)
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: linux-arm-msm@vger.kernel.org, andersson@kernel.org,
agross@kernel.org
Cc: marijn.suijten@somainline.org,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/6] dt-bindings: arm-smmu: Use qcom,smmu compatible for
MMU500 adreno SMMUs
Date: Fri, 17 Feb 2023 12:16:08 +0100
Message-Id: <20230217111613.306978-1-konrad.dybcio@linaro.org>
X-Mailer: git-send-email 2.39.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1758077658123650580?=
X-GMAIL-MSGID: =?utf-8?q?1758077658123650580?=
|
| Series |
[v2,1/6] dt-bindings: arm-smmu: Use qcom,smmu compatible for MMU500 adreno SMMUs
|
|
Commit Message
Konrad Dybcio
Feb. 17, 2023, 11:16 a.m. UTC
qcom,smmu-500 was introduced to prevent people from adding new
compatibles for what seems to roughly be the same hardware. Use it for
qcom,adreno-smmu-compatible targets as well.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
v1 -> v2:
- Add this patch, omitted previously (big oops)
.../devicetree/bindings/iommu/arm,smmu.yaml | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
Comments
On Fri, Feb 17, 2023 at 12:16:08PM +0100, Konrad Dybcio wrote: > qcom,smmu-500 was introduced to prevent people from adding new > compatibles for what seems to roughly be the same hardware. Use it for > qcom,adreno-smmu-compatible targets as well. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > v1 -> v2: > - Add this patch, omitted previously (big oops) > > .../devicetree/bindings/iommu/arm,smmu.yaml | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index 807cb511fe18..4d7f61700cae 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -75,9 +75,19 @@ properties: > - qcom,sm8350-smmu-500 > - qcom,sm8450-smmu-500 > - const: arm,mmu-500 > - > - - description: Qcom Adreno GPUs implementing "arm,smmu-500" > + - description: Qcom Adreno GPUs implementing "qcom,smmu-500" and "arm,smmu-500" > + items: > + - enum: > + - qcom,sc7280-smmu-500 > + - qcom,sm8150-smmu-500 > + - qcom,sm8250-smmu-500 > + - const: qcom,adreno-smmu > + - const: qcom,smmu-500 > + - const: arm,mmu-500 4 compatibles seems excessive. Is adding one that helpful? Is 'arm,mmu-500' useful on its own? > + - description: Qcom Adreno GPUs implementing "arm,smmu-500" (legacy binding) Perhaps fix the existing typo: arm,mmu-500 > + deprecated: true > items: > + # Do not add additional SoC to this list. Instead use previous list. > - enum: > - qcom,sc7280-smmu-500 > - qcom,sm8150-smmu-500 > -- > 2.39.1 >
On 17/02/2023 12:16, Konrad Dybcio wrote: > qcom,smmu-500 was introduced to prevent people from adding new > compatibles for what seems to roughly be the same hardware. Use it for > qcom,adreno-smmu-compatible targets as well. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > v1 -> v2: > - Add this patch, omitted previously (big oops) > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 26.02.2023 18:37, Rob Herring wrote: > On Fri, Feb 17, 2023 at 12:16:08PM +0100, Konrad Dybcio wrote: >> qcom,smmu-500 was introduced to prevent people from adding new >> compatibles for what seems to roughly be the same hardware. Use it for >> qcom,adreno-smmu-compatible targets as well. >> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> v1 -> v2: >> - Add this patch, omitted previously (big oops) >> >> .../devicetree/bindings/iommu/arm,smmu.yaml | 14 ++++++++++++-- >> 1 file changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> index 807cb511fe18..4d7f61700cae 100644 >> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml >> @@ -75,9 +75,19 @@ properties: >> - qcom,sm8350-smmu-500 >> - qcom,sm8450-smmu-500 >> - const: arm,mmu-500 >> - >> - - description: Qcom Adreno GPUs implementing "arm,smmu-500" >> + - description: Qcom Adreno GPUs implementing "qcom,smmu-500" and "arm,smmu-500" >> + items: >> + - enum: >> + - qcom,sc7280-smmu-500 >> + - qcom,sm8150-smmu-500 >> + - qcom,sm8250-smmu-500 >> + - const: qcom,adreno-smmu >> + - const: qcom,smmu-500 >> + - const: arm,mmu-500 > > 4 compatibles seems excessive. Is adding one that helpful? Is > 'arm,mmu-500' useful on its own? Yes. per-soc compatible is there for per-soc quirks should there be any qcom,adreno-smmu enabled per-process pagetables qcom,smmu-500 matches the qcom smmu implementation arm,mmu-500 matches the smmu driver as a whole > >> + - description: Qcom Adreno GPUs implementing "arm,smmu-500" (legacy binding) > > Perhaps fix the existing typo: arm,mmu-500 Ack Konrad > >> + deprecated: true >> items: >> + # Do not add additional SoC to this list. Instead use previous list. >> - enum: >> - qcom,sc7280-smmu-500 >> - qcom,sm8150-smmu-500 >> -- >> 2.39.1 >>
diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml index 807cb511fe18..4d7f61700cae 100644 --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml @@ -75,9 +75,19 @@ properties: - qcom,sm8350-smmu-500 - qcom,sm8450-smmu-500 - const: arm,mmu-500 - - - description: Qcom Adreno GPUs implementing "arm,smmu-500" + - description: Qcom Adreno GPUs implementing "qcom,smmu-500" and "arm,smmu-500" + items: + - enum: + - qcom,sc7280-smmu-500 + - qcom,sm8150-smmu-500 + - qcom,sm8250-smmu-500 + - const: qcom,adreno-smmu + - const: qcom,smmu-500 + - const: arm,mmu-500 + - description: Qcom Adreno GPUs implementing "arm,smmu-500" (legacy binding) + deprecated: true items: + # Do not add additional SoC to this list. Instead use previous list. - enum: - qcom,sc7280-smmu-500 - qcom,sm8150-smmu-500