| Message ID | 20230224153302.45365-1-povik+lin@cutebit.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp983070wrd;
Fri, 24 Feb 2023 07:45:39 -0800 (PST)
X-Google-Smtp-Source:
AK7set8dQKzowoY+HqeqyfPPjQpXViuvQdRMwpTCa89wsG7buB/akgXPuJLTKsfuJBFXMLIGt678
X-Received: by 2002:a17:903:2441:b0:196:5bac:e319 with SMTP id
l1-20020a170903244100b001965bace319mr19089874pls.35.1677253538903;
Fri, 24 Feb 2023 07:45:38 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1677253538; cv=none;
d=google.com; s=arc-20160816;
b=DQ0F70KMnAIbSYWdWyfasS2gh1bTdVDcJndkEgvLmEKjrHUi31P372YArrjyls5yS0
xe97OlITPLX0Uin6KgjHWs5s88CgBx3tNR83e99gnkJE67hxpqK2q5p5eDwypZTt3269
QuqdQOMV+P1rzdgGKAzDTpYRNwx3s1avz3gVLqTXQfgaIW0SqDVdrODTzG1jjm+dN0GD
xZkzHnW2sRR+dogjEM+39cPl6h7Ejx4OBNuKeNh9LYps6GRXkG/V4Z7fH5BXJ9KQ7yYL
ulfU0wYncC9P6NRyBqAsWbhfSTqXO8UG77lqIPDI/BzZ/sPFoR6ZuZE01Fb8r19rQy84
CgZQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:dkim-signature:from;
bh=FNC6kTd6Z6n+zN6leJIOos4elgBgrZXAAOuIqFvhYUs=;
b=GhiJ1IU9zZbWdQIsuAHugnA75MmDRKPpwsglu7tvsYFPywZqqyBi8lZJ84T5c2bQ9B
PQdvZMgd+d5u1Ls1pUR4bDl8mOBPdwDbmXqGPGTFGljDSclh5KDwAU7MZ90JtL5JJ1tG
Lv7nwPL858TQIrlgk9N2e2x9Ry57BUivJleIKnfp+1x0ELrFVx0A3BeqsenbMZ4KNcyG
5FhT1DFXTWGi/TkovQXKtXgwv01p7UIefwhiEom0ROxI8ceWRp7oIhh6ovQHz3VTDBzh
Py+5XxPZUESM/Xc/lMAafZI/9kRNHEIP3epFcvrDv91QhimXunXe8dhFJ/L3NdwewFlB
anOw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@cutebit.org header.s=mail header.b="kH/TERxB";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
q18-20020a170902bd9200b0019ad22c40c7si4685515pls.132.2023.02.24.07.45.26;
Fri, 24 Feb 2023 07:45:38 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@cutebit.org header.s=mail header.b="kH/TERxB";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=cutebit.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229637AbjBXPdW (ORCPT <rfc822;jeff.pang.chn@gmail.com>
+ 99 others); Fri, 24 Feb 2023 10:33:22 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58334 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229817AbjBXPdU (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 24 Feb 2023 10:33:20 -0500
Received: from hutie.ust.cz (unknown [IPv6:2a03:3b40:fe:f0::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56A9015882
for <linux-kernel@vger.kernel.org>;
Fri, 24 Feb 2023 07:33:17 -0800 (PST)
From: =?utf-8?q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cutebit.org; s=mail;
t=1677252795; bh=FNC6kTd6Z6n+zN6leJIOos4elgBgrZXAAOuIqFvhYUs=;
h=From:To:Cc:Subject:Date;
b=kH/TERxBETkz5SQRy/I6aJG4HrBNKpNvVhyYy2/SApa1r7qVGO8CKPOi0NtrKdgdK
qVcyGffZTorEc3HsQWZnLIZDqdFj8fluDyIPvtHzD+pK8ZtIxw45SPqFmKyuJEM5pn
R/chzDUc7u81R+uFsei6GAZT4kAD214iYUwJ8eRU=
To: =?utf-8?q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>,
Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: asahi@lists.linux.dev, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] ASoC: apple: mca: Fix final status read on SERDES reset
Date: Fri, 24 Feb 2023 16:33:00 +0100
Message-Id: <20230224153302.45365-1-povik+lin@cutebit.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_FAIL,SPF_HELO_NONE
autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1758727806979542095?=
X-GMAIL-MSGID: =?utf-8?q?1758727806979542095?=
|
| Series |
[1/3] ASoC: apple: mca: Fix final status read on SERDES reset
|
|
Commit Message
Martin Povišer
Feb. 24, 2023, 3:33 p.m. UTC
From within the early trigger we are doing a reset of the SERDES unit,
but the final status read is on a bad address. Add the missing SERDES
unit offset in calculation of the address.
Fixes: 3df5d0d97289 ("ASoC: apple: mca: Start new platform driver")
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
---
sound/soc/apple/mca.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, 24 Feb 2023 16:33:00 +0100, Martin Povišer wrote: > From within the early trigger we are doing a reset of the SERDES unit, > but the final status read is on a bad address. Add the missing SERDES > unit offset in calculation of the address. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/3] ASoC: apple: mca: Fix final status read on SERDES reset commit: aaf5f0d76b6e1870e3674408de2b13a92a4d4059 [2/3] ASoC: apple: mca: Fix SERDES reset sequence commit: d8b3e396088d787771f19fd3b7949e080dc31d6f [3/3] ASoC: apple: mca: Improve handling of unavailable DMA channels commit: fb1847cc460c127b12720119eae5f438ffc62e85 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c index 24381c42eb54..9cceeb259952 100644 --- a/sound/soc/apple/mca.c +++ b/sound/soc/apple/mca.c @@ -210,7 +210,7 @@ static void mca_fe_early_trigger(struct snd_pcm_substream *substream, int cmd, SERDES_CONF_SOME_RST); readl_relaxed(cl->base + serdes_conf); mca_modify(cl, serdes_conf, SERDES_STATUS_RST, 0); - WARN_ON(readl_relaxed(cl->base + REG_SERDES_STATUS) & + WARN_ON(readl_relaxed(cl->base + serdes_unit + REG_SERDES_STATUS) & SERDES_STATUS_RST); break; default: