diff mbox series

[v2] staging: media: imx: imx7-media-csi: Fix parenthesis alignment

Message ID 20221025001239.16345-1-lima.gabriel.luz@gmail.com
State New
Headers
Series [v2] staging: media: imx: imx7-media-csi: Fix parenthesis alignment |

Commit Message

Gabriel Lima Luz Oct. 25, 2022, 12:12 a.m. UTC 
  Adhere to Linux kernel coding style.

Reported by checkpatch:

CHECK: Alignment should match open parenthesis

Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
---
Altered changes acording to feedback for a more readable code

 drivers/staging/media/imx/imx7-media-csi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Julia Lawall Oct. 25, 2022, 5:01 a.m. UTC | #1 
On Mon, 24 Oct 2022, Gabriel Lima Luz wrote:

> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Alignment should match open parenthesis

Here you have made a decision that is quite reasonable, but that does not
actually "Fix parenthesis alignment".  This highlights an overall problem
with your log message.  You say what you are "fixing", but you don't give
any explanation about why you have done what you have done.  Actually the
most helpful comment was below the ---, but that will disappear when the
patch is applied.

julia

>
> Signed-off-by: Gabriel Lima Luz <lima.gabriel.luz@gmail.com>
> ---
> Altered changes acording to feedback for a more readable code
>
>  drivers/staging/media/imx/imx7-media-csi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
> index cbc66ef0eda8..b241b68f456c 100644
> --- a/drivers/staging/media/imx/imx7-media-csi.c
> +++ b/drivers/staging/media/imx/imx7-media-csi.c
> @@ -1704,7 +1704,8 @@ static int imx7_csi_init_cfg(struct v4l2_subdev *sd,
>  		mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace);
>  		mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace);
>  		mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv,
> -					mf->colorspace, mf->ycbcr_enc);
> +							mf->colorspace,
> +							mf->ycbcr_enc);
>
>  		csi->cc[i] = cc;
>  	}
> --
> 2.34.1
>
>
>
diff mbox series

Patch

diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c
index cbc66ef0eda8..b241b68f456c 100644
--- a/drivers/staging/media/imx/imx7-media-csi.c
+++ b/drivers/staging/media/imx/imx7-media-csi.c
@@ -1704,7 +1704,8 @@  static int imx7_csi_init_cfg(struct v4l2_subdev *sd,
 		mf->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(mf->colorspace);
 		mf->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(mf->colorspace);
 		mf->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(!cc->yuv,
-					mf->colorspace, mf->ycbcr_enc);
+							mf->colorspace,
+							mf->ycbcr_enc);
 
 		csi->cc[i] = cc;
 	}