Message ID | 20230223070252.2029174-1-kai.heng.feng@canonical.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp181488wrd; Wed, 22 Feb 2023 23:30:39 -0800 (PST) X-Google-Smtp-Source: AK7set9oIDnNEVKud4l8Ft4zW8AjoRk+IWg9rFCSSbYcQdJYxRhOfkqFRDshbYi86LcZXw4jJuh8 X-Received: by 2002:a17:906:51ca:b0:8eb:fb1a:6970 with SMTP id v10-20020a17090651ca00b008ebfb1a6970mr2547200ejk.1.1677137439569; Wed, 22 Feb 2023 23:30:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1677137439; cv=none; d=google.com; s=arc-20160816; b=ibBHRYFOMjLwogMWAdFktuXlmHDvd+lTGDtfbs6mRB5wBNSxm+0eiRe+K+nbwEMnUD CHGDh7Obuqnk0KfXYrRJf27khzWQ2FaKKUpR4+u1aLCBZ9QgNeH3RNcwK8vNrZxkWcWL KvLcvOYljNHRivR2WbRgDkstsz0YDllUySG+fFwJmdmUd9KTvbcNJGY8JR29bLMONCRa 6dh3KF4TdLjEFNadSxNoWo9unFN6adycxnGcOIrON9bpeaaYUlMF2eILm/BLS1tpnFCe mhbXbQRyMLWtN3E6ZlHBM/zlVDFk7OSEkJ1Qftzf9eiG7nSUoNPKT5hSK3Xb1YhURDKm bZnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=CcSI32gZ7c8S1OzBEvrF82hTekSR867LXozzHErLs6A=; b=ZB0SGxa0hXObTu7cjTnrYebMrgjcXOe8bBOp5dav+EEeDO2HtFxoKG1O3ytheONb2t bpXigkF010WI+pW0+QTu6UezRiAC6ptvNnf82rxIW6hqm7UaI71WBjn4k2hdVqrFbyZs rGRWSl1y2hOxy6UedOnUN7VQbm8ClQla7/sK7xhOETl6tyV0o0fJNQrDKhoZoHlIi3jT +gVIsguiByZauguf1y4Oftw4U8RriOdDjqOUOrobAVmJeeKrq8hHYy4uUlxP94jbMyJF pkdWnXLXriP3/JqLsaVmmfBjPQ3296o5SFVPJmcoyWuBFpxzvh9HDJ6Xcm7pGuX4yPCa HJXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=L4BExEmN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qn20-20020a170907871400b008c0f56c2b50si15438518ejc.421.2023.02.22.23.30.08; Wed, 22 Feb 2023 23:30:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=L4BExEmN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbjBWHEH (ORCPT <rfc822;cambridge8321@gmail.com> + 99 others); Thu, 23 Feb 2023 02:04:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232470AbjBWHEF (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 23 Feb 2023 02:04:05 -0500 Received: from smtp-relay-canonical-0.canonical.com (smtp-relay-canonical-0.canonical.com [185.125.188.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A05A84AFE9; Wed, 22 Feb 2023 23:03:48 -0800 (PST) Received: from localhost.localdomain (unknown [10.101.196.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 1CC6B3F116; Thu, 23 Feb 2023 07:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1677135827; bh=CcSI32gZ7c8S1OzBEvrF82hTekSR867LXozzHErLs6A=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=L4BExEmNk2RJDQrEB+V+MfwoSGnpouK0snNESz7nMrwsaL5QBVo8j1c72eRpu3vxj nxt6awngHrHP4dZfjLxKYgtUuMbY511t+gWMI3sO6qdGpsY2BXPETS5d5L0eTM4i8b n6vUGHCX6kNX0vg7FKGJf4S/lnR6YmnNxPdCokMY58FVViSN4XGps/hqi60ZbWvxjM 2yHE/a3kWM/i6G/jQhooA8lfAFcDhSDXVRY3CHfZ/6PNuPogfuPhk/YEe/XlZ1oDx6 G6z1LSQWKqvy9+qB5hFmH5YS5nIcCvJyipzcFnpQFMiqbcFjVNG0kPJ7/Sg+4bdrzh 4H/ey04Lyd6PA== From: Kai-Heng Feng <kai.heng.feng@canonical.com> To: ray.huang@amd.com Cc: mario.limonciello@amd.com, Kai-Heng Feng <kai.heng.feng@canonical.com>, "Rafael J. Wysocki" <rafael@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled Date: Thu, 23 Feb 2023 15:02:52 +0800 Message-Id: <20230223070252.2029174-1-kai.heng.feng@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758583792051766640?= X-GMAIL-MSGID: =?utf-8?q?1758606068012705359?= |
Series |
[v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled
|
|
Commit Message
Kai-Heng Feng
Feb. 23, 2023, 7:02 a.m. UTC
Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
parameter for mode selection") changed the driver to be disabled by
default, and this can surprise users.
Let users know what happened so they can decide what to do next.
Link: https://bugs.launchpad.net/bugs/2006942
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2:
- Remove redundancy in pr_info().
- Fix spelling and URL tag.
drivers/cpufreq/amd-pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
[AMD Official Use Only - General] > -----Original Message----- > From: Kai-Heng Feng <kai.heng.feng@canonical.com> > Sent: Thursday, February 23, 2023 3:03 PM > To: Huang, Ray <Ray.Huang@amd.com> > Cc: Limonciello, Mario <Mario.Limonciello@amd.com>; Kai-Heng Feng > <kai.heng.feng@canonical.com>; Rafael J. Wysocki <rafael@kernel.org>; Viresh > Kumar <viresh.kumar@linaro.org>; linux-pm@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is disabled > > Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver parameter > for mode selection") changed the driver to be disabled by default, and this can > surprise users. > > Let users know what happened so they can decide what to do next. > > Link: https://bugs.launchpad.net/bugs/2006942 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > v2: > - Remove redundancy in pr_info(). > - Fix spelling and URL tag. > > drivers/cpufreq/amd-pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index > 45c88894fd8e..f965f54f7ae7 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void) > * with amd_pstate=passive or other modes in kernel command line > */ > if (cppc_state == AMD_PSTATE_DISABLE) { > - pr_debug("driver load is disabled, boot with specific mode to > enable this\n"); > + pr_info("driver load is disabled, boot with specific mode to > enable > +this\n"); > return -ENODEV; > } > > -- > 2.34.1 Thanks for the change. Reviewed-by : Yuan Perry <Perry.Yuan@amd.com>
On Thu, Feb 23, 2023 at 03:02:52PM +0800, Kai-Heng Feng wrote: > Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver > parameter for mode selection") changed the driver to be disabled by > default, and this can surprise users. > > Let users know what happened so they can decide what to do next. > > Link: https://bugs.launchpad.net/bugs/2006942 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> Please feel free to add my Acked on V2 as well. Acked-by: Huang Rui <ray.huang@amd.com> > --- > v2: > - Remove redundancy in pr_info(). > - Fix spelling and URL tag. > > drivers/cpufreq/amd-pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 45c88894fd8e..f965f54f7ae7 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void) > * with amd_pstate=passive or other modes in kernel command line > */ > if (cppc_state == AMD_PSTATE_DISABLE) { > - pr_debug("driver load is disabled, boot with specific mode to enable this\n"); > + pr_info("driver load is disabled, boot with specific mode to enable this\n"); > return -ENODEV; > } > > -- > 2.34.1 >
[Public] > -----Original Message----- > From: Huang, Ray <Ray.Huang@amd.com> > Sent: Thursday, February 23, 2023 05:38 > To: Kai-Heng Feng <kai.heng.feng@canonical.com> > Cc: Limonciello, Mario <Mario.Limonciello@amd.com>; Rafael J. Wysocki > <rafael@kernel.org>; Viresh Kumar <viresh.kumar@linaro.org>; linux- > pm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] cpufreq: amd-pstate: Let user know amd-pstate is > disabled > > On Thu, Feb 23, 2023 at 03:02:52PM +0800, Kai-Heng Feng wrote: > > Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver > > parameter for mode selection") changed the driver to be disabled by > > default, and this can surprise users. > > > > Let users know what happened so they can decide what to do next. > > > > Link: https://bugs.launchpad.net/bugs/2006942 > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > > Please feel free to add my Acked on V2 as well. > > Acked-by: Huang Rui <ray.huang@amd.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > > > --- > > v2: > > - Remove redundancy in pr_info(). > > - Fix spelling and URL tag. > > > > drivers/cpufreq/amd-pstate.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > > index 45c88894fd8e..f965f54f7ae7 100644 > > --- a/drivers/cpufreq/amd-pstate.c > > +++ b/drivers/cpufreq/amd-pstate.c > > @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void) > > * with amd_pstate=passive or other modes in kernel command line > > */ > > if (cppc_state == AMD_PSTATE_DISABLE) { > > - pr_debug("driver load is disabled, boot with specific mode to > enable this\n"); > > + pr_info("driver load is disabled, boot with specific mode to > enable this\n"); > > return -ENODEV; > > } > > > > -- > > 2.34.1 > >
On Thu, Feb 23, 2023 at 8:03 AM Kai-Heng Feng <kai.heng.feng@canonical.com> wrote: > > Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver > parameter for mode selection") changed the driver to be disabled by > default, and this can surprise users. > > Let users know what happened so they can decide what to do next. > > Link: https://bugs.launchpad.net/bugs/2006942 > Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com> > --- > v2: > - Remove redundancy in pr_info(). > - Fix spelling and URL tag. > > drivers/cpufreq/amd-pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 45c88894fd8e..f965f54f7ae7 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void) > * with amd_pstate=passive or other modes in kernel command line > */ > if (cppc_state == AMD_PSTATE_DISABLE) { > - pr_debug("driver load is disabled, boot with specific mode to enable this\n"); > + pr_info("driver load is disabled, boot with specific mode to enable this\n"); > return -ENODEV; > } > > -- Applied as 6.3-rc material, thanks!
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 45c88894fd8e..f965f54f7ae7 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void) * with amd_pstate=passive or other modes in kernel command line */ if (cppc_state == AMD_PSTATE_DISABLE) { - pr_debug("driver load is disabled, boot with specific mode to enable this\n"); + pr_info("driver load is disabled, boot with specific mode to enable this\n"); return -ENODEV; }