diff mbox series

ACPI: x86: Add another system to quirk list for forcing StorageD3Enable

Message ID 20221014121136.8677-1-mario.limonciello@amd.com
State New
Headers
Series ACPI: x86: Add another system to quirk list for forcing StorageD3Enable |

Commit Message

Mario Limonciello Oct. 14, 2022, 12:11 p.m. UTC 
  commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
for StorageD3Enable") introduced a quirk to allow a system with ambiguous
use of _ADR 0 to force StorageD3Enable.

Julius Brockmann reports that Inspiron 16 5625 suffers that same symptoms.
Add this other system to the list as well.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=216440
Reported-and-tested-by: Julius Brockmann <mail@juliusbrockmann.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
 drivers/acpi/x86/utils.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Mario Limonciello Oct. 25, 2022, 12:13 a.m. UTC | #1 
On 10/14/2022 07:11, Mario Limonciello wrote:
> commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
> for StorageD3Enable") introduced a quirk to allow a system with ambiguous
> use of _ADR 0 to force StorageD3Enable.
> 
> Julius Brockmann reports that Inspiron 16 5625 suffers that same symptoms.
> Add this other system to the list as well.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216440
> Reported-and-tested-by: Julius Brockmann <mail@juliusbrockmann.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
>   drivers/acpi/x86/utils.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 

Hi Rafael,

This got sent near the merge window a few weeks ago.  It's a trivial fix 
so I just want to make sure it didn't get misplaced.

Thanks!

> diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
> index f8a2cbdc0ce2b..d7d3f1669d4c0 100644
> --- a/drivers/acpi/x86/utils.c
> +++ b/drivers/acpi/x86/utils.c
> @@ -219,6 +219,12 @@ static const struct dmi_system_id force_storage_d3_dmi[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 14 7425 2-in-1"),
>   		}
>   	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
> +		}
> +	},
>   	{}
>   };
>
Rafael J. Wysocki Oct. 28, 2022, 3:33 p.m. UTC | #2 
On Tue, Oct 25, 2022 at 2:13 AM Limonciello, Mario
<mario.limonciello@amd.com> wrote:
>
> On 10/14/2022 07:11, Mario Limonciello wrote:
> > commit 018d6711c26e4 ("ACPI: x86: Add a quirk for Dell Inspiron 14 2-in-1
> > for StorageD3Enable") introduced a quirk to allow a system with ambiguous
> > use of _ADR 0 to force StorageD3Enable.
> >
> > Julius Brockmann reports that Inspiron 16 5625 suffers that same symptoms.
> > Add this other system to the list as well.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216440
> > Reported-and-tested-by: Julius Brockmann <mail@juliusbrockmann.com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> > ---
> >   drivers/acpi/x86/utils.c | 6 ++++++
> >   1 file changed, 6 insertions(+)
> >
>
> Hi Rafael,
>
> This got sent near the merge window a few weeks ago.  It's a trivial fix
> so I just want to make sure it didn't get misplaced.

I had a plan to push it for -rc3, but then I didn't include it in the PR.

I'll queue it up for -rc4 now.

Thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c
index f8a2cbdc0ce2b..d7d3f1669d4c0 100644
--- a/drivers/acpi/x86/utils.c
+++ b/drivers/acpi/x86/utils.c
@@ -219,6 +219,12 @@  static const struct dmi_system_id force_storage_d3_dmi[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 14 7425 2-in-1"),
 		}
 	},
+	{
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 16 5625"),
+		}
+	},
 	{}
 };