Message ID | 20230221153740.1620529-7-angelogioacchino.delregno@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp78856wrd; Tue, 21 Feb 2023 07:43:58 -0800 (PST) X-Google-Smtp-Source: AK7set9MbWR/NUokzW56F+iTzid/d2On4yOQQtATbxbZ2DNpGT99NFPO7C+XeZJf+v6Qlh1iKUew X-Received: by 2002:a17:903:228d:b0:19b:33c0:4097 with SMTP id b13-20020a170903228d00b0019b33c04097mr4923156plh.27.1676994237881; Tue, 21 Feb 2023 07:43:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676994237; cv=none; d=google.com; s=arc-20160816; b=JqOf0Z2zZMg5gTXH+gsKJlus4j7uwLWz1f9zrQns4gWqaEgmtcxzMUGO6YFelCngO1 6Z/I5VcgsNODgvGd/hl/H41+Q2up0fnBHUQkHDAz5QpSsep0vVXbsxRRmiNbfdWIwu2D ixnmsobQKGyvetgwZxQJwlpwZ1k4eOpFNu3/gVhiBoAzODX1IptlcpHKj78gNchGSGdf Mc1wUdQwbCGFVbQkrsfyQxBNN8aXZTxODV+Kof7Kwq53VjRT42Se00wb2ou+EwTjHnYG 5BDo5oJkbelKEGm4T7vhKe2ezHjnGmUUyWWy35dCfTN0ngFjaYdHO/dVQVaBx55fn0kA JPfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=x1F10CNA3aCGhAIsYkfbklvndjKZJhXm0DlJVEKE1IQ=; b=tO/kYSVBNG4tLI81BL3TqZadJnScdP9sHTl8RjYqbQn1HtGn3+Sijv2XYY6QKZPX4N a2ttEOCzjZTv+O1NymgB7Pz8FbhcN0B6eTeQY2LNYJvruYJKXyT5rz7Mm+7aIWMbftl7 ptaDr3ksnkqVb+ZQ3sV/9PSiAovi5QFQq1LkXE5VE3dveBSvWfQLygL8M3ZuHRtZa7RA 2M0CeMSOIsS28pvUxXsR3gusiIJ6/EAxvB0Kkb35lltDwNbSCORHlT1RTO7Y8ZbzEDod OIjE3JdwZnRwgWg/LSVNYQOj6bog80ATUeX934u2vT14PLtIMHb5i+wcSX83XTNAUbt1 rYGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=H+Othc8j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j17-20020a170902da9100b0019aa2f3e423si5035037plx.547.2023.02.21.07.43.44; Tue, 21 Feb 2023 07:43:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=H+Othc8j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234361AbjBUPiK (ORCPT <rfc822;kloczko.tomasz@gmail.com> + 99 others); Tue, 21 Feb 2023 10:38:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234613AbjBUPh4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Feb 2023 10:37:56 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8006A1CAC7; Tue, 21 Feb 2023 07:37:51 -0800 (PST) Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 61588660219C; Tue, 21 Feb 2023 15:37:49 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1676993870; bh=XZzIf5WhWGCw6ZUak5aUno/dS29XlqQ4V6b5lAMNRT4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H+Othc8jly/UlZ/H/DYKYH2UsRajWJP5aw6CzokeJLVJtdEBoZthynoP83iLZjADP Vq9CEae9R1VtMisaalqSoYE0IvUcRUFRBQFBJVJEmhrhQ4eNWTJqeeuUWuH27UBNwU 4I/QgzW1qoOVHRfCrVXmB0IMd5+vOIZCCqVmeld4+LNPTjNAjqmQN/gmnIW31qcNgP iOvpAWaRT9jEATqXvjZ+/02fhU/Ik7SW9kk9FBy4Th2+SWqmXlK1wmk24yPDCSUXwo mHfIF1LJ3agbpB9T1IuXi8ESMSXkBjbiQodLq1XmhDr0mOYRyT/uA3UpA+X5ce42v5 yRgIO9n6bKObw== From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: airlied@gmail.com Cc: daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, steven.price@arm.com, alyssa.rosenzweig@collabora.com, matthias.bgg@gmail.com, robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, wenst@chromium.org, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Subject: [PATCH v2 06/10] dt-bindings: gpu: mali-bifrost: Add a compatible for MediaTek MT8186 Date: Tue, 21 Feb 2023 16:37:36 +0100 Message-Id: <20230221153740.1620529-7-angelogioacchino.delregno@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> References: <20230221153740.1620529-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758455909926775455?= X-GMAIL-MSGID: =?utf-8?q?1758455909926775455?= |
Series |
Panfrost: Improve and add MediaTek SoCs support
|
|
Commit Message
AngeloGioacchino Del Regno
Feb. 21, 2023, 3:37 p.m. UTC
Get GPU support on MT8186 by adding its compatible.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Get GPU support on MT8186 by adding its compatible. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index be18b161959b..43a841d4e94d 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -15,6 +15,11 @@ properties: > > compatible: > oneOf: > + - items: > + - enum: > + - mediatek,mt8186-mali > + - const: mediatek,mt8183b-mali > + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable The MT8186 has Mali-G52 MC2 2EE, while the MT8183 has Mali-G72 MP3. So we actually need a new entry with two power domains. Our downstream Mali driver & DT use just that. ChenYu
Il 22/02/23 09:37, Chen-Yu Tsai ha scritto: > On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Get GPU support on MT8186 by adding its compatible. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml >> index be18b161959b..43a841d4e94d 100644 >> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml >> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml >> @@ -15,6 +15,11 @@ properties: >> >> compatible: >> oneOf: >> + - items: >> + - enum: >> + - mediatek,mt8186-mali >> + - const: mediatek,mt8183b-mali >> + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > > The MT8186 has Mali-G52 MC2 2EE, while the MT8183 has Mali-G72 MP3. Keeping in mind the obvious - which is that G52 and G72 are both Bifrost.... > So we actually need a new entry with two power domains. > ...This is my node for MT8186: gpu: gpu@13040000 { compatible = "mediatek,mt8186-mali", "mediatek,mt8183b-mali", "arm,mali-bifrost"; reg = <0 0x13040000 0 0x4000>; clocks = <&mfgsys CLK_MFG_BG3D>; interrupts = <GIC_SPI 276 IRQ_TYPE_LEVEL_HIGH 0>, <GIC_SPI 275 IRQ_TYPE_LEVEL_HIGH 0>, <GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH 0>; interrupt-names = "job", "mmu", "gpu"; power-domains = <&spm MT8186_POWER_DOMAIN_MFG1>, <&spm MT8186_POWER_DOMAIN_MFG2>, <&spm MT8186_POWER_DOMAIN_MFG3>; power-domain-names = "core0", "core1", "core2"; /* Please ignore speedbin, that's for another time :-) */ nvmem-cells = <&gpu_volt_bin>; nvmem-cell-names = "speed-bin"; #cooling-cells = <2>; }; There are three MFG power domains... MFG2 and MFG3 are parents of MFG1, on that I agree, but we can avoid adding a new entry just for MT8186 and use the MT8183-b one while still being technically correct. Besides, Mali G52 and Mali G72 are both Bifrost... so I don't think that this commit is incorrect. For the sake of simplicity, I would push on getting this one picked. Unless there are any real-strong opinions against... Regards, Angelo > Our downstream Mali driver & DT use just that. > > ChenYu
On Wed, Feb 22, 2023 at 5:13 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 22/02/23 09:37, Chen-Yu Tsai ha scritto: > > On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno > > <angelogioacchino.delregno@collabora.com> wrote: > >> > >> Get GPU support on MT8186 by adding its compatible. > >> > >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > >> --- > >> Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++ > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > >> index be18b161959b..43a841d4e94d 100644 > >> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > >> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > >> @@ -15,6 +15,11 @@ properties: > >> > >> compatible: > >> oneOf: > >> + - items: > >> + - enum: > >> + - mediatek,mt8186-mali > >> + - const: mediatek,mt8183b-mali > >> + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > > > > The MT8186 has Mali-G52 MC2 2EE, while the MT8183 has Mali-G72 MP3. > > Keeping in mind the obvious - which is that G52 and G72 are both Bifrost.... > > > So we actually need a new entry with two power domains. > > > > ...This is my node for MT8186: > > gpu: gpu@13040000 { > compatible = "mediatek,mt8186-mali", > "mediatek,mt8183b-mali", > "arm,mali-bifrost"; > reg = <0 0x13040000 0 0x4000>; > > clocks = <&mfgsys CLK_MFG_BG3D>; > interrupts = <GIC_SPI 276 IRQ_TYPE_LEVEL_HIGH 0>, > <GIC_SPI 275 IRQ_TYPE_LEVEL_HIGH 0>, > <GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH 0>; > interrupt-names = "job", "mmu", "gpu"; > power-domains = <&spm MT8186_POWER_DOMAIN_MFG1>, > <&spm MT8186_POWER_DOMAIN_MFG2>, > <&spm MT8186_POWER_DOMAIN_MFG3>; > power-domain-names = "core0", "core1", "core2"; > > /* Please ignore speedbin, that's for another time :-) */ > nvmem-cells = <&gpu_volt_bin>; > nvmem-cell-names = "speed-bin"; > #cooling-cells = <2>; > }; > > There are three MFG power domains... MFG2 and MFG3 are parents of MFG1, on that > I agree, but we can avoid adding a new entry just for MT8186 and use the MT8183-b > one while still being technically correct. > > Besides, Mali G52 and Mali G72 are both Bifrost... so I don't think that this > commit is incorrect. For the sake of simplicity, I would push on getting this > one picked. I'm aware. In case it wasn't obvious, Mali-G52 MC2 2EE has 2 cores, while Mali-G72 MP3 has 3 cores. I think that is reason enough to do a new entry. Otherwise you are describing power domains for 3 cores for a GPU that only has two. > Unless there are any real-strong opinions against... Yes. ChenYu
Il 23/02/23 03:43, Chen-Yu Tsai ha scritto: > On Wed, Feb 22, 2023 at 5:13 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@collabora.com> wrote: >> >> Il 22/02/23 09:37, Chen-Yu Tsai ha scritto: >>> On Tue, Feb 21, 2023 at 11:37 PM AngeloGioacchino Del Regno >>> <angelogioacchino.delregno@collabora.com> wrote: >>>> >>>> Get GPU support on MT8186 by adding its compatible. >>>> >>>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>>> --- >>>> Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml >>>> index be18b161959b..43a841d4e94d 100644 >>>> --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml >>>> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml >>>> @@ -15,6 +15,11 @@ properties: >>>> >>>> compatible: >>>> oneOf: >>>> + - items: >>>> + - enum: >>>> + - mediatek,mt8186-mali >>>> + - const: mediatek,mt8183b-mali >>>> + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable >>> >>> The MT8186 has Mali-G52 MC2 2EE, while the MT8183 has Mali-G72 MP3. >> >> Keeping in mind the obvious - which is that G52 and G72 are both Bifrost.... >> >>> So we actually need a new entry with two power domains. >>> >> >> ...This is my node for MT8186: >> >> gpu: gpu@13040000 { >> compatible = "mediatek,mt8186-mali", >> "mediatek,mt8183b-mali", >> "arm,mali-bifrost"; >> reg = <0 0x13040000 0 0x4000>; >> >> clocks = <&mfgsys CLK_MFG_BG3D>; >> interrupts = <GIC_SPI 276 IRQ_TYPE_LEVEL_HIGH 0>, >> <GIC_SPI 275 IRQ_TYPE_LEVEL_HIGH 0>, >> <GIC_SPI 274 IRQ_TYPE_LEVEL_HIGH 0>; >> interrupt-names = "job", "mmu", "gpu"; >> power-domains = <&spm MT8186_POWER_DOMAIN_MFG1>, >> <&spm MT8186_POWER_DOMAIN_MFG2>, >> <&spm MT8186_POWER_DOMAIN_MFG3>; >> power-domain-names = "core0", "core1", "core2"; >> >> /* Please ignore speedbin, that's for another time :-) */ >> nvmem-cells = <&gpu_volt_bin>; >> nvmem-cell-names = "speed-bin"; >> #cooling-cells = <2>; >> }; >> >> There are three MFG power domains... MFG2 and MFG3 are parents of MFG1, on that >> I agree, but we can avoid adding a new entry just for MT8186 and use the MT8183-b >> one while still being technically correct. >> >> Besides, Mali G52 and Mali G72 are both Bifrost... so I don't think that this >> commit is incorrect. For the sake of simplicity, I would push on getting this >> one picked. > > I'm aware. In case it wasn't obvious, Mali-G52 MC2 2EE has 2 cores, while > Mali-G72 MP3 has 3 cores. I think that is reason enough to do a new entry. > Otherwise you are describing power domains for 3 cores for a GPU that only > has two. > >> Unless there are any real-strong opinions against... > > Yes. > Ok, I will do that for v3! Cheers, Angelo > ChenYu
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index be18b161959b..43a841d4e94d 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -15,6 +15,11 @@ properties: compatible: oneOf: + - items: + - enum: + - mediatek,mt8186-mali + - const: mediatek,mt8183b-mali + - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable - items: - enum: - amlogic,meson-g12a-mali