Message ID | 20230221120612.27366-2-r-gunasekaran@ti.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1834586wrn; Tue, 21 Feb 2023 04:32:05 -0800 (PST) X-Google-Smtp-Source: AK7set/KKmdufXttz8YfsAKC9Uw1POABLwZL62xyZhTYsbSgdqLoxJdCLradXvhTRZ9yBls6o/Ny X-Received: by 2002:a17:906:b05a:b0:8b1:300f:1bdc with SMTP id bj26-20020a170906b05a00b008b1300f1bdcmr14290616ejb.64.1676982725558; Tue, 21 Feb 2023 04:32:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676982725; cv=none; d=google.com; s=arc-20160816; b=SZizL4SqJCAX4kcn9h868GCMcqPfxl5Jm/Jf3p544jMQ2alATbSOdwl0i7TxhqYhKc HrmIMJ5hjCIHbK7aAE/wO6VKQcPue8Hg0yE79p4UN/TIYp/AHzw4rzigGP5+PBbZM52K g1evvKFC0nr6Yjoe5U4dbP0yONwtn42HKQKnW+iAZiqF7i+mjzOyotAr5Tf7hYdhmNe7 XuvthSq3oJ0xE9MPbXeIPml49qSbR8te52v9kjTI8OctiJ6XMhpP8Btx1Y6zCD2GcYbb uXiD0+WLhOF1cGSE84VHmp2sOeZ7rGGvxiCSHENtoMgdouNCupufQVNJpoFxbt7hQi5H rQ2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=ZgK1Q7UxoYFIJ7lBntlYuht9796aFLvImb8AVSWmmFs=; b=c0BA5WbxCz78/lLLCx2lAbh7smlJGlyDAQUBlrYxhi+5jVQv4Xu7c7+gGRNWU8WjL1 urQef9LtlfHBHDjrhHfFH8kk3v2bibpip7yL8a4NQD9Gjh+tmRoPgI8xhA0E+cfBkphA w4n+Jt7c0lpmVqKx71Eqa79ubUoCP2lCb3dbHL/Xt2dcyoiRzb3dSvB6i+TlYH5KKkx8 4FhMwa6uUHN3dqgizQLwfRU/qANbloaEQJtN0UIhdv5rB8oQqE6xP53dI/KUtBrScWnO Z0TeBdLKrRh+1nVT+Ep9fLSIOiJ/PjmfRWYXN/6mEVvIbJSas9ZwGDYXwlFrBXHXJDJ3 a4tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HwuVv2cy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mf19-20020a1709071a5300b008cd1787c54bsi6907273ejc.167.2023.02.21.04.31.42; Tue, 21 Feb 2023 04:32:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=HwuVv2cy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234245AbjBUMPh (ORCPT <rfc822;kautuk.consul.80@gmail.com> + 99 others); Tue, 21 Feb 2023 07:15:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234429AbjBUMP1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 21 Feb 2023 07:15:27 -0500 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74F2E4499; Tue, 21 Feb 2023 04:14:59 -0800 (PST) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 31LC6KHE021153; Tue, 21 Feb 2023 06:06:20 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1676981180; bh=ZgK1Q7UxoYFIJ7lBntlYuht9796aFLvImb8AVSWmmFs=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=HwuVv2cyqpPmMR792sSOZiB4KU1SyyzuTj/QvWNO/GyaZXqToyzUT7mDWfFNz3lL5 ztkAtJEK/DzETm2cUC/sFplXZEyxsbUoPhVPwVSGQsge4SNmvrkSZRpgVY7JIf2rVI LqWS575u6e0U/gzyV4LR3IHPk5+k00EFNJnbuW0A= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 31LC6KuV125664 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 21 Feb 2023 06:06:20 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 21 Feb 2023 06:06:20 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 21 Feb 2023 06:06:20 -0600 Received: from uda0500640.dal.design.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 31LC6CbO030829; Tue, 21 Feb 2023 06:06:17 -0600 From: Ravi Gunasekaran <r-gunasekaran@ti.com> To: <nm@ti.com>, <afd@ti.com>, <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <s-vadapalli@ti.com>, <r-gunasekaran@ti.com> CC: <linux-arm-kernel@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: [PATCH v10 1/9] dt-bindings: mfd: ti,j721e-system-controller: Fix mux node regex Date: Tue, 21 Feb 2023 17:36:04 +0530 Message-ID: <20230221120612.27366-2-r-gunasekaran@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20230221120612.27366-1-r-gunasekaran@ti.com> References: <20230221120612.27366-1-r-gunasekaran@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758443838029654544?= X-GMAIL-MSGID: =?utf-8?q?1758443838029654544?= |
Series |
arm64: j721s2: Add support for additional IPs
|
|
Commit Message
Ravi Gunasekaran
Feb. 21, 2023, 12:06 p.m. UTC
mux-controller nodes may not have "reg" property. Update the regex
for such nodes to resolve the dtbs warnings
Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com>
---
.../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
Comments
On 17:36-20230221, Ravi Gunasekaran wrote: > mux-controller nodes may not have "reg" property. Update the regex > for such nodes to resolve the dtbs warnings > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) Are you expecting for me to pick this up? Looks like something Lee Jones needs to pick up? He is'nt in the CC either? If Lee Jones is willing to give me an immutable tag, I can pick the same up and pick up dependent patches. Else, please split the series for each of the maintainers to pick up without dependency. > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > index 76ef4352e13c..532bfa45e6a0 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > @@ -45,7 +45,7 @@ properties: > > patternProperties: > # Optional children > - "^mux-controller@[0-9a-f]+$": > + "^mux-controller(@|-)[0-9a-f]+$": > type: object > description: > This is the SERDES lane control mux. > @@ -94,6 +94,12 @@ examples: > /* SERDES4 lane0/1/2/3 select */ > }; > > + usb_serdes_mux: mux-controller-80 { > + compatible = "mmio-mux"; > + #mux-control-cells = <1>; > + mux-reg-masks = <0x0 0x8000000>; > + }; > + > clock-controller@4140 { > compatible = "ti,am654-ehrpwm-tbclk", "syscon"; > reg = <0x4140 0x18>; > -- > 2.17.1 >
On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: > mux-controller nodes may not have "reg" property. Update the regex > for such nodes to resolve the dtbs warnings > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > --- > .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > index 76ef4352e13c..532bfa45e6a0 100644 > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > @@ -45,7 +45,7 @@ properties: > > patternProperties: > # Optional children > - "^mux-controller@[0-9a-f]+$": > + "^mux-controller(@|-)[0-9a-f]+$": Hmm. mmio-mux bindings allow reg property. Why can't we add the same to mux-controller node in 2/9 ? > type: object > description: > This is the SERDES lane control mux. > @@ -94,6 +94,12 @@ examples: > /* SERDES4 lane0/1/2/3 select */ > }; > > + usb_serdes_mux: mux-controller-80 { > + compatible = "mmio-mux"; > + #mux-control-cells = <1>; > + mux-reg-masks = <0x0 0x8000000>; > + }; > + > clock-controller@4140 { > compatible = "ti,am654-ehrpwm-tbclk", "syscon"; > reg = <0x4140 0x18>;
On Tue, Feb 21, 2023 at 8:00 AM Vignesh Raghavendra <vigneshr@ti.com> wrote: > On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: > > mux-controller nodes may not have "reg" property. Update the regex > > for such nodes to resolve the dtbs warnings > > > > Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> > > --- Where's the change history? I doubt I ignored the last 9 versions... > > .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > index 76ef4352e13c..532bfa45e6a0 100644 > > --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml > > @@ -45,7 +45,7 @@ properties: > > > > patternProperties: > > # Optional children > > - "^mux-controller@[0-9a-f]+$": > > + "^mux-controller(@|-)[0-9a-f]+$": > > Hmm. mmio-mux bindings allow reg property. Why can't we add the same to > mux-controller node in 2/9 ? Yes, do that. Rob
On 21/02/23 7:11 pm, Nishanth Menon wrote: > On 17:36-20230221, Ravi Gunasekaran wrote: >> mux-controller nodes may not have "reg" property. Update the regex >> for such nodes to resolve the dtbs warnings >> >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) > > > Are you expecting for me to pick this up? Looks like something > Lee Jones needs to pick up? He is'nt in the CC either? > > If Lee Jones is willing to give me an immutable tag, I can pick the same > up and pick up dependent patches. Else, please split the series for each > of the maintainers to pick up without dependency. > I apologize for the inconvenience. Based on the other review comments in this series, I can update the mux node instead of updating the bindings document. Regardless of it, in future I will take care of sending the patch to the right maintainer. >> >> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> index 76ef4352e13c..532bfa45e6a0 100644 >> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> @@ -45,7 +45,7 @@ properties: >> >> patternProperties: >> # Optional children >> - "^mux-controller@[0-9a-f]+$": >> + "^mux-controller(@|-)[0-9a-f]+$": >> type: object >> description: >> This is the SERDES lane control mux. >> @@ -94,6 +94,12 @@ examples: >> /* SERDES4 lane0/1/2/3 select */ >> }; >> >> + usb_serdes_mux: mux-controller-80 { >> + compatible = "mmio-mux"; >> + #mux-control-cells = <1>; >> + mux-reg-masks = <0x0 0x8000000>; >> + }; >> + >> clock-controller@4140 { >> compatible = "ti,am654-ehrpwm-tbclk", "syscon"; >> reg = <0x4140 0x18>; >> -- >> 2.17.1 >>
On 21/02/23 7:29 pm, Vignesh Raghavendra wrote: > > > On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: >> mux-controller nodes may not have "reg" property. Update the regex >> for such nodes to resolve the dtbs warnings >> >> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >> --- >> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> index 76ef4352e13c..532bfa45e6a0 100644 >> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >> @@ -45,7 +45,7 @@ properties: >> >> patternProperties: >> # Optional children >> - "^mux-controller@[0-9a-f]+$": >> + "^mux-controller(@|-)[0-9a-f]+$": > > Hmm. mmio-mux bindings allow reg property. Why can't we add the same to > mux-controller node in 2/9 ? "reg" property can be added to the mux-controller node. I will do so in the next series > >> type: object >> description: >> This is the SERDES lane control mux. >> @@ -94,6 +94,12 @@ examples: >> /* SERDES4 lane0/1/2/3 select */ >> }; >> >> + usb_serdes_mux: mux-controller-80 { >> + compatible = "mmio-mux"; >> + #mux-control-cells = <1>; >> + mux-reg-masks = <0x0 0x8000000>; >> + }; >> + >> clock-controller@4140 { >> compatible = "ti,am654-ehrpwm-tbclk", "syscon"; >> reg = <0x4140 0x18>;
On 21/02/23 10:34 pm, Rob Herring wrote: > On Tue, Feb 21, 2023 at 8:00 AM Vignesh Raghavendra <vigneshr@ti.com> wrote: >> On 21/02/23 5:36 pm, Ravi Gunasekaran wrote: >>> mux-controller nodes may not have "reg" property. Update the regex >>> for such nodes to resolve the dtbs warnings >>> >>> Signed-off-by: Ravi Gunasekaran <r-gunasekaran@ti.com> >>> --- > > Where's the change history? I doubt I ignored the last 9 versions... This change was added newly in v8. But based on the review comments, dtbs warnings can be fixed without changes to bindings document. So this patch will be dropped in the next series. Ravi > >>> .../bindings/mfd/ti,j721e-system-controller.yaml | 8 +++++++- >>> 1 file changed, 7 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> index 76ef4352e13c..532bfa45e6a0 100644 >>> --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml >>> @@ -45,7 +45,7 @@ properties: >>> >>> patternProperties: >>> # Optional children >>> - "^mux-controller@[0-9a-f]+$": >>> + "^mux-controller(@|-)[0-9a-f]+$": >> >> Hmm. mmio-mux bindings allow reg property. Why can't we add the same to >> mux-controller node in 2/9 ? > > Yes, do that. > > Rob
diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml index 76ef4352e13c..532bfa45e6a0 100644 --- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml +++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml @@ -45,7 +45,7 @@ properties: patternProperties: # Optional children - "^mux-controller@[0-9a-f]+$": + "^mux-controller(@|-)[0-9a-f]+$": type: object description: This is the SERDES lane control mux. @@ -94,6 +94,12 @@ examples: /* SERDES4 lane0/1/2/3 select */ }; + usb_serdes_mux: mux-controller-80 { + compatible = "mmio-mux"; + #mux-control-cells = <1>; + mux-reg-masks = <0x0 0x8000000>; + }; + clock-controller@4140 { compatible = "ti,am654-ehrpwm-tbclk", "syscon"; reg = <0x4140 0x18>;