Message ID | 20221022070527.55960-1-wangjianli@cdjrlc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1086194wrr; Sat, 22 Oct 2022 00:32:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5d2gsuk03klWKUI4yObSHTXPL3fBjlTrunwg6nF0+1pC60OTuQuoC6C6CoENlj6hfQXDfG X-Received: by 2002:a17:90b:1916:b0:212:c87e:d5cc with SMTP id mp22-20020a17090b191600b00212c87ed5ccmr10213927pjb.45.1666423970682; Sat, 22 Oct 2022 00:32:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666423970; cv=none; d=google.com; s=arc-20160816; b=YxE5CF+EIEqYRuiTZc+RSqCsTf1+CUpcaIOFZDP1dsMFRYwT1Cm/DPudF0NY8GWqvI S+psbu5DsqBnV4retxZDrceyVw+/FsvAzt97J39v1IisqZ1DQR9VC78LsrBTDtxkal8G +hcWhIQ+7xIH4xz+0l235vf7SUlsWyw3IKpGfOFissQuxQ6wyPEVr+p2ppEyi6qdk/Ay XiY7NLqbGJrjfnQ0W4o5hClBI2EcPS7gWqs+9A8Tbq13xmvAG3bbesYoZC7f9TOvsHDi L2vZNYWBTEnT6BsdTCeWcIUki3szgpQ71Ge0fZODCVFBS3A2IrRrPmOpo4+IAUySvj/a 8aSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from; bh=rfmnFsQr/8AqlHgEvCl57invPMx1rn1excFmwmcLwlo=; b=i379Dc++1Tzo1Ll1KK6sNTJJ8MNdOThdPI+qH9EohrqwQMyy/0EZdiQ6n3CQT4yJQt dO40fAdZOpZ5897XCEz/B8u4+KwCF7NOw1r8IGlbzV2O0Kjg22qlzhX0zlWEF80DHgE+ XZzl4tF4ZsMfAOJjR79hmhVJTiMvRDKx937rXOPZZ66A7ONXsaliOudg5NtBQ6RoXF/w Yy4H6TAdIYADgKO0bV82avW3WqriCMRk3dCMlekWe3JnZ+HGV3Aw0hc2j8Pu/FYnVj/r jGD7wpvMknzMqM+nj+JMHxyNzNq2ZlybgzJ/vKHJKWIEyXtDyX5yeiUk1asz4K3mCMSU s83Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f11-20020a056a001acb00b005614fb190e4si30925537pfv.193.2022.10.22.00.32.38; Sat, 22 Oct 2022 00:32:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbiJVHGC (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Sat, 22 Oct 2022 03:06:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229845AbiJVHGB (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 22 Oct 2022 03:06:01 -0400 Received: from bg4.exmail.qq.com (bg4.exmail.qq.com [43.154.221.58]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C4D02514D8; Sat, 22 Oct 2022 00:05:58 -0700 (PDT) X-QQ-mid: bizesmtp66t1666422335tdg4ve7k Received: from localhost.localdomain ( [182.148.15.254]) by bizesmtp.qq.com (ESMTP) with id ; Sat, 22 Oct 2022 15:05:33 +0800 (CST) X-QQ-SSF: 01000000000000C0E000000A0000000 X-QQ-FEAT: RFp2QSjOiS4sGX3HAs81Q2QTczxO4ZkgFMtpFaapn6fA4oCND6P3j/fp47kxt 291qxxZRtD6dXgOXME4Q55/OSn2dEnfAGHIZVhafF8eBihENSLcXZWgY31Ytvh3y4ZqoWU5 /5lLxsIYiwDqhrdwI1OiLgYMp6JQRhqfYDGspBZbY0A5/AtzaZVxSZDcMyKimastzpWi65m XppZM/NakT3q2vnFNOU+obvh9UmubpNV+17Kv/Wc2CTpuLuvsNdzMtN+nZzuE8jagX9TvsE Ltu/klACCgwo7MQhb4VRvnxbcv1StnfAgz2JRyhH6qTciXhSfWMSjbqVrjYURrvg7AOVpVK JofZOV8+kJ9UDXgh5ranmpgcRVkO0OCH+i6J9Zix8x8xnioTYFLfjfL67coiw== X-QQ-GoodBg: 0 From: wangjianli <wangjianli@cdjrlc.com> To: mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev, linux-kernel@vger.kernel.org, wangjianli <wangjianli@cdjrlc.com> Subject: [PATCH] net/mptcp: fix repeated words in comments Date: Sat, 22 Oct 2022 15:05:27 +0800 Message-Id: <20221022070527.55960-1-wangjianli@cdjrlc.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:cdjrlc.com:qybglogicsvr:qybglogicsvr7 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747372181447441290?= X-GMAIL-MSGID: =?utf-8?q?1747372181447441290?= |
Series |
net/mptcp: fix repeated words in comments
|
|
Commit Message
wangjianli
Oct. 22, 2022, 7:05 a.m. UTC
Delete the redundant word 'the'.
Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
---
net/mptcp/token.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote: > Delete the redundant word 'the'. > > Signed-off-by: wangjianli <wangjianli@cdjrlc.com> > --- > net/mptcp/token.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/mptcp/token.c b/net/mptcp/token.c > index f52ee7b26aed..b817c2564300 100644 > --- a/net/mptcp/token.c > +++ b/net/mptcp/token.c > @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock); > * This function returns the first mptcp connection structure found inside the > * token container starting from the specified position, or NULL. > * > - * On successful iteration, the iterator is move to the next position and the > + * On successful iteration, the iterator is move to the next position and > * the acquires a reference to the returned socket. > */ > struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot, NAK! Instead, slightly reword the comment above as "On successful iteration, the iterator moves to the next position and acquires a reference to the returned socket.". Also, you and other @cdjrlc.com developers ignore reviews that request changes to your patches. If you want to participate in kernel development community, please don't just sending random patches without any sort of reply. I have pointed out this behavior either as part of my review or as reply to reviews from other developers. I may write this as final warning before I just say NAK without further ado to your future patches. Thanks.
On Sun, 23 Oct 2022, Bagas Sanjaya wrote: > On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote: >> Delete the redundant word 'the'. >> >> Signed-off-by: wangjianli <wangjianli@cdjrlc.com> >> --- >> net/mptcp/token.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/mptcp/token.c b/net/mptcp/token.c >> index f52ee7b26aed..b817c2564300 100644 >> --- a/net/mptcp/token.c >> +++ b/net/mptcp/token.c >> @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock); >> * This function returns the first mptcp connection structure found inside the >> * token container starting from the specified position, or NULL. >> * >> - * On successful iteration, the iterator is move to the next position and the >> + * On successful iteration, the iterator is move to the next position and >> * the acquires a reference to the returned socket. >> */ >> struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot, > > NAK! > > Instead, slightly reword the comment above as "On successful iteration, > the iterator moves to the next position and acquires a reference to the > returned socket.". > Agree on this rewording. This particular duplicated word came up before, and I thought it would be best if the author sent a v2 - but they never did. I will fix this in the MPTCP tree next week if there's no suitable v2 by then. -- Mat Martineau Intel
diff --git a/net/mptcp/token.c b/net/mptcp/token.c index f52ee7b26aed..b817c2564300 100644 --- a/net/mptcp/token.c +++ b/net/mptcp/token.c @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock); * This function returns the first mptcp connection structure found inside the * token container starting from the specified position, or NULL. * - * On successful iteration, the iterator is move to the next position and the + * On successful iteration, the iterator is move to the next position and * the acquires a reference to the returned socket. */ struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,