Message ID | 20221023091247.70586-4-linux@fw-web.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp1537763wrr; Sun, 23 Oct 2022 02:16:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4cjGKvKttNz2JUPczygZBx48sSC14VE79RPP2GPRSON0tHvAgEZKKvREMqAzOaOeKcZCWN X-Received: by 2002:a17:90b:2751:b0:20a:e437:a9e8 with SMTP id qi17-20020a17090b275100b0020ae437a9e8mr66796347pjb.181.1666516571877; Sun, 23 Oct 2022 02:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666516571; cv=none; d=google.com; s=arc-20160816; b=He2mMQwVHrYqun3Xf7JHI9ArHlvLbtEzQZD8ttdogWKg547/qf8Ge25bkCQR34zLO/ Ly+Q2EKtmjJP9MvsyVrRLerkQi0X8bzYL0Tt9AblsZmmjpsKIuAG+KlgCXA2em1U9mJE Muv4LpBz4DOmdUEPQ0y8X9xGjBhOt1B6Srqm8Dqpivw/w/g3WUrtNmryN9q9R4xGFksC DdVVyNNYz8tJoYMJyaMdOw8MFRDEiQOC+gEsmkvwWLmVK10/yvp0wrQJ1bX1RXoark2w k56cLw2Xs1n9hD4ovO2K+cffutPRi7fkP0pshO8wLtUI1ZnzOHbUjQJnE2LrSHkBlVkJ QyLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=JDj+3jeCqCcaeTvzPHxQEqBQy4Ab6T3C2f1XrCtCwA0=; b=BIZA+T5f09/X+V2o0oy0i8MfLBg8YZPCxVavuoxiFxY7B8uvlOc+bpGu7V7x5vaKgY gYYqdnpAfEP5I0Il64Zx6svFx1FshWJw9x8a0dJ/49JwW07Vq2LcP6v4/zgOOHT7ay4n b7UXrQaDZ1O1lGzz9dEaxL38PliHCNQNHXmPH8oPDjvxOD6dilBcfERpNJeD69F7q2OA 0aGUWIj4C4IrsE4ZcajkvkeHfPglnbkHo706POez/59YsHvQXovZxKeryiEA3KSZQ1de H/IyV2xOCHSjw3YLPkN4pn3oTHQLJIw0wIhfscFGVCk2vx5lfEhj9ghDUzO2b1nvekQI 2EEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=RRfjCUWB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g20-20020a056a000b9400b00541505b05dbsi33438548pfj.31.2022.10.23.02.15.59; Sun, 23 Oct 2022 02:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mailerdienst.de header.s=20200217 header.b=RRfjCUWB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230101AbiJWJNh (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Sun, 23 Oct 2022 05:13:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbiJWJNS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 23 Oct 2022 05:13:18 -0400 Received: from mxout2.routing.net (mxout2.routing.net [IPv6:2a03:2900:1:a::b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9768F72ECD; Sun, 23 Oct 2022 02:13:13 -0700 (PDT) Received: from mxbox2.masterlogin.de (unknown [192.168.10.89]) by mxout2.routing.net (Postfix) with ESMTP id 60D6F5FC39; Sun, 23 Oct 2022 09:13:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1666516391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JDj+3jeCqCcaeTvzPHxQEqBQy4Ab6T3C2f1XrCtCwA0=; b=RRfjCUWBMEhto+cDXh0RUPXtNVen8lXp88tVQwu6h24gptDD1yaCcNVtbB8T848DAIUhTV B1/eptn3ZnNVIox+5zG0liRrlT0YaSrSTX1pI1WV1JlWTglLK53ziBE+T/6+UgTi/0aPnw VuVOp2/t8fquuWpyMa2jtIfXeyPyEjk= Received: from frank-G5.. (fttx-pool-80.245.79.234.bambit.de [80.245.79.234]) by mxbox2.masterlogin.de (Postfix) with ESMTPSA id 9FC6010031F; Sun, 23 Oct 2022 09:13:10 +0000 (UTC) From: Frank Wunderlich <linux@fw-web.de> To: linux-mediatek@lists.infradead.org Cc: Frank Wunderlich <frank-w@public-files.de>, Chaotian Jing <chaotian.jing@mediatek.com>, Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Matthias Brugger <matthias.bgg@gmail.com>, Wenbin Mei <wenbin.mei@mediatek.com>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986 Date: Sun, 23 Oct 2022 11:12:43 +0200 Message-Id: <20221023091247.70586-4-linux@fw-web.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221023091247.70586-1-linux@fw-web.de> References: <20221023091247.70586-1-linux@fw-web.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Mail-ID: 1f513a30-b000-40b2-a634-bdc6344441f7 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747469280972938393?= X-GMAIL-MSGID: =?utf-8?q?1747469280972938393?= |
Series |
Add mmc-support for mt7986
|
|
Commit Message
Frank Wunderlich
Oct. 23, 2022, 9:12 a.m. UTC
From: Frank Wunderlich <frank-w@public-files.de> Add SoC specific section for defining clock configuration. Signed-off-by: Frank Wunderlich <frank-w@public-files.de> --- v3: - drop assigned-clocks/assigned-clock-parents - fix clock description --- .../devicetree/bindings/mmc/mtk-sd.yaml | 23 +++++++++++++++++++ 1 file changed, 23 insertions(+)
Comments
On 23/10/2022 05:12, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add SoC specific section for defining clock configuration. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi > Gesendet: Sonntag, 23. Oktober 2022 um 14:56 Uhr > Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> > An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org > Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Chaotian Jing" <chaotian.jing@mediatek.com>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Wenbin Mei" <wenbin.mei@mediatek.com>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org > Betreff: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986 > > On 23/10/2022 05:12, Frank Wunderlich wrote: > > From: Frank Wunderlich <frank-w@public-files.de> > > > > Add SoC specific section for defining clock configuration. > > > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Hi, got another config from mtk which requires changing binding a bit clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, <&infracfg CLK_INFRA_MSDC_HCK_CK>, <&infracfg CLK_INFRA_MSDC_CK>, <&infracfg CLK_INFRA_MSDC_133M_CK>, <&infracfg CLK_INFRA_MSDC_66M_CK>; clock-names = "source", "hclk", "source_cg", "bus_clk", "sys_cg"; in binding: +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -241,15 +241,17 @@ allOf: items: - description: source clock - description: HCLK which used for host - - description: AXI bus clock gate - - description: AHB bus clock gate + - description: independent source clock gate + - description: bus clock used for internal register access (required for MSDC0/3). + - description: msdc subsys clock gate clock-names: minItems: 3 items: - const: source - const: hclk - - const: axi_cg - - const: ahb_cg + - const: "source_cg" + - const: "bus_clk" + - const: "sys_cg" will send an updated v4...old version was working but i should use the new one. @Krzysztof can i take your RB here or should i leave it as Patch was changed? regards Frank
On 24/10/2022 10:55, Frank Wunderlich wrote: > Hi > >> Gesendet: Sonntag, 23. Oktober 2022 um 14:56 Uhr >> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> >> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org >> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Chaotian Jing" <chaotian.jing@mediatek.com>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Wenbin Mei" <wenbin.mei@mediatek.com>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org >> Betreff: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986 >> >> On 23/10/2022 05:12, Frank Wunderlich wrote: >>> From: Frank Wunderlich <frank-w@public-files.de> >>> >>> Add SoC specific section for defining clock configuration. >>> >>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de> >> >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Hi, > > got another config from mtk which requires changing binding a bit > > clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>, > <&infracfg CLK_INFRA_MSDC_HCK_CK>, > <&infracfg CLK_INFRA_MSDC_CK>, > <&infracfg CLK_INFRA_MSDC_133M_CK>, > <&infracfg CLK_INFRA_MSDC_66M_CK>; > clock-names = "source", "hclk", "source_cg", "bus_clk", > "sys_cg"; > in binding: > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -241,15 +241,17 @@ allOf: > items: > - description: source clock > - description: HCLK which used for host > - - description: AXI bus clock gate > - - description: AHB bus clock gate > + - description: independent source clock gate > + - description: bus clock used for internal register access (required for MSDC0/3). > + - description: msdc subsys clock gate > clock-names: > minItems: 3 > items: > - const: source > - const: hclk > - - const: axi_cg > - - const: ahb_cg > + - const: "source_cg" > + - const: "bus_clk" > + - const: "sys_cg" > > will send an updated v4...old version was working but i should use the new one. > > @Krzysztof can i take your RB here or should i leave it as Patch was changed? Please drop my tag, so I will re-review it. Thanks! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index 31bb6dc329d2..17b346a60e4c 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -228,6 +228,29 @@ allOf: - const: source_cg - const: bus_clk + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt7986-mmc + then: + properties: + clocks: + minItems: 3 + items: + - description: source clock + - description: HCLK which used for host + - description: AXI bus clock gate + - description: AHB bus clock gate + clock-names: + minItems: 3 + items: + - const: source + - const: hclk + - const: axi_cg + - const: ahb_cg + - if: properties: compatible: