| Message ID | 20230208011742.5183-1-zeming@nfschina.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2122956wrn;
Mon, 6 Feb 2023 00:47:52 -0800 (PST)
X-Google-Smtp-Source:
AK7set861fezHsYChanK1GqF2VtmL/NInf5gYpma86loChOzGTP2gEdmf0JDSG/iN0DTBmGxWU4u
X-Received: by 2002:a17:902:e881:b0:197:8e66:6335 with SMTP id
w1-20020a170902e88100b001978e666335mr24555138plg.20.1675673272536;
Mon, 06 Feb 2023 00:47:52 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675673272; cv=none;
d=google.com; s=arc-20160816;
b=FeimJdITUkLrmmMW0rQB0HKHwBXXJoq0BtC5YDVhx2i7XR4oKVyBgAORGI6Dr+Ugg6
pz56336wVX8vdWkOkKXP39TH3fKaKOikub6quyfHYdNR4VhzSTji0wcMbzhVVwyTfgmA
VZez0VKziZyLnBCmrUJOzlogq4fe0slh6Eptxr49ccvddTCb3ZUbUFmavGV341SN8igX
1LT1klqNTOfY/qZKu6LWoEUwwDBZ75z097LBhT2ZnT4N16B5HuUoFpDMMshZJORFMqHY
3eVzsmHHD+Yw3HOuibbaIzfaUGTrtdEKkatctUWQHl+a/dg7AKmj4Nyqyi06sF0KEqzG
VLVQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=5xZ8lcPHTrqbkBZ8UA4TzvRrpavOekH60jRXKQbUiq8=;
b=Os7rFdq2VJ9E9Ubilk+O1dCimwxzo13kj0ta2kpRlltGDQarFGTNsvszcmWoiJ2lki
uREpn+nMHSoVOTXu28Bl+uv43bHlBfe8ZzbI/Apq8TOfBPfAAHZMlruW3a+SHZfCcQfv
cDKBFpyCZBrJyTmMIVXUW1FG3oF3WH81JKdsuqZihbQ31BA4VT1OnM4ow/aSB2YrKZ0l
aJhYr9lYvEgHbmCogMdGjcjBbImtfmfYQ/JosqkZmeflDyw6MyCOQFzphoPAm2ynsbJQ
EX158Jr62ncYWR8tmvUKRzUhOkodRGdkukX02326kIABgGvQsJA0WOaq8VN8/hWRUR47
LF3g==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
z23-20020a1709028f9700b00189659458a3si10752843plo.455.2023.02.06.00.47.18;
Mon, 06 Feb 2023 00:47:52 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229784AbjBFIq2 (ORCPT <rfc822;kmanaouilinux@gmail.com>
+ 99 others); Mon, 6 Feb 2023 03:46:28 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34116 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229458AbjBFIq0 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 6 Feb 2023 03:46:26 -0500
Received: from mail.nfschina.com (unknown [42.101.60.237])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84C024C3D;
Mon, 6 Feb 2023 00:46:24 -0800 (PST)
Received: from localhost (unknown [127.0.0.1])
by mail.nfschina.com (Postfix) with ESMTP id 8B4581A00A6C;
Mon, 6 Feb 2023 16:46:53 +0800 (CST)
X-Virus-Scanned: amavisd-new at nfschina.com
Received: from mail.nfschina.com ([127.0.0.1])
by localhost (localhost.localdomain [127.0.0.1]) (amavisd-new,
port 10024)
with ESMTP id x_B4fx6T-QN3; Mon, 6 Feb 2023 16:46:52 +0800 (CST)
Received: from localhost.localdomain (unknown [219.141.250.2])
(Authenticated sender: zeming@nfschina.com)
by mail.nfschina.com (Postfix) with ESMTPA id B29971A00854;
Mon, 6 Feb 2023 16:46:52 +0800 (CST)
From: Li zeming <zeming@nfschina.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Li zeming <zeming@nfschina.com>
Subject: [PATCH] =?utf-8?q?fs-writeback=3A_remove_unnecessary_=E2=80=98false?=
=?utf-8?q?=E2=80=99_values_from_wakeup=5Fbdi?=
Date: Wed, 8 Feb 2023 09:17:42 +0800
Message-Id: <20230208011742.5183-1-zeming@nfschina.com>
X-Mailer: git-send-email 2.18.2
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_24_48,
RDNS_NONE,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757070777252159074?=
X-GMAIL-MSGID: =?utf-8?q?1757070777252159074?=
|
| Series |
fs-writeback: remove unnecessary ‘false’ values from wakeup_bdi
|
|
Commit Message
Li zeming
Feb. 8, 2023, 1:17 a.m. UTC
wakeup_bdi does not need to be initialized. It is used after being
assigned.
Signed-off-by: Li zeming <zeming@nfschina.com>
---
fs/fs-writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed 08-02-23 09:17:42, Li zeming wrote: > wakeup_bdi does not need to be initialized. It is used after being > assigned. > > Signed-off-by: Li zeming <zeming@nfschina.com> Looks good to me. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/fs-writeback.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 6fba5a52127b..2d3191d9c736 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -2486,7 +2486,7 @@ void __mark_inode_dirty(struct inode *inode, int flags) > */ > if (!was_dirty) { > struct list_head *dirty_list; > - bool wakeup_bdi = false; > + bool wakeup_bdi; > > inode->dirtied_when = jiffies; > if (dirtytime) > -- > 2.18.2 >
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 6fba5a52127b..2d3191d9c736 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -2486,7 +2486,7 @@ void __mark_inode_dirty(struct inode *inode, int flags) */ if (!was_dirty) { struct list_head *dirty_list; - bool wakeup_bdi = false; + bool wakeup_bdi; inode->dirtied_when = jiffies; if (dirtytime)