Message ID | 20230217093128.8344-1-mike.looijmans@topic.nl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp807261wrn; Fri, 17 Feb 2023 02:20:44 -0800 (PST) X-Google-Smtp-Source: AK7set/q4HJCD8DSkZoG3/yusH+ZzxFhR9s+hddQTsHTU49bkn7l+n06Tpe9/SFfRFKj8i3D20Bl X-Received: by 2002:a17:906:bcd8:b0:8b1:2bde:5c70 with SMTP id lw24-20020a170906bcd800b008b12bde5c70mr252462ejb.2.1676629244503; Fri, 17 Feb 2023 02:20:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676629244; cv=none; d=google.com; s=arc-20160816; b=IJ3eUjAN809z3/XtzpZQZHL/BZ0fQWaxKV4SG9FdPdzHfQIo3rRodqDx893H/q8DER GcX5itk+wN6iv4pX22ydYrtNnzoIQPwaCqGvbqdhK6A+5vV3WSgGF3Skb2vQRqhLuzbv v5qmYQPXOnfYuAcc9fUD0zQxxbGXjgItytJ2uTTekk1nJShLcy+EOlrIksFTiuMTdbyQ aQ2j/vorSa250kV22dBGAl7uqF2DwssXser2KY/e5sMvBErz1+ZYWIfRZ4JPVI7fDJj4 8H8lGdZrzU2mHj97lH0H5GMgXkXaLvkuDtrjeRtv+63vThI7ylHhggPoprpdVcbqlg/Z QuIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=MbxvnQilIOs48R7ZleR0Uv9rKT5Z6nPrAsNCyMhJVGM=; b=0KoIkVipe9BRfmfQJ0G0Fe18Tbf6fX/P3Ow/c0BSeKm1mwGA7IWpPdn43pPP/vTUwh dTUyyQgRQUiTO01nCUFbr+sh37U8ysizMZHKc9F+8cH4nJoLJcfBaVbAME5WtfoexHsi 5bBea+09Gekq/a2zJIK524PlEWZXHmgTTTDZ/1T8swJ2PCqvQZ6XT9zI7WN9MGhTz7mJ lk1RgZGutmdmrRv2e+DRrpNg4TBfI7UYfgoeimgFgTeC/FseoLvq4mUU+qdluGcm1jWN ZIvxfgcLQNE126vGkdYNxzGUk2L491wNj7ZKoUFrPU/2MeMQn7I2WSryN+OqGwYvgT86 qFgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j9-20020a170906534900b008b17aa97586si3268571ejo.623.2023.02.17.02.20.20; Fri, 17 Feb 2023 02:20:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229706AbjBQJ7j (ORCPT <rfc822;aimixsaka@gmail.com> + 99 others); Fri, 17 Feb 2023 04:59:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbjBQJ7Z (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 17 Feb 2023 04:59:25 -0500 X-Greylist: delayed 1649 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 17 Feb 2023 01:59:16 PST Received: from spamfilter04.delta.nl (spamfilter04.delta.nl [217.102.255.204]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EC615DE1B; Fri, 17 Feb 2023 01:59:16 -0800 (PST) Received: from host-ubmmyvj.static.zeelandnet.nl ([217.102.255.198] helo=mail.zeelandnet.nl) by spamfilter04.delta.nl with esmtp (Exim 4.92) (envelope-from <mike.looijmans@topic.nl>) id 1pSx5g-0002F2-96; Fri, 17 Feb 2023 10:31:57 +0100 X-Sender-IP: 204.168.188.16 Received: from phenom.domain_not_set.invalid (016-188-168-204.dynamic.caiway.nl [204.168.188.16]) (Authenticated sender: glasveze@delta.nl) by mail.zeelandnet.nl (Postfix) with ESMTPA; Fri, 17 Feb 2023 10:31:28 +0100 (CET) From: Mike Looijmans <mike.looijmans@topic.nl> To: devicetree@vger.kernel.org, linux-iio@vger.kernel.org Cc: Mike Looijmans <mike.looijmans@topic.nl>, Jonathan Cameron <jic23@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: iio: adc: Add driver for TI ADS1100 and ADS1000 Date: Fri, 17 Feb 2023 10:31:27 +0100 Message-Id: <20230217093128.8344-1-mike.looijmans@topic.nl> X-Mailer: git-send-email 2.17.1 X-Originating-IP: 217.102.255.198 X-DELTA-Domain: zeelandnet.nl X-DELTA-Username: 217.102.255.198 Authentication-Results: delta.nl; auth=pass smtp.auth=217.102.255.198@zeelandnet.nl X-DELTA-Outgoing-Class: ham X-DELTA-Outgoing-Evidence: Combined (0.04) X-Recommended-Action: accept X-Filter-ID: Pt3MvcO5N4iKaDQ5O6lkdGlMVN6RH8bjRMzItlySaT/JtpJ85U5oQJKJbxIe8gTePUtbdvnXkggZ 3YnVId/Y5jcf0yeVQAvfjHznO7+bT5xzeemUa7CfwmLuWRw6Ruql9Wrt/oF2ofKYeezPZTW+uL/H seNZtCKdSRRS0Op9pfwEIJgF/Accv4lLtE4TWYNIjgZ0d6t6F7vRFkkblm+Z5L7uq2AYbiB7eX7C A0Ee9FXnLqvnkE9k+JY3j0cID29DoODujL6FEsNqPMBZcb5VIYa36rQUNKpqI1Q4bofNkWUu8fTD ZLzKN6k+QrhjNGJv3vMX8kxfmgvnPiAPWmoBuxmBwTME+9GFGInGiou45HNmtfv+FqJdBAzMzmkl 3RebQxyzcaJWgnTP1X4liYqSLtlnibl3vcBqVmvQB4A18adDnQKevvKDWdWJ/wxJwe8KAVXirbLu Jjy3NtnGWLbnBD5wBOYayDY3tUZW3y7uaAiYA/VUAhdIJZFus1IsgsCDrtkUVrXMjRtSszqFofHQ kL+CgfasVEKELzhStrT89iLQPrbYmyedRWSaH5Jq+f9dFu3a+YmrU6Iy71ckAFY+TtvrQQT37tVB F8TuA2zDxdadd1WxHO/mLVgwAb47uaav6rkstLAf90f4v3S1FulD9czOuJQrulh5Fko3Tg7NaUQc YIYdvv9xV5Ex49z0ZSNkjgZ0d6t6F7vRFkkblm+Z5MW9qS2/3RCT5H9A6khsXlWGs9HjdrlYbXkZ KU5GQmOJZsmqX57B1EDhkm+xMEreF4WyYiqdZEM01eRU4ONdoVEFBfQHNmmYaIBwRgEu+hlkUryY cSJLFEwVd01VIyXuC84PLa7Kvs1vJgz+jb+KUZ4ZI4crFqIiLO9pmeAxg3M8BMj+y2IddO0/FlXY D8b+M8bPMsyA7EJ+U7NdS2YrNZ05xOYqJ9Tq2b0GjLr7lMbCJ9uFCwxUz+7mzjTsriXxHrjdWiOx jT+Uoc44sbCX7JxqjLaXu1AD0YHYM/EUhlEfE6TG2ORqQuRwhOvtgDJH0WotQdu7BL5WjlV6WURt Nxb4RqrqGwDerCVKfZxBaa6lpe1/5cEtgGt7CHfC+dbEjaN+/GAFlUDQdIxEvZe3STQUwRm7JL7H UFLEjZ4tI2w6weBlgtnhN6vUJqrLQEcK+vPvzy/hTW1WrcVDSDSSDu0wxuDU9J+Dmr/6e4fImcm4 9R/2gMGq0KWAzmMf+ibVDqLZPzE7W9Cqnhlc7GZSDtYOqFKIG2trlPUTQYEjbgmVnZqbKIaNWdFw SHKOTj4XQZ8i4WqksVTtjhZSepuHki+xkgmaS1TA/Dv/4AHP2EFtNptbHtgZAQM3rG32ibSwsxBN fS19KOA46lF/j0xwFgg= X-Report-Abuse-To: spam@spamfilter03.delta.nl X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_FAIL, SPF_HELO_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758070693863306084?= X-GMAIL-MSGID: =?utf-8?q?1758073187108515296?= |
Series |
[1/2] dt-bindings: iio: adc: Add driver for TI ADS1100 and ADS1000
|
|
Commit Message
Mike Looijmans
Feb. 17, 2023, 9:31 a.m. UTC
The ADS1100 is a 16-bit ADC (at 8 samples per second).
The ADS1000 is similar, but has a fixed data rate.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
.../bindings/iio/adc/ti,ads1100.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml
Comments
On Fri, 17 Feb 2023 10:31:27 +0100, Mike Looijmans wrote: > The ADS1100 is a 16-bit ADC (at 8 samples per second). > The ADS1000 is similar, but has a fixed data rate. > > Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > > --- > > .../bindings/iio/adc/ti,ads1100.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/ti,ads1100.example.dtb: adc@49: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230217093128.8344-1-mike.looijmans@topic.nl The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Thanks I've fixed the issues and will send a v2 soon. PS: Sorry for top-posting, it's to avoid our mail server messing things up. Met vriendelijke groet / kind regards, Mike Looijmans System Expert TOPIC Embedded Products B.V. Materiaalweg 4, 5681 RJ Best The Netherlands T: +31 (0) 499 33 69 69 E: mike.looijmans@topicproducts.com W: www.topic.nl Please consider the environment before printing this e-mail On 17-02-2023 10:36, Krzysztof Kozlowski wrote: > On 17/02/2023 10:31, Mike Looijmans wrote: >> The ADS1100 is a 16-bit ADC (at 8 samples per second). >> The ADS1000 is similar, but has a fixed data rate. > Subject: Drop "driver for" > >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> >> >> --- >> >> .../bindings/iio/adc/ti,ads1100.yaml | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml >> >> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml >> new file mode 100644 >> index 000000000000..ad30af8453a1 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml >> @@ -0,0 +1,37 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/iio/adc/ti,ads1100.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: TI ADS1100/ADS1000 single channel I2C analog to digital converter >> + >> +maintainers: >> + - Mike Looijmans <mike.looijmans@topic.nl> >> + >> +description: | >> + Datasheet at: https://www.ti.com/lit/gpn/ads1100 >> + >> +properties: >> + compatible: >> + enum: >> + - ti,ads1100 >> + - ti,ads1000 > Does not look like you tested the bindings. Please run `make > dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml new file mode 100644 index 000000000000..ad30af8453a1 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads1100.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/ti,ads1100.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: TI ADS1100/ADS1000 single channel I2C analog to digital converter + +maintainers: + - Mike Looijmans <mike.looijmans@topic.nl> + +description: | + Datasheet at: https://www.ti.com/lit/gpn/ads1100 + +properties: + compatible: + enum: + - ti,ads1100 + - ti,ads1000 + +required: + - compatible + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + adc@49 { + compatible = "ti,ads1100"; + reg = <0x49>; + }; + }; +...