Message ID | 20221021190908.1502026-4-nfraprado@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp862739wrr; Fri, 21 Oct 2022 12:15:21 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5qHVegkiadOq/1u283LXbmbuePNoeDXYxLe3JJijYIz3cm3l51zp1JWv3cl7oU9dbwi9rP X-Received: by 2002:a17:906:5a4b:b0:78d:8790:d4a1 with SMTP id my11-20020a1709065a4b00b0078d8790d4a1mr16855448ejc.329.1666379720938; Fri, 21 Oct 2022 12:15:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666379720; cv=none; d=google.com; s=arc-20160816; b=0zrXZQoCoRd51VMj+8AsuAOCCw2EGCedmJMBBiufkIDIQx4CdERpG8qLffSpSzrSJ+ ol/rDkvDEg4WfvxABG0LyczDh8bch/jdyWR2EvFV2S0FLVRPxNS4dzQJQTlaOtJ5UHt1 bcFL1+JmS0de4uIiOksN7j+OU82lAlCZsaLjbFQrsdqaIZ5CJjxcv1gdgnDW6a8rLSJW NdSvV9+DyoLpQgO0ifwiWRrRRedgnWKsSJ921NUpSWLRcIvi6Cb/PU31SleitJCF+3Cc WJPupiA7iXSRfA0FBQt5kOVGWXsY1qYrsnFEthRz7zT50vnh1/ICnZ4GXuXKiXxkDKWY fotw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=o3B3F+hqIF9cDFrppKwZLjlAfIfqWCTJxql7yekMKws=; b=EtIQKghlhRR1gTV4U8OBf1CL0zfNLLAKOXvdE5cKzClXSUh+AYSVofbULKmoaSA5AI XI/m4LFVvP9rYoh0mzXtPDYi98ouu7Kws0xmkThZNBGZkp9ouow8LI0UKogInVoLEUND EGmCYjjTTCvrSLexrILXFOXUDN6RMWAKpedGhumzLUq6Rjq8I249meNTx+p4jgJ4S6cV QZwsVVvYwwLKxP51BdOWPKE/apRSG+R47ciXkM5Ii1dMn8h8mfG7t5aAhu0yvC81ErqE OrfRy5h6pD1kplidfq8LnBFgYPFV0jR8v1EqfhYbEhHJtmT6MVsHp1BbZNlSG1njtX7N lFfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=f7Q8hxro; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga13-20020a1709070c0d00b0073daf6b44a5si21107667ejc.775.2022.10.21.12.14.56; Fri, 21 Oct 2022 12:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=f7Q8hxro; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230310AbiJUTJf (ORCPT <rfc822;mntrajkot1@gmail.com> + 99 others); Fri, 21 Oct 2022 15:09:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbiJUTJU (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Oct 2022 15:09:20 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BDA96174E; Fri, 21 Oct 2022 12:09:19 -0700 (PDT) Received: from notapiano.myfiosgateway.com (unknown [IPv6:2600:4041:5b1a:cd00:524d:e95d:1a9c:492a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0F2B866025DF; Fri, 21 Oct 2022 20:09:16 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1666379358; bh=TSzB9s/nYLhBExyStCN6t0/NJr0MxrTNQOpVLK8HItQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f7Q8hxrolHCXqkoQxqQfkVh/NJ6dOT90S8sE0RxXfxzzzpq92P9/xuguTgU8NEqn4 rAG0Ea15bDF/myzfJs9Nwgrk046HdFo7r/zZjF9ek4kxPekv9sI9Ve/j8Vg+G0HCNl /nBMVRyIB3UKQrSxFUlfeE3/p1sZf9HmqfXJZEANOViwDZEoYuo16O/ClyQYc+q92H yu6V6kSHXlQRLfpclTWw28+DD/NRmKkBCPtavzluivXxDI4Y6ez340z7qvVP+Ol9Ny Le16K8HyW3uNf6MIZlBx++r/JocAc8AC2sa4YKavd9m2gIWmgCuTshxnNSA3r7ry/m 9D1ef9zLR9Hhg== From: =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com> To: Mark Brown <broonie@kernel.org> Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, kernel@collabora.com, =?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= <nfraprado@collabora.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Date: Fri, 21 Oct 2022 15:09:08 -0400 Message-Id: <20221021190908.1502026-4-nfraprado@collabora.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221021190908.1502026-1-nfraprado@collabora.com> References: <20221021190908.1502026-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747325782484568895?= X-GMAIL-MSGID: =?utf-8?q?1747325782484568895?= |
Series |
Add missing dt-binding properties to rt5682(s)
|
|
Commit Message
Nícolas F. R. A. Prado
Oct. 21, 2022, 7:09 p.m. UTC
The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add
properties for them.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++
1 file changed, 6 insertions(+)
Comments
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add > properties for them. > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > --- > > Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt > index c5f2b8febcee..5ccf4eaf12a9 100644 > --- a/Documentation/devicetree/bindings/sound/rt5682.txt > +++ b/Documentation/devicetree/bindings/sound/rt5682.txt > @@ -48,6 +48,12 @@ Optional properties: > > - #sound-dai-cells: Should be set to '<0>'. > > +- AVDD-supply: phandle to the regulator supplying AVDD > + > +- MICVDD-supply: phandle to the regulator supplying MICVDD > + > +- VBAT-supply: phandle to the regulator supplying VBAT Lowercase. Best regards, Krzysztof
On Sat, Oct 22, 2022 at 12:41:01PM -0400, Krzysztof Kozlowski wrote: > On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: > > The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add > > properties for them. > > > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > --- > > > > Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt > > index c5f2b8febcee..5ccf4eaf12a9 100644 > > --- a/Documentation/devicetree/bindings/sound/rt5682.txt > > +++ b/Documentation/devicetree/bindings/sound/rt5682.txt > > @@ -48,6 +48,12 @@ Optional properties: > > > > - #sound-dai-cells: Should be set to '<0>'. > > > > +- AVDD-supply: phandle to the regulator supplying AVDD > > + > > +- MICVDD-supply: phandle to the regulator supplying MICVDD > > + > > +- VBAT-supply: phandle to the regulator supplying VBAT > > Lowercase. Actually looks like there's already a DT using these properties before the binding was added: arm64/boot/dts/qcom/sc7180-trogdor.dtsi In this case should we keep them uppercase for compatibility or carry on with the name changes and also update the DT? (the driver also uses uppercase names) Also noticed that dai-cells should actually be 1. Will fix in next version. Thanks, Nícolas
On 24/10/2022 12:00, Nícolas F. R. A. Prado wrote: > On Sat, Oct 22, 2022 at 12:41:01PM -0400, Krzysztof Kozlowski wrote: >> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote: >>> The rt5682 codec can have three supplies: AVDD, MICVDD and VBAT. Add >>> properties for them. >>> >>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> >>> --- >>> >>> Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt >>> index c5f2b8febcee..5ccf4eaf12a9 100644 >>> --- a/Documentation/devicetree/bindings/sound/rt5682.txt >>> +++ b/Documentation/devicetree/bindings/sound/rt5682.txt >>> @@ -48,6 +48,12 @@ Optional properties: >>> >>> - #sound-dai-cells: Should be set to '<0>'. >>> >>> +- AVDD-supply: phandle to the regulator supplying AVDD >>> + >>> +- MICVDD-supply: phandle to the regulator supplying MICVDD >>> + >>> +- VBAT-supply: phandle to the regulator supplying VBAT >> >> Lowercase. > > Actually looks like there's already a DT using these properties before the > binding was added: > > arm64/boot/dts/qcom/sc7180-trogdor.dtsi > > In this case should we keep them uppercase for compatibility or carry on with > the name changes and also update the DT? (the driver also uses uppercase names) Driver seems to use them as well, then uppercase is fine. But you need to describe it in commit msg, that you document existing usage, not adding new properties. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt index c5f2b8febcee..5ccf4eaf12a9 100644 --- a/Documentation/devicetree/bindings/sound/rt5682.txt +++ b/Documentation/devicetree/bindings/sound/rt5682.txt @@ -48,6 +48,12 @@ Optional properties: - #sound-dai-cells: Should be set to '<0>'. +- AVDD-supply: phandle to the regulator supplying AVDD + +- MICVDD-supply: phandle to the regulator supplying MICVDD + +- VBAT-supply: phandle to the regulator supplying VBAT + Pins on the device (for linking into audio routes) for RT5682: * DMIC L1