[2/3] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies

Message ID 20221021190908.1502026-3-nfraprado@collabora.com
State New
Headers
Series Add missing dt-binding properties to rt5682(s) |

Commit Message

Nícolas F. R. A. Prado Oct. 21, 2022, 7:09 p.m. UTC
  The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
for them.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---

 Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

David Heidelberg Oct. 21, 2022, 7:17 p.m. UTC | #1
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com>

On 21/10/2022 21:09, Nícolas F. R. A. Prado wrote:
> The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
> for them.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
>
>   Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> index ea53a55015c4..ca1037e76f96 100644
> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> @@ -90,6 +90,10 @@ properties:
>     "#sound-dai-cells":
>       const: 0
>   
> +  AVDD-supply: true
> +
> +  MICVDD-supply: true
> +
>   additionalProperties: false
>   
>   required:
  
Krzysztof Kozlowski Oct. 22, 2022, 4:39 p.m. UTC | #2
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote:
> The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
> for them.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> 
>  Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> index ea53a55015c4..ca1037e76f96 100644
> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> @@ -90,6 +90,10 @@ properties:
>    "#sound-dai-cells":
>      const: 0
>  
> +  AVDD-supply: true
> +
> +  MICVDD-supply: true
> +

How about keeping some order in the list of properties?


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Krzysztof Kozlowski Oct. 22, 2022, 4:40 p.m. UTC | #3
On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote:
> The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
> for them.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
> 
>  Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> index ea53a55015c4..ca1037e76f96 100644
> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> @@ -90,6 +90,10 @@ properties:
>    "#sound-dai-cells":
>      const: 0
>  
> +  AVDD-supply: true
> +
> +  MICVDD-supply: true

Ach, unacked. Please use lowercase names.

Best regards,
Krzysztof
  
Nícolas F. R. A. Prado Oct. 24, 2022, 3:06 p.m. UTC | #4
On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote:
> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote:
> > The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
> > for them.
> > 
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > ---
> > 
> >  Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> > index ea53a55015c4..ca1037e76f96 100644
> > --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> > +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
> > @@ -90,6 +90,10 @@ properties:
> >    "#sound-dai-cells":
> >      const: 0
> >  
> > +  AVDD-supply: true
> > +
> > +  MICVDD-supply: true
> > +
> 
> How about keeping some order in the list of properties?

The current properties don't seem to follow any particular order and keeping the
supplies grouped together seemed reasonable. What ordering do you suggest?

Thanks,
Nícolas
  
Krzysztof Kozlowski Oct. 24, 2022, 4:26 p.m. UTC | #5
On 24/10/2022 11:06, Nícolas F. R. A. Prado wrote:
> On Sat, Oct 22, 2022 at 12:39:56PM -0400, Krzysztof Kozlowski wrote:
>> On 21/10/2022 15:09, Nícolas F. R. A. Prado wrote:
>>> The rt5682s codec can have two supplies: AVDD and MICVDD. Add properties
>>> for them.
>>>
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>> ---
>>>
>>>  Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
>>> index ea53a55015c4..ca1037e76f96 100644
>>> --- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
>>> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
>>> @@ -90,6 +90,10 @@ properties:
>>>    "#sound-dai-cells":
>>>      const: 0
>>>  
>>> +  AVDD-supply: true
>>> +
>>> +  MICVDD-supply: true
>>> +
>>
>> How about keeping some order in the list of properties?
> 
> The current properties don't seem to follow any particular order and keeping the
> supplies grouped together seemed reasonable. What ordering do you suggest?

That's true...  :/

Best regards,
Krzysztof
  

Patch

diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index ea53a55015c4..ca1037e76f96 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -90,6 +90,10 @@  properties:
   "#sound-dai-cells":
     const: 0
 
+  AVDD-supply: true
+
+  MICVDD-supply: true
+
 additionalProperties: false
 
 required: