[5/8] arm64: dts: amlogic: meson-g12b-odroid-go-ultra: rename keypad-gpio pinctrl node
Message ID | 20230207-b4-amlogic-bindings-fixups-v2-v1-5-93b7e50286e7@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2902558wrn; Tue, 7 Feb 2023 07:12:59 -0800 (PST) X-Google-Smtp-Source: AK7set9oCvjR7FlKeiU7IzkpbVlKtF8L9RyHMeKkzxQ793pkTGcF7IcioGFYZofj+vbjOnsCsc2C X-Received: by 2002:a17:90b:4b87:b0:22c:169b:ec47 with SMTP id lr7-20020a17090b4b8700b0022c169bec47mr4166302pjb.41.1675782779429; Tue, 07 Feb 2023 07:12:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675782779; cv=none; d=google.com; s=arc-20160816; b=p6ak3aA1mVyrUroSdjQkThrBE6ZarJZrzHVj7ty2aSasEspKUMWplYUyNghkUh/I0v jXVOdph4fPFBAtQ8RCjM1D+1cmuSH6htwItVb+GaC+p8vTM+cQvGKH7SiICuO0hEu7Gt XO20CJM+rWRCyfPZQTKeKXCun60X/RCEi4dfWydUUoxWsSZEQ4H7zIp+9L+5giNpEP1Z xKqgVmv4DhzpHL7qOkt3E92MMUxGr0v8xp3XUqd8BYAY2j2L5GzVG476/Dj9WbF5cybv ZLn7euMR1GxPZLhNgsQkIANDc5mcByuGFsGUSQNLq/a1UBy7ssVJULM57vwrejR2UXve SfJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:subject:date:from :dkim-signature; bh=SdyZ473lVA8OnD87M9JEuHkPDAOV01LT74z6WsPQWzk=; b=fOsh6sccneXzbUgFBm8PzxdFnJgwFwxQPyvPQsdzWqsfMv+gb7vbUEO7lOxUDZJPQt m0D72dc4w53qoJHiF15U5vjbXx4c5VizSftekNlkPPTqaIwEDwFPFlBF3mfrlKyhkZF0 ejVJZ22pcE+L9IlHXCf3DIUekM4eLDXOVw8xh69jIrL/ftzgq1VCcgnnjS+ISHWVogiq yUrzREAOMgmfX5HuaHChGPqJcu20MWQF7zdW8ccmlOq0yTFab9yDTDztXpbjohHQCk+/ RQ6vpqerSGxyuS1ctxhusBHMZJjDEiVa4TJ98xUqSTjmEhiYn7+70/cBrL5PO/RP8yyV YjCQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kLB2UTtw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e11-20020a17090a630b00b0022bea9f876fsi14541427pjj.23.2023.02.07.07.12.46; Tue, 07 Feb 2023 07:12:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kLB2UTtw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232568AbjBGPIb (ORCPT <rfc822;kmanaouilinux@gmail.com> + 99 others); Tue, 7 Feb 2023 10:08:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231258AbjBGPIV (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 7 Feb 2023 10:08:21 -0500 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C7F017CDD for <linux-kernel@vger.kernel.org>; Tue, 7 Feb 2023 07:08:20 -0800 (PST) Received: by mail-wm1-x32c.google.com with SMTP id u10so8197357wmj.3 for <linux-kernel@vger.kernel.org>; Tue, 07 Feb 2023 07:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SdyZ473lVA8OnD87M9JEuHkPDAOV01LT74z6WsPQWzk=; b=kLB2UTtw3XnsMVL1Xa8yJdzg3oEv4Md8+s1kYYUq22KV983pPMVUgUdIWkdNmf/7cR 2+HBvOcxwZ20gbLOttYvkECNrlWwbJPA8+sztM7/VJ//FMVbh9JOBXJApSx9+Z2OPKrF 7AfKR+vtB+L5F5jiTSL42FN7GdtQrPY063qUZG8nymVVM9alaJksUYd38VlkCz0Hzb9m r61STAZBiEOrbL6R3JQ9XHJ67yxL1HbYOd4KyBdL7JAiIEluBE1bUylUKucrDDtE6QRU r9WXhCWgRybkaJ/nU9fCv37yOYKsBeq5xO18/d0Z4XIHhaTGCnQARkhvbcDmYQmS12kT 8JMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SdyZ473lVA8OnD87M9JEuHkPDAOV01LT74z6WsPQWzk=; b=32neGaCDXFNIuGnxt9fDipk8T8upLAfs1kUqj17Lzgyd3peavPU5Pu/P1oIamDX822 1noNq7ly/L3JZ49g7ExdR0lLqBlXe6Mvh6kjVsaa79TK5BGsDpeNEHwAVD/3BmQinQlL +VtBpkKtsmfwKpshzaLKanVzE6lvLFEqEfFfbxAHm7x45L7Ny/UgqDTDulIUt3H6IHLd 5TP8z237OOQJ2pdDAo7jBTHKfFZdnpre9EP5Br1J4QjzZc3vsx9RRcMzg7My+bUfooTr dkmRlstAUYC7wGMM0kxgTKjBwS9A2Tr0+aWzTF1AMGZWNuU0eaX4KoZ9qhf4ecVxsj+7 KB2g== X-Gm-Message-State: AO0yUKXut2pI3ioc046cpQclpGmjfHxKwzdbCKBac48OXmeZuXO48xhU c5Qn32RrJ9IrxLKaXCFD+l2/0w== X-Received: by 2002:a05:600c:a287:b0:3df:ee64:4814 with SMTP id hu7-20020a05600ca28700b003dfee644814mr3462318wmb.20.1675782499714; Tue, 07 Feb 2023 07:08:19 -0800 (PST) Received: from arrakeen.starnux.net ([2a01:e0a:982:cbb0:52eb:f6ff:feb3:451a]) by smtp.gmail.com with ESMTPSA id j33-20020a05600c1c2100b003db0ad636d1sm22092173wms.28.2023.02.07.07.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Feb 2023 07:08:19 -0800 (PST) From: Neil Armstrong <neil.armstrong@linaro.org> Date: Tue, 07 Feb 2023 16:07:58 +0100 Subject: [PATCH 5/8] arm64: dts: amlogic: meson-g12b-odroid-go-ultra: rename keypad-gpio pinctrl node MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20230207-b4-amlogic-bindings-fixups-v2-v1-5-93b7e50286e7@linaro.org> References: <20230207-b4-amlogic-bindings-fixups-v2-v1-0-93b7e50286e7@linaro.org> In-Reply-To: <20230207-b4-amlogic-bindings-fixups-v2-v1-0-93b7e50286e7@linaro.org> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Christian Hewitt <christianshewitt@gmail.com>, Yuntian Zhang <yt@radxa.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Neil Armstrong <neil.armstrong@linaro.org> X-Mailer: b4 0.12.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757185604064715119?= X-GMAIL-MSGID: =?utf-8?q?1757185604064715119?= |
Series |
arm64: meson: bunch of DT fixes, take 2
|
|
Commit Message
Neil Armstrong
Feb. 7, 2023, 3:07 p.m. UTC
Fixes the following bindings check error:
pinctrl@40: keypad-gpio: {...} is not of type 'array'
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, Feb 7, 2023 at 4:08 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Fixes the following bindings check error: > pinctrl@40: keypad-gpio: {...} is not of type 'array' > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> [...] > &periphs_pinctrl { > - keypad_gpio_pins: keypad-gpio { > + keypad_gpio_pins: keypad-gpio-state { > mux { > groups = "GPIOX_0", "GPIOX_1", "GPIOX_2", "GPIOX_3", > "GPIOX_4", "GPIOX_5", "GPIOX_6", "GPIOX_7", I'm wondering whether we make the keys work without having to specify a pinmux configuration for them separately. Our pinctrl driver already sets: pc->chip.set_config = gpiochip_generic_config; So you should be able to use the GPIO_PULL_UP flag for these GPIOs in device-tree instead of specifying bias-pull-up here, for example: gpios = <&gpio GPIOX_0 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; output-disable is managed by the direction of the GPIO anyways. pinmux_ops.gpio_request_enable is also implemented by our pinctrl driver. This is not urgent - I am just curious as always :-) Best regards, Martin
On 11/02/2023 21:04, Martin Blumenstingl wrote: > On Tue, Feb 7, 2023 at 4:08 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> Fixes the following bindings check error: >> pinctrl@40: keypad-gpio: {...} is not of type 'array' >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > [...] >> &periphs_pinctrl { >> - keypad_gpio_pins: keypad-gpio { >> + keypad_gpio_pins: keypad-gpio-state { >> mux { >> groups = "GPIOX_0", "GPIOX_1", "GPIOX_2", "GPIOX_3", >> "GPIOX_4", "GPIOX_5", "GPIOX_6", "GPIOX_7", > I'm wondering whether we make the keys work without having to specify > a pinmux configuration for them separately. > Our pinctrl driver already sets: > pc->chip.set_config = gpiochip_generic_config; > So you should be able to use the GPIO_PULL_UP flag for these GPIOs in > device-tree instead of specifying bias-pull-up here, for example: > gpios = <&gpio GPIOX_0 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; > > output-disable is managed by the direction of the GPIO anyways. > pinmux_ops.gpio_request_enable is also implemented by our pinctrl driver. > > This is not urgent - I am just curious as always :-) I didn't know we supported this, this is only a bindings check fix, but yeah at some point this should be moved to (GPIO_ACTIVE_LOW | GPIO_PULL_UP). Neil > > > Best regards, > Martin
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts index c8e5a0a42b89..29d642e746d4 100644 --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-go-ultra.dts @@ -620,7 +620,7 @@ &frddr_a { }; &periphs_pinctrl { - keypad_gpio_pins: keypad-gpio { + keypad_gpio_pins: keypad-gpio-state { mux { groups = "GPIOX_0", "GPIOX_1", "GPIOX_2", "GPIOX_3", "GPIOX_4", "GPIOX_5", "GPIOX_6", "GPIOX_7",