| Message ID | 20230209194825.511043-3-shikemeng@huaweicloud.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp289055wrn;
Thu, 9 Feb 2023 03:58:21 -0800 (PST)
X-Google-Smtp-Source:
AK7set9zziDSdBZLi/+rU6JnuJHVkzUXydgCu6glU20dkV2H9gUX9P1YrQT6jeap89FbfHs0h8y1
X-Received: by 2002:a17:902:e3d5:b0:199:5647:3342 with SMTP id
r21-20020a170902e3d500b0019956473342mr2966775ple.33.1675943901120;
Thu, 09 Feb 2023 03:58:21 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1675943901; cv=none;
d=google.com; s=arc-20160816;
b=dMXjsb84YECJaUj86j4pXo3V+/lzW/FQOIbnmw15zXGXjECx3EVuZ8aOw8HT5Q4iVt
kPedRS22Bx61M4ZFaDn3teSNrdqast6OTHYdG4aLBMnngeIFwGqiHVgb6+j4PUBHB29B
yaCMd112NRsZ5VKE0kGl8qPK6qkGYtF7PvStO/p06Tl04IsxoRErBGgisQ2xhnHd+tUB
t5G9ZmvHlFZ/4ZL0MYwiBtW687mD+CX1kuYFemxNj6TE6QyXdH0f2VvjUcfEn77jeG/Q
yRz1lWlf86GDW3Qn6EY9ncAtcniDpYmM6bZMuc5NBfi+wpEG/kS0BxsXsBuxoCxY9gBs
AByA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=aft6PkUwfkJsOFYeHPE+ZJRVZ+PBCJJOGq0TobtPubw=;
b=ImbuEgkItyyeCJgZEkuuIyCJEXn0wQIJDWO15GnCq0pdf82V40cUXVFnWd4kuSeF1o
KESLDJgQ8W2+3Ph2VhI0y9HIi/zn5wel23fwl24lpEav7M71Ovt6hkEsG6ovBJw3rWv1
UlJ3nlCeXtDQXVBSXXkm7KBKGIcYKlMVs3kvdMyaZpdGsCAW/C0mwNpqkyngBn/RkzlO
chfqIzp7z9iWeR8nIBv8zECeU21eQN7SYMWjCSUuYHq8MwJWeuYGc5pO30ikIF9lbYVg
XpmKW4errq0BhZOYtDhi4Ipo8U4/tZE/R5WuJ+VatUyNOoVup2FPoY8f47G6tWTSoXev
NM2A==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
k9-20020a170902c40900b001866341b823si1876240plk.322.2023.02.09.03.58.08;
Thu, 09 Feb 2023 03:58:21 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230122AbjBIL5C (ORCPT <rfc822;ybw1215001957@gmail.com>
+ 99 others); Thu, 9 Feb 2023 06:57:02 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58360 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229447AbjBIL4K (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 9 Feb 2023 06:56:10 -0500
Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com
[45.249.212.51])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AC4A5BA71;
Thu, 9 Feb 2023 03:46:29 -0800 (PST)
Received: from mail02.huawei.com (unknown [172.30.67.169])
by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id
4PCFSc1YZnz4f3jpt;
Thu, 9 Feb 2023 19:46:24 +0800 (CST)
Received: from huaweicloud.com (unknown [10.175.124.27])
by APP4 (Coremail) with SMTP id gCh0CgAn3rEQ3eRjgb0tDQ--.53508S4;
Thu, 09 Feb 2023 19:46:26 +0800 (CST)
From: Kemeng Shi <shikemeng@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 02/21] ext4: allow to find by goal if EXT4_MB_HINT_GOAL_ONLY
is set
Date: Fri, 10 Feb 2023 03:48:06 +0800
Message-Id: <20230209194825.511043-3-shikemeng@huaweicloud.com>
X-Mailer: git-send-email 2.30.0
In-Reply-To: <20230209194825.511043-1-shikemeng@huaweicloud.com>
References: <20230209194825.511043-1-shikemeng@huaweicloud.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CM-TRANSID: gCh0CgAn3rEQ3eRjgb0tDQ--.53508S4
X-Coremail-Antispam: 1UD129KBjvdXoWrury7ur4xtw1kZr4DtFW7twb_yoWDAwb_CF
yUAr1xZ3Z5Jw1fC3WrAayFkF1vgF4Fqr4rWFWrXrZxZF4UX3WIya4qyr4fZwn2kw17A347
u34YgFy7Gr4IqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT
9fnUUIcSsGvfJTRUUUbfxYFVCjjxCrM7AC8VAFwI0_Xr0_Wr1l1xkIjI8I6I8E6xAIw20E
Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82
xGYIkIc2x26280x7IE14v26r15M28IrcIa0xkI8VCY1x0267AKxVWUCVW8JwA2ocxC64kI
II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7
xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2
z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4
xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2
6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI
xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480
Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7
IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2
6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV
AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jTQ6JUUUUU=
X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12,
SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1757354551999883235?=
X-GMAIL-MSGID: =?utf-8?q?1757354551999883235?=
|
| Series |
Some bugfix and cleanup to mballoc
|
|
Commit Message
Kemeng Shi
Feb. 9, 2023, 7:48 p.m. UTC
If EXT4_MB_HINT_GOAL_ONLY is set, ext4_mb_regular_allocator will only
allocate blocks from ext4_mb_find_by_goal. Allow to find by goal in
ext4_mb_find_by_goal if EXT4_MB_HINT_GOAL_ONLY is set or allocation
with EXT4_MB_HINT_GOAL_ONLY set will always fail.
EXT4_MB_HINT_GOAL_ONLY is not used at all, so the problem is not
found for now.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Feb 10, 2023 at 03:48:06AM +0800, Kemeng Shi wrote: > If EXT4_MB_HINT_GOAL_ONLY is set, ext4_mb_regular_allocator will only > allocate blocks from ext4_mb_find_by_goal. Allow to find by goal in > ext4_mb_find_by_goal if EXT4_MB_HINT_GOAL_ONLY is set or allocation > with EXT4_MB_HINT_GOAL_ONLY set will always fail. > > EXT4_MB_HINT_GOAL_ONLY is not used at all, so the problem is not > found for now. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> > --- > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 0650a1dc870e..375d9655b525 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -2162,7 +2162,7 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, > struct ext4_group_info *grp = ext4_get_group_info(ac->ac_sb, group); > struct ext4_free_extent ex; > > - if (!(ac->ac_flags & EXT4_MB_HINT_TRY_GOAL)) > + if (!(ac->ac_flags & (EXT4_MB_HINT_TRY_GOAL | EXT4_MB_HINT_GOAL_ONLY))) > return 0; > if (grp->bb_free == 0) > return 0; Looks good to me, feel free to add: Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 0650a1dc870e..375d9655b525 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2162,7 +2162,7 @@ int ext4_mb_find_by_goal(struct ext4_allocation_context *ac, struct ext4_group_info *grp = ext4_get_group_info(ac->ac_sb, group); struct ext4_free_extent ex; - if (!(ac->ac_flags & EXT4_MB_HINT_TRY_GOAL)) + if (!(ac->ac_flags & (EXT4_MB_HINT_TRY_GOAL | EXT4_MB_HINT_GOAL_ONLY))) return 0; if (grp->bb_free == 0) return 0;