Message ID | 20221021203329.4143397-7-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4242:0:0:0:0:0 with SMTP id s2csp893736wrr; Fri, 21 Oct 2022 13:44:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6WNvd/saF8x4fL/8GXSfgld+u1HL9vbrsqw5A3IwxkFdLUgwxsII0oTkWDuQ+UhasbEmnV X-Received: by 2002:a17:903:95:b0:186:60a7:f6c with SMTP id o21-20020a170903009500b0018660a70f6cmr10606180pld.20.1666385051530; Fri, 21 Oct 2022 13:44:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666385051; cv=none; d=google.com; s=arc-20160816; b=GMwrtF1w4xn72yWBNVRsE9CO13csB5srywm7EtL72xJ2u6HTi6q3C/gYRYjVHzjEJX jvHgBEB3XwnT7ARCTX9FZJqMNyZ26eq3iNHpWRH2nONYlFDoVT8HOBVtYwEt9Et+q49V UdzvpR/pJy2qGc1uvoK1RX1WwEqby2O4R9crgnIkT4gZX1UwLfyAjOkue+Q8nAwupWLi PKn4MDsSDrdfRJyZmyQvOgFLvDtBexbOmy+TxOfu0E/+ym9rtezgKGCAvwWWDh4qkyM5 ZqsICNSAn24GQsBvQwI1GJTV8TVB6dG85x+zbtQw+Oh4QhZT/J2XAd6PURsDvwI55Bjw WCvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=EUIv9JL/e8n+kxe5SKk05yVPLk4LDUp5YhVrYQdfHBM=; b=eO+7JOGoW6PL+H0lfIu1XdDpat/DDsWPQci0biMBs2HxBvTF5gyuT/3SlVde4mP7Lk sBBNoCeT1Y2M9TwBnK0BsIOPEAvPiV5WrNzVQdSi/sQCjedyndcTILKGbuWRGMeOTZUP t86kGzkwgErMHWckGFCSPiv9VSdGwW4gnQ0hDUSCw8iDW/kw1SqrG22TagD4ldY+B9+4 gpR4wDl4owOFbDp46S3pQ0H+oXiTDNUolXq1v2HgbCM9r54t0yGj0uxMij/kPtianu2W GV9pRoBIEB4kucLeCb1pvRGrIvYS0FXORyRrbQHfaKhqkm54H0u6ZNdKpQZrCNFX4SDQ 5cgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SlEHXZ9W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bx22-20020a17090af49600b00200b2126ebesi566019pjb.168.2022.10.21.13.43.57; Fri, 21 Oct 2022 13:44:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SlEHXZ9W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230132AbiJUUnT (ORCPT <rfc822;mntrajkot1@gmail.com> + 99 others); Fri, 21 Oct 2022 16:43:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbiJUUm4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 21 Oct 2022 16:42:56 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D53E22A17D1; Fri, 21 Oct 2022 13:42:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 744E761F1A; Fri, 21 Oct 2022 20:42:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68425C433D7; Fri, 21 Oct 2022 20:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666384946; bh=OzXG9cO8TgE4LXZUmE+an4SXeiNKfPtvb8eemwziMgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SlEHXZ9W2VW1K52a5l4DiStfpB9gQRQ6g2Tk+CoAgvtDQeGYfFsYhfq7Frqyctheq luxePxPLnWV3P9teeQoo9DosYZ2TiinjkErIM/X1hVivH6/ahkulu7cB4NQ5cComLR QL4mayyptJxKtQIxIi/ZbJ7OOysW4KQ0pbF49GQa4rNxhX29ZW8xkoO8ly8VoYQdnu BQsgZHlftzNJ7NY8Y7TpmoTHNWuq6hiJqHelMhzMC5DlO0pyviGOb1vLpjJ+c9jzbd rrA0XiCMxMTFOB+vD9WwMgs9CB9/O16x30FOsGCjSOyYsb4oWgx4Ml+iuFA7MLjMRW t+dlMmUNYQh8g== From: Arnd Bergmann <arnd@kernel.org> To: linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Sebastian Reichel <sre@kernel.org> Cc: linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>, Simtec Linux Team <linux@simtec.co.uk>, Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Mauro Carvalho Chehab <mchehab@kernel.org>, Lukas Bulwahn <lukas.bulwahn@gmail.com>, Joe Perches <joe@perches.com>, Hans de Goede <hdegoede@redhat.com>, Linus Walleij <linus.walleij@linaro.org>, Luca Ceresoli <luca.ceresoli@bootlin.com>, Lee Jones <lee@kernel.org>, linux-pm@vger.kernel.org Subject: [PATCH 07/21] power: remove s3c adc battery driver Date: Fri, 21 Oct 2022 22:27:40 +0200 Message-Id: <20221021203329.4143397-7-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20221021202254.4142411-1-arnd@kernel.org> References: <20221021202254.4142411-1-arnd@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747331371579444767?= X-GMAIL-MSGID: =?utf-8?q?1747331371579444767?= |
Series |
ARM: s3c: clean out obsolete platforms
|
|
Commit Message
Arnd Bergmann
Oct. 21, 2022, 8:27 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> The s3c-adc driver is removed along with the s3c24xx platform, so the battery driver is no longer needed either. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- MAINTAINERS | 7 - drivers/power/supply/Kconfig | 6 - drivers/power/supply/Makefile | 1 - drivers/power/supply/s3c_adc_battery.c | 453 ------------------------- include/linux/s3c_adc_battery.h | 39 --- 5 files changed, 506 deletions(-) delete mode 100644 drivers/power/supply/s3c_adc_battery.c delete mode 100644 include/linux/s3c_adc_battery.h
Comments
On Fri, 21 Oct 2022, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The s3c-adc driver is removed along with the s3c24xx platform, > so the battery driver is no longer needed either. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > MAINTAINERS | 7 - > drivers/power/supply/Kconfig | 6 - > drivers/power/supply/Makefile | 1 - > drivers/power/supply/s3c_adc_battery.c | 453 ------------------------- > include/linux/s3c_adc_battery.h | 39 --- > 5 files changed, 506 deletions(-) > delete mode 100644 drivers/power/supply/s3c_adc_battery.c > delete mode 100644 include/linux/s3c_adc_battery.h Any idea why I was Cc'ed on this (and only this) patch?
On Mon, Oct 24, 2022, at 09:28, Lee Jones wrote: > On Fri, 21 Oct 2022, Arnd Bergmann wrote: > >> From: Arnd Bergmann <arnd@arndb.de> >> >> The s3c-adc driver is removed along with the s3c24xx platform, >> so the battery driver is no longer needed either. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> --- >> MAINTAINERS | 7 - >> drivers/power/supply/Kconfig | 6 - >> drivers/power/supply/Makefile | 1 - >> drivers/power/supply/s3c_adc_battery.c | 453 ------------------------- >> include/linux/s3c_adc_battery.h | 39 --- >> 5 files changed, 506 deletions(-) >> delete mode 100644 drivers/power/supply/s3c_adc_battery.c >> delete mode 100644 include/linux/s3c_adc_battery.h > > Any idea why I was Cc'ed on this (and only this) patch? Not sure. I use "get_maintainer.pl -i" to generate the list and try to prune it manually to avoid adding too many people to Cc. It appears that for this patch I accidentally included everyone who showed up in the git history for the maintainers file, rather than the people who touched the actual driver. Arnd
On Mon, 24 Oct 2022, Arnd Bergmann wrote: > On Mon, Oct 24, 2022, at 09:28, Lee Jones wrote: > > On Fri, 21 Oct 2022, Arnd Bergmann wrote: > > > >> From: Arnd Bergmann <arnd@arndb.de> > >> > >> The s3c-adc driver is removed along with the s3c24xx platform, > >> so the battery driver is no longer needed either. > >> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> > >> --- > >> MAINTAINERS | 7 - > >> drivers/power/supply/Kconfig | 6 - > >> drivers/power/supply/Makefile | 1 - > >> drivers/power/supply/s3c_adc_battery.c | 453 ------------------------- > >> include/linux/s3c_adc_battery.h | 39 --- > >> 5 files changed, 506 deletions(-) > >> delete mode 100644 drivers/power/supply/s3c_adc_battery.c > >> delete mode 100644 include/linux/s3c_adc_battery.h > > > > Any idea why I was Cc'ed on this (and only this) patch? > > Not sure. I use "get_maintainer.pl -i" to generate the list > and try to prune it manually to avoid adding too many > people to Cc. It appears that for this patch I accidentally > included everyone who showed up in the git history for the > maintainers file, rather than the people who touched the > actual driver. Understood. Thanks for the explanation.
On 21/10/2022 16:27, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The s3c-adc driver is removed along with the s3c24xx platform, > so the battery driver is no longer needed either. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi, On Fri, Oct 21, 2022 at 10:27:40PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The s3c-adc driver is removed along with the s3c24xx platform, > so the battery driver is no longer needed either. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- I suppose queuing this via power-supply will result in temporary build failures because the header is included in s3c24xx arch code. So better to merge via the same tree that is killing the arch code: Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > MAINTAINERS | 7 - > drivers/power/supply/Kconfig | 6 - > drivers/power/supply/Makefile | 1 - > drivers/power/supply/s3c_adc_battery.c | 453 ------------------------- > include/linux/s3c_adc_battery.h | 39 --- > 5 files changed, 506 deletions(-) > delete mode 100644 drivers/power/supply/s3c_adc_battery.c > delete mode 100644 include/linux/s3c_adc_battery.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 071d64e2a7ca..2caf42b0328a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -17920,13 +17920,6 @@ S: Supported > W: http://www.ibm.com/developerworks/linux/linux390/ > F: drivers/s390/scsi/zfcp_* > > -S3C ADC BATTERY DRIVER > -M: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > -L: linux-samsung-soc@vger.kernel.org > -S: Odd Fixes > -F: drivers/power/supply/s3c_adc_battery.c > -F: include/linux/s3c_adc_battery.h > - > S3C24XX SD/MMC Driver > M: Ben Dooks <ben-linux@fluff.org> > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index 568b3ede993a..e2f8dfcdd2a9 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -406,12 +406,6 @@ config BATTERY_MAX1721X > Say Y here to enable support for the MAX17211/MAX17215 standalone > battery gas-gauge. > > -config BATTERY_S3C_ADC > - tristate "Battery driver for Samsung ADC based monitoring" > - depends on S3C_ADC > - help > - Say Y here to enable support for iPAQ h1930/h1940/rx1950 battery > - > config BATTERY_TWL4030_MADC > tristate "TWL4030 MADC battery driver" > depends on TWL4030_MADC > diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile > index af43866b3980..8cb3c7f5c111 100644 > --- a/drivers/power/supply/Makefile > +++ b/drivers/power/supply/Makefile > @@ -54,7 +54,6 @@ obj-$(CONFIG_BATTERY_MAX17042) += max17042_battery.o > obj-$(CONFIG_BATTERY_MAX1721X) += max1721x_battery.o > obj-$(CONFIG_BATTERY_RT5033) += rt5033_battery.o > obj-$(CONFIG_CHARGER_RT9455) += rt9455_charger.o > -obj-$(CONFIG_BATTERY_S3C_ADC) += s3c_adc_battery.o > obj-$(CONFIG_BATTERY_TWL4030_MADC) += twl4030_madc_battery.o > obj-$(CONFIG_CHARGER_88PM860X) += 88pm860x_charger.o > obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o > diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c > deleted file mode 100644 > index 68d31a3bee48..000000000000 > diff --git a/include/linux/s3c_adc_battery.h b/include/linux/s3c_adc_battery.h > deleted file mode 100644 > index 57f982c375f8..000000000000 > -- > 2.29.2 >
diff --git a/MAINTAINERS b/MAINTAINERS index 071d64e2a7ca..2caf42b0328a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -17920,13 +17920,6 @@ S: Supported W: http://www.ibm.com/developerworks/linux/linux390/ F: drivers/s390/scsi/zfcp_* -S3C ADC BATTERY DRIVER -M: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> -L: linux-samsung-soc@vger.kernel.org -S: Odd Fixes -F: drivers/power/supply/s3c_adc_battery.c -F: include/linux/s3c_adc_battery.h - S3C24XX SD/MMC Driver M: Ben Dooks <ben-linux@fluff.org> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 568b3ede993a..e2f8dfcdd2a9 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -406,12 +406,6 @@ config BATTERY_MAX1721X Say Y here to enable support for the MAX17211/MAX17215 standalone battery gas-gauge. -config BATTERY_S3C_ADC - tristate "Battery driver for Samsung ADC based monitoring" - depends on S3C_ADC - help - Say Y here to enable support for iPAQ h1930/h1940/rx1950 battery - config BATTERY_TWL4030_MADC tristate "TWL4030 MADC battery driver" depends on TWL4030_MADC diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index af43866b3980..8cb3c7f5c111 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -54,7 +54,6 @@ obj-$(CONFIG_BATTERY_MAX17042) += max17042_battery.o obj-$(CONFIG_BATTERY_MAX1721X) += max1721x_battery.o obj-$(CONFIG_BATTERY_RT5033) += rt5033_battery.o obj-$(CONFIG_CHARGER_RT9455) += rt9455_charger.o -obj-$(CONFIG_BATTERY_S3C_ADC) += s3c_adc_battery.o obj-$(CONFIG_BATTERY_TWL4030_MADC) += twl4030_madc_battery.o obj-$(CONFIG_CHARGER_88PM860X) += 88pm860x_charger.o obj-$(CONFIG_CHARGER_PCF50633) += pcf50633-charger.o diff --git a/drivers/power/supply/s3c_adc_battery.c b/drivers/power/supply/s3c_adc_battery.c deleted file mode 100644 index 68d31a3bee48..000000000000 diff --git a/include/linux/s3c_adc_battery.h b/include/linux/s3c_adc_battery.h deleted file mode 100644 index 57f982c375f8..000000000000