Message ID | 20230211121441.64359-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1468281wrn; Sat, 11 Feb 2023 04:28:10 -0800 (PST) X-Google-Smtp-Source: AK7set/BCxnqRQvL9lCNjOs4qoPaJqCA32+rI74JkRJODqBQO1JbCTK7RDmY6XHlNt7gJsHSSADe X-Received: by 2002:a05:6a21:3386:b0:bc:3523:13c6 with SMTP id yy6-20020a056a21338600b000bc352313c6mr23563072pzb.29.1676118490586; Sat, 11 Feb 2023 04:28:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676118490; cv=none; d=google.com; s=arc-20160816; b=v07mczmnk/+h0Rlw0ZUFfcZ3BHAibKLJZfDndzxp+d35i9D3khYx2xXsuz2BkvJJI1 Ep8Uw8ezveOFdaWAJNnf6rQw4uO9yE/9QLPLD1RvgFgljEDOu9jmZcCcVFmMdi2OMoeM /6AmAkF2um2nFtg1Hvw/oNtyfoehBxQO8rvPGRYN0sURFqNDWtteAiQubtFqNq+u/1Wp xcfmqgg6zD7iHpTZdRGIc1hpo7JqSx3oWJsPcGcixanxmioWI7AmzW0uoFMjBOYlvDOn ozY9WMYXJW9OkBpcaduzLNlNc2M/FVFse2INaIvG0n/i2EnJx7Iwp7L1gWy2IMEZC9f5 3UzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Yx4QveUkxsZ076CSy140ixdXzrbrRAsprIFkOwOHph8=; b=DxCy44wuVi4Z49ly5JihK9Q8/dXL8txbjgDVg7m5n4MhEIEVB84XxSNh6GQqOPsr0Z oFVQdUowNC14tTQkANxqC2D5pmJzPtiH43mhKBA0Ew8iLCV2Pp+22JDR63PGAplajOOQ n3qkJpEJrC33iQcArpS+ieuswZ9azg7dqiLkO7r9pSSdUezYq6VP4O/96BvqeK0mefQb I+SeLl9CmOSfO1oyTEaSilRIable0gdag468hk3D1cp7Uk88J6nWiM4/AeFbNquIYhvh KtDSXxf91LHTOKGKpY8q8jDdfnP92UcIjzoJKmUhiFFIMLXs0yACzu4963LAErWvs/PQ /E3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=frRGdTqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p6-20020a639506000000b004fae19eac8bsi6734879pgd.810.2023.02.11.04.27.58; Sat, 11 Feb 2023 04:28:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=frRGdTqB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbjBKMO7 (ORCPT <rfc822;olliecheer@gmail.com> + 99 others); Sat, 11 Feb 2023 07:14:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229903AbjBKMO5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 11 Feb 2023 07:14:57 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6282023106 for <linux-kernel@vger.kernel.org>; Sat, 11 Feb 2023 04:14:56 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id o18so7723487wrj.3 for <linux-kernel@vger.kernel.org>; Sat, 11 Feb 2023 04:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Yx4QveUkxsZ076CSy140ixdXzrbrRAsprIFkOwOHph8=; b=frRGdTqBZv/KsdKobxihqMiDzGE6yzyL6O4P/bithC+kcSrWbWHlVRvVaCcWtI47ie PsYGjy56QaKtblrUA7PFmyb57yZvWPzJ/i03UJrBVa5OWkyRcpfA71u97ZAu4OfVSHaV GNdnS8f80DPjyK5Tf6qb1K0KBuOlciDjx7u3VaqevispGEWgy3L5IvqF7jqT9+S6sdjl 2HlSJlqy0XgTo5SVNUHyANUzLH5D7woVFh6jD14llKkOk0wiMFHwlPWD9qnEjJX/eJSM hRCthdwnTN0RnmKnDurb+ybb4lQfVVowQgOmrF1jD8dm03rDYcP/1axGjKa1Q5SUx2Px ZtIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yx4QveUkxsZ076CSy140ixdXzrbrRAsprIFkOwOHph8=; b=C3ymP/lsS32ASR8BnIRJhLdEjnGN8piaxkHZSWWG4/YLz6XRXwStp0pEQ2tXQsVJd4 sw2n165VO/8rbk6D1W29NlCCgbd/7pGC/zYCiXt+CF0Y2lUgH/4cf3Z4I9xyinG44o5m w2oau7DfxLbubOPNTtWRe93OlVKdEDim/MVq0wyERFncI0OtJkvZwDysurHaQ5eu8cyh tvyKpbWdg7U4X58eZfVcB1DwRgBXNNs2h2w6sfmkTkX6pXN0jFNjkNaXNxpzRg4uZaKB kUjjbhvEjEYARV/8pZ1mL+BorLEqWk/RanU1w31NdfZYlKK6/QIMi2o1Ebi2zS+gsGFh 2J6Q== X-Gm-Message-State: AO0yUKUyOMJv9M6bjeWQDkr8Du/cZI2wDWhaOdENRXq7LcbpZ4OnTgXE /rDV1SQ9o43fxe5ofMLzqrrwwg== X-Received: by 2002:adf:cf0d:0:b0:2c5:4ccc:a770 with SMTP id o13-20020adfcf0d000000b002c54ccca770mr3055463wrj.7.1676117695014; Sat, 11 Feb 2023 04:14:55 -0800 (PST) Received: from krzk-bin.. ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h12-20020adff4cc000000b002be505ab59asm6041645wrp.97.2023.02.11.04.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Feb 2023 04:14:54 -0800 (PST) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Joe Perches <joe@perches.com>, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Shawn Guo <shawnguo@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org> Subject: [PATCH] get_maintainer: add email addresses from dts files Date: Sat, 11 Feb 2023 13:14:41 +0100 Message-Id: <20230211121441.64359-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757537622370696619?= X-GMAIL-MSGID: =?utf-8?q?1757537622370696619?= |
Series |
get_maintainer: add email addresses from dts files
|
|
Commit Message
Krzysztof Kozlowski
Feb. 11, 2023, 12:14 p.m. UTC
The DTS/DTSI files represent hardware description for Linux kernel, which is necessary to properly recognize and configure hardware by Linux. DTS is usually created by people having the actual hardware and having interest in keeping it in good shape. Such people can provide review (they might have board schematics) and testing. Unfortunately they mostly do not appear in MAINTAINERS file. Adding per-DTS entries to MAINTAINERS would quickly make it bloated (hundreds of new per-DTS entries). On the other hand there is no point in CC-ing every Copyright email appearing in files, because it might be outdated. Add new in-file pattern for storing maintainers dedicated to specific boards: Maintainer: John Smith <email> Suggested-by: Joe Perches <joe@perches.com> Suggested-by: Shawn Guo <shawnguo@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- This is rework of earlier approach: Link: https://lore.kernel.org/r/20210809080204.8381-1-shawnguo@kernel.org --- scripts/get_maintainer.pl | 11 +++++++++++ 1 file changed, 11 insertions(+)
Comments
On 11/02/2023 13:14, Krzysztof Kozlowski wrote: > The DTS/DTSI files represent hardware description for Linux kernel, > which is necessary to properly recognize and configure hardware by > Linux. DTS is usually created by people having the actual hardware and > having interest in keeping it in good shape. Such people can provide > review (they might have board schematics) and testing. Unfortunately > they mostly do not appear in MAINTAINERS file. Adding per-DTS entries > to MAINTAINERS would quickly make it bloated (hundreds of new per-DTS > entries). > > On the other hand there is no point in CC-ing every Copyright email > appearing in files, because it might be outdated. Add new in-file > pattern for storing maintainers dedicated to specific boards: > > Maintainer: John Smith <email> > > Suggested-by: Joe Perches <joe@perches.com> > Suggested-by: Shawn Guo <shawnguo@kernel.org> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> This is obviously not a valid tag anymore... I'll sent a v2 tomorrow. Best regards, Krzysztof
On Sat, 2023-02-11 at 13:14 +0100, Krzysztof Kozlowski wrote: > The DTS/DTSI files represent hardware description for Linux kernel, > which is necessary to properly recognize and configure hardware by > Linux. DTS is usually created by people having the actual hardware and > having interest in keeping it in good shape. Such people can provide > review (they might have board schematics) and testing. Unfortunately > they mostly do not appear in MAINTAINERS file. Adding per-DTS entries > to MAINTAINERS would quickly make it bloated (hundreds of new per-DTS > entries). > > On the other hand there is no point in CC-ing every Copyright email > appearing in files, because it might be outdated. Add new in-file > pattern for storing maintainers dedicated to specific boards: > > Maintainer: John Smith <email> > > Suggested-by: Joe Perches <joe@perches.com> > Suggested-by: Shawn Guo <shawnguo@kernel.org> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > This is rework of earlier approach: > Link: https://lore.kernel.org/r/20210809080204.8381-1-shawnguo@kernel.org Why the rework? I think the older one is much simpler. I believe I forwarded the older one to Andrew Morton awhile back. I'll check to see what happened to it. > --- > scripts/get_maintainer.pl | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > index ab123b498fd9..f02a2a80c3bc 100755 > --- a/scripts/get_maintainer.pl > +++ b/scripts/get_maintainer.pl > @@ -445,6 +445,17 @@ sub maintainers_in_file { > my @poss_addr = $text =~ m$[A-Za-zÀ-ÿ\"\' \,\.\+-]*\s*[\,]*\s*[\(\<\{]{0,1}[A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+\.[A-Za-z0-9]+[\)\>\}]{0,1}$g; > push(@file_emails, clean_file_emails(@poss_addr)); > } > + > + # Match "Maintainer: email" entries only in DTS sources > + if (-f $file && ($email_file_emails || $file =~ /\.dtsi?$/)) { > + open(my $f, '<', $file) > + or die "$P: Can't open $file: $!\n"; > + my $text = do { local($/) ; <$f> }; > + close($f); > + > + my @poss_addr = $text =~ m$Maintainer: [A-Za-zÀ-ÿ\"\' \,\.\+-]*\s*[\,]*\s*[\(\<\{]{0,1}[A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+\.[A-Za-z0-9]+[\)\>\}]{0,1}$g; > + push(@file_emails, clean_file_emails(@poss_addr)); > + } > } > > #
On 11/02/2023 17:27, Joe Perches wrote: > On Sat, 2023-02-11 at 13:14 +0100, Krzysztof Kozlowski wrote: >> The DTS/DTSI files represent hardware description for Linux kernel, >> which is necessary to properly recognize and configure hardware by >> Linux. DTS is usually created by people having the actual hardware and >> having interest in keeping it in good shape. Such people can provide >> review (they might have board schematics) and testing. Unfortunately >> they mostly do not appear in MAINTAINERS file. Adding per-DTS entries >> to MAINTAINERS would quickly make it bloated (hundreds of new per-DTS >> entries). >> >> On the other hand there is no point in CC-ing every Copyright email >> appearing in files, because it might be outdated. Add new in-file >> pattern for storing maintainers dedicated to specific boards: >> >> Maintainer: John Smith <email> >> >> Suggested-by: Joe Perches <joe@perches.com> >> Suggested-by: Shawn Guo <shawnguo@kernel.org> >> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> This is rework of earlier approach: >> Link: https://lore.kernel.org/r/20210809080204.8381-1-shawnguo@kernel.org > > Why the rework? I think the older one is much simpler. > > I believe I forwarded the older one to Andrew Morton awhile back. > I'll check to see what happened to it. It was never merged, thus I assumed some changes are needed, e.g. to ignore emails in copyrights. Best regards, Krzysztof
On Sun, 2023-02-12 at 16:51 +0100, Krzysztof Kozlowski wrote: > On 11/02/2023 17:27, Joe Perches wrote: > > On Sat, 2023-02-11 at 13:14 +0100, Krzysztof Kozlowski wrote: > > > The DTS/DTSI files represent hardware description for Linux kernel, > > > which is necessary to properly recognize and configure hardware by > > > Linux. DTS is usually created by people having the actual hardware and > > > having interest in keeping it in good shape. Such people can provide > > > review (they might have board schematics) and testing. Unfortunately > > > they mostly do not appear in MAINTAINERS file. Adding per-DTS entries > > > to MAINTAINERS would quickly make it bloated (hundreds of new per-DTS > > > entries). > > > > > > On the other hand there is no point in CC-ing every Copyright email > > > appearing in files, because it might be outdated. That's what .mailmap is for. > > > Add new in-file > > > pattern for storing maintainers dedicated to specific boards: I think adding Maintainer: who <who@foo.tld> to each dts and dtsi file would be a lot of unnecessary changes $ git ls-files | grep -P '\.dtsi?$' | wc -l 4673 > > > This is rework of earlier approach: > > > Link: https://lore.kernel.org/r/20210809080204.8381-1-shawnguo@kernel.org > > > > Why the rework? I think the older one is much simpler. > > > > I believe I forwarded the older one to Andrew Morton awhile back. > > I'll check to see what happened to it. > > It was never merged, thus I assumed some changes are needed, e.g. to > ignore emails in copyrights. I think the old one is fine.
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index ab123b498fd9..f02a2a80c3bc 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -445,6 +445,17 @@ sub maintainers_in_file { my @poss_addr = $text =~ m$[A-Za-zÀ-ÿ\"\' \,\.\+-]*\s*[\,]*\s*[\(\<\{]{0,1}[A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+\.[A-Za-z0-9]+[\)\>\}]{0,1}$g; push(@file_emails, clean_file_emails(@poss_addr)); } + + # Match "Maintainer: email" entries only in DTS sources + if (-f $file && ($email_file_emails || $file =~ /\.dtsi?$/)) { + open(my $f, '<', $file) + or die "$P: Can't open $file: $!\n"; + my $text = do { local($/) ; <$f> }; + close($f); + + my @poss_addr = $text =~ m$Maintainer: [A-Za-zÀ-ÿ\"\' \,\.\+-]*\s*[\,]*\s*[\(\<\{]{0,1}[A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+\.[A-Za-z0-9]+[\)\>\}]{0,1}$g; + push(@file_emails, clean_file_emails(@poss_addr)); + } } #