diff mbox series

dt-bindings: mmc: Add resets property to cadence SDHCI binding

Message ID 20230209014211.17816-1-hayashi.kunihiko@socionext.com
State New
Headers
Series dt-bindings: mmc: Add resets property to cadence SDHCI binding |

Commit Message

Kunihiko Hayashi Feb. 9, 2023, 1:42 a.m. UTC 
  Cadence SDHCI controller allows reset control support on UniPhier SoC.
Add resets property to cadence SDHCI binding.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Feb. 9, 2023, 9:14 a.m. UTC | #1 
On 09/02/2023 02:42, Kunihiko Hayashi wrote:
> Cadence SDHCI controller allows reset control support on UniPhier SoC.
> Add resets property to cadence SDHCI binding.
> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> index d3dce4d6c168..adacd0535c14 100644
> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> @@ -29,6 +29,9 @@ properties:
>    clocks:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1

This looks specific to UniPhier, doesn't it?

Best regards,
Krzysztof
Kunihiko Hayashi Feb. 9, 2023, 11:34 a.m. UTC | #2 
Hi Krzysztof,

On 2023/02/09 18:14, Krzysztof Kozlowski wrote:
> On 09/02/2023 02:42, Kunihiko Hayashi wrote:
>> Cadence SDHCI controller allows reset control support on UniPhier SoC.
>> Add resets property to cadence SDHCI binding.
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>> b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>> index d3dce4d6c168..adacd0535c14 100644
>> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>> @@ -29,6 +29,9 @@ properties:
>>     clocks:
>>       maxItems: 1
>>
>> +  resets:
>> +    maxItems: 1
> 
> This looks specific to UniPhier, doesn't it?

I think this IP has some hardware reset lines, however,
it depends on the implementation whether the lines can be
soft controlled or controlled by power-on-reset.

In case of UniPhier SoC, these lines are connected to the syscon
reset controller, but deasserted with initial state.

Currently, the binding has one compatible.
If drawing this dependency, Is the device dependent compatible necessary?
Or I can remove reset property from DT.

Thank you,

---
Best Regards
Kunihiko Hayashi
Krzysztof Kozlowski Feb. 10, 2023, 11:41 a.m. UTC | #3 
On 09/02/2023 12:34, Kunihiko Hayashi wrote:
> Hi Krzysztof,
> 
> On 2023/02/09 18:14, Krzysztof Kozlowski wrote:
>> On 09/02/2023 02:42, Kunihiko Hayashi wrote:
>>> Cadence SDHCI controller allows reset control support on UniPhier SoC.
>>> Add resets property to cadence SDHCI binding.
>>>
>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>>> ---
>>>   Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> index d3dce4d6c168..adacd0535c14 100644
>>> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
>>> @@ -29,6 +29,9 @@ properties:
>>>     clocks:
>>>       maxItems: 1
>>>
>>> +  resets:
>>> +    maxItems: 1
>>
>> This looks specific to UniPhier, doesn't it?
> 
> I think this IP has some hardware reset lines, however,


Hm, fine with me. It's actually expected.

> it depends on the implementation whether the lines can be
> soft controlled or controlled by power-on-reset.
> 
> In case of UniPhier SoC, these lines are connected to the syscon
> reset controller, but deasserted with initial state.
> 
> Currently, the binding has one compatible.
> If drawing this dependency, Is the device dependent compatible necessary?
> Or I can remove reset property from DT.

No, its okay.


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
index d3dce4d6c168..adacd0535c14 100644
--- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
+++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
@@ -29,6 +29,9 @@  properties:
   clocks:
     maxItems: 1
 
+  resets:
+    maxItems: 1
+
   # PHY DLL input delays:
   # They are used to delay the data valid window, and align the window to
   # sampling clock. The delay starts from 5ns (for delay parameter equal to 0)