Message ID | 20230202153235.2412790-1-gregkh@linuxfoundation.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp313570wrn; Thu, 2 Feb 2023 07:47:19 -0800 (PST) X-Google-Smtp-Source: AK7set9GUeRp0o6IPgbRWA0e9M9KwGuL+5FlRwv83+eXvAP23Uq+QCtQ5krUTVMM1RbI6/CZqeP2 X-Received: by 2002:a17:906:c352:b0:881:44e3:baae with SMTP id ci18-20020a170906c35200b0088144e3baaemr6660149ejb.54.1675352839085; Thu, 02 Feb 2023 07:47:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675352839; cv=none; d=google.com; s=arc-20160816; b=RysymyShLgackS7mAt5SryolBavvI9+HWqIpSWCRgW7hauIZq+iQ3Tp/SrG+X+UYET +kKsbT7oIS6K2atXlSQV6ouF2XHqmrnGUtz9P2X51zayzA3zV6j33gfSk6JthClZkA4Z pDNo85Sl5YL2XFuXCGastlEswyJ5U4Oynh4FahcpFQxfzdzPDp6yaPGOFebJzMe9Gsiv 9QCQfKOdnHmU/CDXsF89nhkVkTlnXPp0KAuC+J8wtbUMeONPSMsFay9gV/izXXOq5jy0 hkYsBacg/wcjmfiqtjSPcsrLPnvNq6TNhsSyQDYF1bUVZa8xzfOWPzLF9THxS/2G00/4 DGPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=OpMCnMSRqPlUp82GXdk8tlyJFRQ6Pf5Qn1fH8B/o9uE=; b=UxtBHGCupEiE0UGCIkH2l7X11zHz8I+ab51d9ssNrZfoLMcMqUSNsv3ix61aB7Qti3 QR2Yj6yeioSk+osTFvaa1UrPz+zu3hQlQBJo//p0ATIb2o2kxqZF/fvDxGdnI56yiLXb T89AZRIKsKYZBedSCM/28e5dYL1HtTXM99YJlzZmW0EhIlZn1GzakLGzt9kAswJTsD3r 56M6c+nhrDf+sWfGtvSp9qKrENsfj8J1Bsoi9MmC8L63776fiyLuzbDu8eywd4RxMR4M vOure3/4lq/oi0CiVm5nDBLDRenij7GhaXFCNWzt71rCmIexo+JxEiZd1IzMMPLxeOv/ bB7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=meqjabsZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id uj8-20020a170907c98800b0088e016c71a3si5729796ejc.614.2023.02.02.07.46.54; Thu, 02 Feb 2023 07:47:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=meqjabsZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232759AbjBBPfn (ORCPT <rfc822;il.mystafa@gmail.com> + 99 others); Thu, 2 Feb 2023 10:35:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjBBPej (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Feb 2023 10:34:39 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEA047307C; Thu, 2 Feb 2023 07:34:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E3A9C61BB5; Thu, 2 Feb 2023 15:32:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA8F0C433D2; Thu, 2 Feb 2023 15:32:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675351966; bh=zYUhwxvav6OX9dqGVpvSV+FIFto0//6GTil1TIfrs/Y=; h=From:To:Cc:Subject:Date:From; b=meqjabsZwYpZDMReGP2gDw4ZJoKDiN9uEJKp+XYVRkF1reNpR+HczMs6SQRzOLXy8 riMdCpBpWPGdct57+Q+wJ6Y70mayWLsWE4DoRJHVsoohROCWchkMFy30elskW3XENJ W0TtDmzFZYrUCdCUG89GW1eGKqnfRyTvyZqZ3rw4= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-usb@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Peter Chen <peter.chen@kernel.org>, linux-kernel@vger.kernel.org Subject: [PATCH 01/13] USB: chipidea: fix memory leak with using debugfs_lookup() Date: Thu, 2 Feb 2023 16:32:23 +0100 Message-Id: <20230202153235.2412790-1-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=949; i=gregkh@linuxfoundation.org; h=from:subject; bh=zYUhwxvav6OX9dqGVpvSV+FIFto0//6GTil1TIfrs/Y=; b=owGbwMvMwCRo6H6F97bub03G02pJDMm3r09w/KwR4b9RY0diwv/MdwF+t6bNLfGRm/2h/8KX1LNL fgo4dMSyMAgyMciKKbJ82cZzdH/FIUUvQ9vTMHNYmUCGMHBxCsBENu1jmJ9W/tnLJT6KJXFbyTSxBw 9XsxvanWdYMHfJmeWh4kZ9vf9TT/Bs8nbbU5ExGwA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756734778522983837?= X-GMAIL-MSGID: =?utf-8?q?1756734778522983837?= |
Series |
[01/13] USB: chipidea: fix memory leak with using debugfs_lookup()
|
|
Commit Message
Greg KH
Feb. 2, 2023, 3:32 p.m. UTC
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: Peter Chen <peter.chen@kernel.org>
Cc: linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/chipidea/debug.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 23-02-02 16:32:23, Greg Kroah-Hartman wrote: > When calling debugfs_lookup() the result must have dput() called on it, > otherwise the memory will leak over time. To make things simpler, just > call debugfs_lookup_and_remove() instead which handles all of the logic > at once. > > Cc: Peter Chen <peter.chen@kernel.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Peter Chen <peter.chen@kernel.org> > --- > drivers/usb/chipidea/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c > index faf6b078b6c4..bbc610e5bd69 100644 > --- a/drivers/usb/chipidea/debug.c > +++ b/drivers/usb/chipidea/debug.c > @@ -364,5 +364,5 @@ void dbg_create_files(struct ci_hdrc *ci) > */ > void dbg_remove_files(struct ci_hdrc *ci) > { > - debugfs_remove(debugfs_lookup(dev_name(ci->dev), usb_debug_root)); > + debugfs_lookup_and_remove(dev_name(ci->dev), usb_debug_root); > } > -- > 2.39.1 >
diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c index faf6b078b6c4..bbc610e5bd69 100644 --- a/drivers/usb/chipidea/debug.c +++ b/drivers/usb/chipidea/debug.c @@ -364,5 +364,5 @@ void dbg_create_files(struct ci_hdrc *ci) */ void dbg_remove_files(struct ci_hdrc *ci) { - debugfs_remove(debugfs_lookup(dev_name(ci->dev), usb_debug_root)); + debugfs_lookup_and_remove(dev_name(ci->dev), usb_debug_root); }